New issue
Advanced search Search tips

Issue 822049 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"WindowSelectorTest.OverviewWidgetStackingOrder" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 14 2018 
"WindowSelectorTest.OverviewWidgetStackingOrder" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5XaW5kb3dTZWxlY3RvclRlc3QuT3ZlcnZpZXdXaWRnZXRTdGFja2luZ09yZGVyDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by crouleau@chromium.org, Mar 15 2018 

[ RUN      ] WindowSelectorTest.OverviewWidgetStackingOrder
../../ash/wm/overview/window_selector_unittest.cc:2605: Failure
Expected: (index_of(widget2->GetNativeWindow(), parent)) > (index_of(widget3->GetNativeWindow(), parent)), actual: 3 vs 6
../../ash/wm/overview/window_selector_unittest.cc:2627: Failure
Expected: (index_of(widget2->GetNativeWindow(), parent)) > (index_of(min_widget2->GetNativeWindow(), parent)), actual: 3 vs 7
../../ash/wm/overview/window_selector_unittest.cc:2647: Failure
Expected: (index_of(widget2->GetNativeWindow(), parent)) > (index_of(widget3->GetNativeWindow(), parent)), actual: 3 vs 6
[2895:2945:0314/134558.049489:2672952922:ERROR:gl_context_virtual.cc(39)] Trying to make virtual context current without decoder.
[2895:2945:0314/134558.050782:2672954214:ERROR:gl_context_virtual.cc(39)] Trying to make virtual context current without decoder.
[  FAILED  ] WindowSelectorTest.OverviewWidgetStackingOrder (111 ms)

Comment 2 by crouleau@chromium.org, Mar 15 2018

Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)
Test was introduced Feb 13: https://chromium-review.googlesource.com/c/chromium/src/+/909301

Comment 3 by crouleau@chromium.org, Mar 15 2018 

See also  issue 821999
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abf25fb6c4289e40819387a3b28cf8b098662b49

commit abf25fb6c4289e40819387a3b28cf8b098662b49
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Mar 15 00:32:39 2018

Disable flaky OverviewWidgetStackingOrder

TBR=sammiequon@chromium.org

Bug:  822049 
Change-Id: I25c7cf6bd7d4f1641c37afaaa176d7b24f674c39
Reviewed-on: https://chromium-review.googlesource.com/963153
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543256}
[modify] https://crrev.com/abf25fb6c4289e40819387a3b28cf8b098662b49/ash/wm/overview/window_selector_unittest.cc

Comment 5 by rogerta@chromium.org, Mar 15 2018

Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92d3c1671a7914c2f0e60326e47b8541d7c3f33e

commit 92d3c1671a7914c2f0e60326e47b8541d7c3f33e
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Mar 16 00:13:13 2018

overview: Fix stacking order for new UI.

New UI bypasses some animations when in tablet mode. Old UI relied on
animation ended to stack windows properly. After this patch lands, the
enable new overview UI patch should be able to reland safely.

Test: ash_unittests WindowSelectorTest.OverviewWidgetStackingOrder
Bug:  821999 ,  822049 
Change-Id: I4028b9c045b0bfc93207d2d0bc6343e634eb6c89
Reviewed-on: https://chromium-review.googlesource.com/963693
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543567}
[modify] https://crrev.com/92d3c1671a7914c2f0e60326e47b8541d7c3f33e/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/92d3c1671a7914c2f0e60326e47b8541d7c3f33e/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/92d3c1671a7914c2f0e60326e47b8541d7c3f33e/ash/wm/overview/window_selector_unittest.cc

Comment 7 by sammiequon@chromium.org, Mar 16 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment