Ship Mojo core as a shared library for Chrome OS and ARC++ |
|||||||||||||
Issue descriptionWe should fix the version skew problem across Chrome OS and ARC++ by shipping a shared library with Chrome. This should have a stable ABI to replace EDK usage, and it should integrate with existing libmojo/libchrome usage to make the transition as easy as possible. Doc: https://goo.gl/SuKZ7Q
,
Mar 23 2018
,
Mar 23 2018
,
Mar 23 2018
,
Mar 23 2018
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/898d796d597764726a2863b540dbfc63672a94cf commit 898d796d597764726a2863b540dbfc63672a94cf Author: Ken Rockot <rockot@chromium.org> Date: Fri Mar 23 19:03:52 2018 More EDK cleanup Some restructuring and cleanup of EDK code and targets: - //mojo/edk/system sources are merged into //mojo/edk:core - embedder_internal.h is removed - mojo::edk::internal::g_core is replaced with mojo:edk::Core::Get(). - Core ownership and initialization is moved into entrypoints.cc, where (a) it's used most frequently and (b) it can be shared with mojo_core in a follow-up patch. Bug: 822034 Change-Id: I193549101f00aaf5b95764eeee7065423d6576e5 Reviewed-on: https://chromium-review.googlesource.com/977900 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545543} [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/BUILD.gn [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/embedder/embedder.cc [delete] https://crrev.com/a6ca5b9b7a337cdeb8a601932f0300a207c3fe93/mojo/edk/embedder/embedder_internal.h [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/embedder/embedder_unittest.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/embedder/entrypoints.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/embedder/entrypoints.h [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/embedder/incoming_broker_client_invitation.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/embedder/outgoing_broker_client_invitation.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/embedder/peer_connection.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/embedder/scoped_ipc_support.cc [delete] https://crrev.com/a6ca5b9b7a337cdeb8a601932f0300a207c3fe93/mojo/edk/embedder/test_embedder.cc [delete] https://crrev.com/a6ca5b9b7a337cdeb8a601932f0300a207c3fe93/mojo/edk/embedder/test_embedder.h [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/BUILD.gn [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/broker_posix.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/channel.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/core.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/core.h [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/core_test_base.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/core_test_base.h [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/core_unittest.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/data_pipe_consumer_dispatcher.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/data_pipe_producer_dispatcher.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/mapping_table.h [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/message_pipe_dispatcher.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/node_controller.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/shared_buffer_dispatcher.cc [modify] https://crrev.com/898d796d597764726a2863b540dbfc63672a94cf/mojo/edk/system/user_message_impl.cc
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/773a51f03d609ab5c6728a4fabe745a16134dd99 commit 773a51f03d609ab5c6728a4fabe745a16134dd99 Author: Ken Rockot <rockot@chromium.org> Date: Sat Mar 24 09:01:12 2018 Initial support for mojo_core shared library Wires the system API up to a new mojo_core shared library iff the GN arg |enable_mojo_core_library| is set to |true|. It is unconditionally set to |false| for now. mojo/edk:core is templated and stamped out into two targets, mojo/edk:impl_for_edk and mojo/edk:impl_for_mojo_core, repurposing the core sources sources to build mojo_core without EDK symbol exports. The public system API is updated with the addition of a trivial MojoInitialize() call. Applications consuming mojo_core must call this instead of mojo::edk::Init etc. A follow-up CL will enable the library on Chrome OS and Linux, add mojo_core_unittests to some buildbots, and update what gets packaged with the binary distribution. Doc is here: https://goo.gl/jyCYRe (google.com only) Bug: 822034 Test: Manually enable |enable_mojo_core_library| and run mojo_core_unittests Change-Id: Iff45f3687f5a1830691026a3dc4030994d33e70a Reviewed-on: https://chromium-review.googlesource.com/978361 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545684} [modify] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/edk/BUILD.gn [modify] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/edk/embedder/entrypoints.cc [add] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/edk/mojo_core.cc [add] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/edk/mojo_core_library.gni [add] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/edk/mojo_core_unittest.cc [add] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/edk/run_all_core_unittests.cc [modify] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/public/c/system/BUILD.gn [modify] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/public/c/system/functions.h [delete] https://crrev.com/16c3e0414e8b9d4d6478570c48d0b01326d7c753/mojo/public/c/system/set_thunks_for_app.cc [modify] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/public/c/system/thunks.cc [modify] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/public/c/system/thunks.h [modify] https://crrev.com/773a51f03d609ab5c6728a4fabe745a16134dd99/mojo/public/c/system/types.h
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6 commit 6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6 Author: Ken Rockot <rockot@chromium.org> Date: Wed Mar 28 01:23:54 2018 Enable dynamic mojo_core loading on Linux and Chrome OS Removes the |enable_mojo_core_library| GN arg in favor of explicit OS checks in GN and the single relevant source file (thunks.cc). Enables the new behavior for Chrome OS and Linux only. Replaces build-time dynamic linkage to libmojo_core with runtime loading of the library when MojoInitialize() is called in lieu of explicit EDK initialization. Adds the mojo_core_unittests suite to Linux and Chrome OS bot configurations. This must be its own test suite to ensure that the executable has no EDK dependencies and that only Mojo public APIs are used. Bug: 822034 Change-Id: Ia6fb80e0c36111c08f8ee2510a90dc81b4f6e5c3 Reviewed-on: https://chromium-review.googlesource.com/978368 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#546360} [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/base/threading/thread_restrictions.h [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/mojo/edk/BUILD.gn [delete] https://crrev.com/1ea449dcf22ac62402c9383fc17bc121e613fcef/mojo/edk/mojo_core_library.gni [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/mojo/public/c/system/BUILD.gn [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/mojo/public/c/system/thunks.cc [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/testing/buildbot/chromium.linux.json [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/6e338b0a221ce40cd4213b0a8e8a7b7434dc3bb6/testing/buildbot/test_suites.pyl
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3225ffb5cb946c99601173f3ab4da3e0cedf6019 commit 3225ffb5cb946c99601173f3ab4da3e0cedf6019 Author: Ken Rockot <rockot@chromium.org> Date: Mon Apr 23 23:36:51 2018 Ensure libmojo_core.so is built for Chrome OS builds Makes the mojo_core shared library a data dependency of the chrome binary target on Chrome OS to ensure that it gets built whenever chrome gets built. A follow-up change to chromite will cause this to be included in device deployments. Also adds a linker script to ensure that symbol exports are limited to MojoGetSystemThunks. Bug: 822034 Change-Id: Iad03f28377ecc5094c2019b22c723d7705242230 Reviewed-on: https://chromium-review.googlesource.com/1024750 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#552901} [modify] https://crrev.com/3225ffb5cb946c99601173f3ab4da3e0cedf6019/chrome/BUILD.gn [modify] https://crrev.com/3225ffb5cb946c99601173f3ab4da3e0cedf6019/mojo/edk/BUILD.gn [add] https://crrev.com/3225ffb5cb946c99601173f3ab4da3e0cedf6019/mojo/edk/export_only_thunks_api.lst
,
Apr 24 2018
,
Apr 24 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9d539a56b8b5e1e5909db879900f625f546d62dd commit 9d539a56b8b5e1e5909db879900f625f546d62dd Author: Ken Rockot <rockot@chromium.org> Date: Thu Apr 26 06:00:31 2018 Include libmojo_core.so in Chrome deployment Enusures that libmojo_core.so is copied along with any deployment of Chrome to a Chrome OS device. BUG=chromium:822034 TEST=Run deploy_chrome and verify that the file is copied Change-Id: I78a1762dab579d7ab998dd009a1f63bd7aefc6b2 Reviewed-on: https://chromium-review.googlesource.com/1026515 Commit-Ready: Ken Rockot <rockot@chromium.org> Tested-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/9d539a56b8b5e1e5909db879900f625f546d62dd/lib/chrome_util.py
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/344eacf147bf39d4754fadc5b39408840f28fdcb commit 344eacf147bf39d4754fadc5b39408840f28fdcb Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 26 08:06:09 2018 Roll src/third_party/chromite/ 48a13aacf..aa6cca469 (9 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/48a13aacf880..aa6cca46950b $ git log 48a13aacf..aa6cca469 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 lepton cros_vm: Use a smaller virtual network. 2018-04-24 laszio afdo: refining codes 2018-04-10 dgarrett chromeos_config: TRYBOT -> SWARMING. 2018-04-24 rockot Include libmojo_core.so in Chrome deployment 2018-04-19 pberny chromeos_config: Add sign_types to meowth release 2018-04-20 achuith cros_run_vm_test: Support for fetching results. 2018-04-17 bmgordon cbuildbot: Add --previous-build-state option 2018-04-13 bmgordon build_summary: Helper class to represent build summaries 2018-04-24 dgarrett cros tryjob: Always use PRODUCTION_TRYJOB display label. Created with: roll-dep src/third_party/chromite BUG=chromium:808045,chromium:829170,chromium:None,chromium:822034,chromium:835061,chromium:829665,chromium:829665,chromium:832768 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7d1aa5c4c4bd153fd47f6d7cc7532ac35cdff73b Reviewed-on: https://chromium-review.googlesource.com/1029771 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553948} [modify] https://crrev.com/344eacf147bf39d4754fadc5b39408840f28fdcb/DEPS
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58eabf0b4f69f136629286538c31c10e9375c51c commit 58eabf0b4f69f136629286538c31c10e9375c51c Author: Ken Rockot <rockot@chromium.org> Date: Sat Apr 28 03:01:04 2018 Build 32- and 64-bit Android mojo_core for Chrome OS distribution Causes Chrome builds for Chrome OS to emit additional 32-bit and 64-bit copies of the mojo_core shared library built against the Android toolchain, for use from within the ARC++ container. In order to support building these library targets, this also modifies DEPS to include a minimal set of required Android support tools and libraries in chromeos checkouts. Bug: 822034 Change-Id: I219837de3076490cdea8315e6cc98c5432871ea0 Reviewed-on: https://chromium-review.googlesource.com/1026203 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#554617} [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/DEPS [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/build/config/BUILD.gn [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/build/config/android/abi.gni [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/build/config/android/config.gni [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/build/config/compiler/BUILD.gn [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/build/config/compiler/compiler.gni [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/build/toolchain/toolchain.gni [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/chrome/BUILD.gn [modify] https://crrev.com/58eabf0b4f69f136629286538c31c10e9375c51c/mojo/edk/BUILD.gn
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9591f2badbd80682049c16a00df7df1625fce19e commit 9591f2badbd80682049c16a00df7df1625fce19e Author: Abhishek Arya <inferno@chromium.org> Date: Sat Apr 28 06:17:55 2018 Revert "Build 32- and 64-bit Android mojo_core for Chrome OS distribution" This reverts commit 58eabf0b4f69f136629286538c31c10e9375c51c. Reason for revert: Broke ChromeOS ASan builder Original change's description: > Build 32- and 64-bit Android mojo_core for Chrome OS distribution > > Causes Chrome builds for Chrome OS to emit additional 32-bit and > 64-bit copies of the mojo_core shared library built against the > Android toolchain, for use from within the ARC++ container. > > In order to support building these library targets, this also > modifies DEPS to include a minimal set of required Android support > tools and libraries in chromeos checkouts. > > Bug: 822034 > Change-Id: I219837de3076490cdea8315e6cc98c5432871ea0 > Reviewed-on: https://chromium-review.googlesource.com/1026203 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554617} TBR=rockot@chromium.org,dpranke@chromium.org Change-Id: I2e2b0d3500aa948f15ec7cf0ff024f7a82fd719d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822034 Reviewed-on: https://chromium-review.googlesource.com/1033369 Reviewed-by: Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#554632} [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/DEPS [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/build/config/BUILD.gn [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/build/config/android/abi.gni [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/build/config/android/config.gni [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/build/config/compiler/BUILD.gn [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/build/config/compiler/compiler.gni [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/build/toolchain/toolchain.gni [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/chrome/BUILD.gn [modify] https://crrev.com/9591f2badbd80682049c16a00df7df1625fce19e/mojo/edk/BUILD.gn
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7339fe55fad7bfc716dad925cf802c0021a16c20 commit 7339fe55fad7bfc716dad925cf802c0021a16c20 Author: Ken Rockot <rockot@chromium.org> Date: Mon Apr 30 21:17:17 2018 DEPS: Default cros_board to empty Changes the default cros_board value in DEPS from "amd64-generic" to the empty string. Changes the cros SDK deps to then be additionally gated on cros_board being non-empty. This is in preparation for setting target_os=["chromeos"] in gclient configs for all Chrome OS builders, including desktop Chrome OS, without causing the latter to pull in unnecessary SDK deps. Bug: 822034 Change-Id: I04b62c366731e4c18722df45767a2868c10d8b11 Reviewed-on: https://chromium-review.googlesource.com/1036003 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554877} [modify] https://crrev.com/7339fe55fad7bfc716dad925cf802c0021a16c20/DEPS
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/0d1038792abe452457eb242e529353ff0f08672e commit 0d1038792abe452457eb242e529353ff0f08672e Author: Ben Pastene <bpastene@chromium.org> Date: Mon Apr 30 23:26:38 2018 Set target_os=chromeos on all linux chromeos bots. Needed by CL:1035619 to get linux-chromeos bots to fetch needed android sdk/deps. Bug: 822034 Change-Id: I5017461e2cbc40e5e2eadf8e17e358add9ef2728 Reviewed-on: https://chromium-review.googlesource.com/1036443 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/0d1038792abe452457eb242e529353ff0f08672e/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py [modify] https://crrev.com/0d1038792abe452457eb242e529353ff0f08672e/scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py [modify] https://crrev.com/0d1038792abe452457eb242e529353ff0f08672e/scripts/slave/recipe_modules/chromium_tests/chromium_lkgr.py [modify] https://crrev.com/0d1038792abe452457eb242e529353ff0f08672e/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [modify] https://crrev.com/0d1038792abe452457eb242e529353ff0f08672e/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/027d7fa1c191f60f754985b9c235597f8c9a2081 commit 027d7fa1c191f60f754985b9c235597f8c9a2081 Author: Ken Rockot <rockot@chromium.org> Date: Tue May 01 03:10:06 2018 Build 32- and 64-bit Android mojo_core for Chrome OS distribution This is an unmodified reland of r554617 after fixing cases where target_os=["chromeos"] was not set in some Chrome OS builders' gclient configs. Causes Chrome builds for Chrome OS to emit additional 32-bit and 64-bit copies of the mojo_core shared library built against the Android toolchain, for use from within the ARC++ container. In order to support building these library targets, this also modifies DEPS to include a minimal set of required Android support tools and libraries in chromeos checkouts. Bug: 822034 Change-Id: I0e6ae87a1b9da80b82c40fd637a5be07dd7b8272 Reviewed-on: https://chromium-review.googlesource.com/1035619 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#554983} [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/DEPS [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/build/config/BUILD.gn [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/build/config/android/abi.gni [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/build/config/android/config.gni [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/build/config/compiler/BUILD.gn [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/build/config/compiler/compiler.gni [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/build/toolchain/toolchain.gni [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/chrome/BUILD.gn [modify] https://crrev.com/027d7fa1c191f60f754985b9c235597f8c9a2081/mojo/edk/BUILD.gn
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/8afed713bc4bd1b3d2728e85ddf6aceb5485d77b commit 8afed713bc4bd1b3d2728e85ddf6aceb5485d77b Author: Ben Pastene <bpastene@chromium.org> Date: Tue May 01 05:06:08 2018 Fix gn gen on chromium.chromiumos Linux ChromiumOS Full builder. TBR=dpranke@chromium.org BUG=822034 Change-Id: I773b7678c30e739747476ded2615469c6205efa7 Reviewed-on: https://chromium-review.googlesource.com/1036850 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/8afed713bc4bd1b3d2728e85ddf6aceb5485d77b/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py
,
May 1 2018
This change breaks go/simplechrome at "gn args" with error lines: Generating files... ERROR at //build/config/android/config.gni:20:7: Assertion failed. assert(checkout_android_native_support, ^----- Missing native Android toolchain support. |target_os| in your .gclient configuration must include "android" and/or "chromeos". See //media/midi/BUILD.gn:5:1: whence it was imported. import("//build/config/android/config.gni") ^----------------------------------------- See //BUILD.gn:167:7: which caused the file to be included. "//media/midi:midi_unittests", ^----------------------------
,
May 1 2018
As the error message states and as announced publicly[1], target_os=["chromeos"] in .gclient is now required for Chrome OS builds [1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/_yK9PpUKT60
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c77b371695be9335ffe86608871d9dc2fd537d8a commit c77b371695be9335ffe86608871d9dc2fd537d8a Author: Ken Rockot <rockot@chromium.org> Date: Tue May 01 23:33:34 2018 Fix linux OS check for generate_linker_map This was changed by r554983, which really should have only changed the android OS check, as Linux builds also need to support NaCl toolchains where current_os != "linux". Bug: 822034 Change-Id: I5ca924516158bdd6228b947f32db6b614d1caacd Reviewed-on: https://chromium-review.googlesource.com/1038430 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555228} [modify] https://crrev.com/c77b371695be9335ffe86608871d9dc2fd537d8a/build/toolchain/toolchain.gni
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1da30cab1d95b4d161e3ab570de0ed413fa97af0 commit 1da30cab1d95b4d161e3ab570de0ed413fa97af0 Author: Ken Rockot <rockot@chromium.org> Date: Thu May 17 00:02:59 2018 Stabilize core Mojo ABI Removes the last dubious API surface (size_t usage) in the core ABI and documents the ABI as stable. Bug: 822034, 819046 Change-Id: I60438dd6613d45738514a92ce8c21777b859bfee Reviewed-on: https://chromium-review.googlesource.com/1062932 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559348} [modify] https://crrev.com/1da30cab1d95b4d161e3ab570de0ed413fa97af0/mojo/edk/embedder/entrypoints.cc [modify] https://crrev.com/1da30cab1d95b4d161e3ab570de0ed413fa97af0/mojo/edk/system/multiprocess_message_pipe_unittest.cc [modify] https://crrev.com/1da30cab1d95b4d161e3ab570de0ed413fa97af0/mojo/public/c/system/message_pipe.h [modify] https://crrev.com/1da30cab1d95b4d161e3ab570de0ed413fa97af0/mojo/public/c/system/thunks.cc [modify] https://crrev.com/1da30cab1d95b4d161e3ab570de0ed413fa97af0/mojo/public/c/system/thunks.h [modify] https://crrev.com/1da30cab1d95b4d161e3ab570de0ed413fa97af0/mojo/public/cpp/system/message.h
,
May 17 2018
,
May 18 2018
,
May 18 2018
,
May 18 2018
Actually unblocking here. Once we flip the switch to copy the arc libs in chromite, I'll call this fixed.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b887ecda57d640485f7b9ad2f5a72b54fe9d10bc commit b887ecda57d640485f7b9ad2f5a72b54fe9d10bc Author: Ken Rockot <rockot@chromium.org> Date: Thu May 24 07:23:10 2018 Add ARC++ Mojo support libs to chrome deployment Adds two new binaries to the chrome deployment: libmojo_core_arc32.so libmojo_core_arc64.so These are respectively the 32-bit and 64-bit Mojo core implementations built against Android toolchains. The libraries are built in all Chrome OS Chrome build configurations. BUG=chromium:822034 TEST=Run deploy_chrome and verify that the new files are copied Change-Id: Ic40333d623be1338bf5f57b900caacc9081593c6 Reviewed-on: https://chromium-review.googlesource.com/1066085 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/b887ecda57d640485f7b9ad2f5a72b54fe9d10bc/lib/chrome_util.py
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e2725e581ca466961018a7f154f905544cbe7df commit 8e2725e581ca466961018a7f154f905544cbe7df Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 24 10:24:06 2018 Roll src/third_party/chromite/ 02f8ae585..b887ecda5 (1 commit) https://chromium.googlesource.com/chromiumos/chromite.git/+log/02f8ae585af8..b887ecda57d6 $ git log 02f8ae585..b887ecda5 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 rockot Add ARC++ Mojo support libs to chrome deployment Created with: roll-dep src/third_party/chromite BUG=chromium:822034 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6cde13dee4c436f61fb8a14598575f3e0ad70110 Reviewed-on: https://chromium-review.googlesource.com/1071239 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561450} [modify] https://crrev.com/8e2725e581ca466961018a7f154f905544cbe7df/DEPS
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/13f43437558c844f554b77b63b5fa2b17aacdd59 commit 13f43437558c844f554b77b63b5fa2b17aacdd59 Author: Xiaoyin Hu <xiaoyinh@chromium.org> Date: Fri May 25 17:03:56 2018 Revert "Add ARC++ Mojo support libs to chrome deployment" This reverts commit b887ecda57d640485f7b9ad2f5a72b54fe9d10bc. Reason for revert: this breaks chrome pfq. See crbug.com/846393 . Original change's description: > Add ARC++ Mojo support libs to chrome deployment > > Adds two new binaries to the chrome deployment: > > libmojo_core_arc32.so > libmojo_core_arc64.so > > These are respectively the 32-bit and 64-bit Mojo core implementations > built against Android toolchains. The libraries are built in all Chrome > OS Chrome build configurations. > > BUG=chromium:822034 > TEST=Run deploy_chrome and verify that the new files are copied > > Change-Id: Ic40333d623be1338bf5f57b900caacc9081593c6 > Reviewed-on: https://chromium-review.googlesource.com/1066085 > Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> > Tested-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> Bug: chromium:822034 Change-Id: I0353c6fbf06508c56c06238db57d722d5121d093 Reviewed-on: https://chromium-review.googlesource.com/1072927 Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Tested-by: Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> [modify] https://crrev.com/13f43437558c844f554b77b63b5fa2b17aacdd59/lib/chrome_util.py
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1bfedd9d46838fc7381447228f221a562ba6c06 commit a1bfedd9d46838fc7381447228f221a562ba6c06 Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 25 19:17:15 2018 Roll src/third_party/chromite/ 04b73c195..13f434375 (1 commit) https://chromium.googlesource.com/chromiumos/chromite.git/+log/04b73c195727..13f43437558c $ git log 04b73c195..13f434375 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 xiaoyinh Revert "Add ARC++ Mojo support libs to chrome deployment" Created with: roll-dep src/third_party/chromite BUG=chromium:822034 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id8c9baa63b8186441590a368e7e73dd845296c83 Reviewed-on: https://chromium-review.googlesource.com/1073105 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561967} [modify] https://crrev.com/a1bfedd9d46838fc7381447228f221a562ba6c06/DEPS
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/cd3d62eedcf749ffcbccea52b34247b1eab6fb80 commit cd3d62eedcf749ffcbccea52b34247b1eab6fb80 Author: Xiaoyin Hu <xiaoyinh@chromium.org> Date: Tue May 29 23:39:44 2018 Revert "Add ARC++ Mojo support libs to chrome deployment" This reverts commit b887ecda57d640485f7b9ad2f5a72b54fe9d10bc. Reason for revert: this breaks chrome pfq. See crbug.com/846393 . Original change's description: > Add ARC++ Mojo support libs to chrome deployment > > Adds two new binaries to the chrome deployment: > > libmojo_core_arc32.so > libmojo_core_arc64.so > > These are respectively the 32-bit and 64-bit Mojo core implementations > built against Android toolchains. The libraries are built in all Chrome > OS Chrome build configurations. > > BUG=chromium:822034 > TEST=Run deploy_chrome and verify that the new files are copied > > Change-Id: Ic40333d623be1338bf5f57b900caacc9081593c6 > Reviewed-on: https://chromium-review.googlesource.com/1066085 > Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> > Tested-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> Bug: chromium:822034 Change-Id: I0353c6fbf06508c56c06238db57d722d5121d093 Reviewed-on: https://chromium-review.googlesource.com/1072927 Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Tested-by: Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> (cherry picked from commit 13f43437558c844f554b77b63b5fa2b17aacdd59) Reviewed-on: https://chromium-review.googlesource.com/1075987 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> Trybot-Ready: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/cd3d62eedcf749ffcbccea52b34247b1eab6fb80/lib/chrome_util.py
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc7b355a9cdde940b334a11cfab0d788c692dad7 commit bc7b355a9cdde940b334a11cfab0d788c692dad7 Author: Nico Weber <thakis@chromium.org> Date: Wed Jun 06 17:00:26 2018 Run mojo_core_unittests on clang and memory bots. mojo_core_unittests was added to the main waterfall in https://chromium-review.googlesource.com/c/chromium/src/+/978368/11, but not to the main and clang tot waterfalls. Things that run on the main waterfall should run on the memory bots (needed to check correctness), and they must run on the clang tot waterfall to make sure new compilers don't break them. Bug: 843511,822034 Change-Id: I4431298f53d967e4aa3d7fa3b98c3d4a27ffb9bb Reviewed-on: https://chromium-review.googlesource.com/1088761 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#564930} [modify] https://crrev.com/bc7b355a9cdde940b334a11cfab0d788c692dad7/testing/buildbot/chromium.clang.json [modify] https://crrev.com/bc7b355a9cdde940b334a11cfab0d788c692dad7/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/bc7b355a9cdde940b334a11cfab0d788c692dad7/testing/buildbot/chromium.memory.json [modify] https://crrev.com/bc7b355a9cdde940b334a11cfab0d788c692dad7/testing/buildbot/test_suites.pyl
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/29f54a30992a4837e08c30d9ccdd7eb1855d0365 commit 29f54a30992a4837e08c30d9ccdd7eb1855d0365 Author: Ken Rockot <rockot@chromium.org> Date: Wed Jun 20 08:43:24 2018 Add Android mojo_core binaries to Chrome deployment [This is essentially a re-land of https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1066085 with some bugs addressed.] Copies the 32- and 64-bit mojo_core DSOs built against the Android NDK along with the rest of the cros Chrome deployment. Stripping is disabled here because the toolchain used by chromite (at least in TestSimpleChromeWorkflow on pfq) is incapable of stripping such binaries (see https://crbug.com/846393 ). This is fine since they're already stripped at build-time with an appropriate toolchain anyway. These files are also completely excluded from the chromite.cros.test.image_test.SymbolsTest.TestImportedSymbolsAreAvailable since their NDK symbol imports can't be satisfied within the test environment (see https://crbug.com/848082 ). Bug: 822034 Change-Id: Ida58ed66ddcdc17d814500a8699aeb6c50ae8833 Reviewed-on: https://chromium-review.googlesource.com/1106281 Commit-Ready: Ken Rockot <rockot@chromium.org> Tested-by: Ken Rockot <rockot@google.com> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/29f54a30992a4837e08c30d9ccdd7eb1855d0365/cros/test/image_test.py [modify] https://crrev.com/29f54a30992a4837e08c30d9ccdd7eb1855d0365/lib/chrome_util.py
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c8a626f49c098571561af9fdc2e560d652de34bd commit c8a626f49c098571561af9fdc2e560d652de34bd Author: Xiaoqian Dai <xdai@chromium.org> Date: Mon Jun 25 18:21:52 2018 Revert "Add Android mojo_core binaries to Chrome deployment" This reverts commit 29f54a30992a4837e08c30d9ccdd7eb1855d0365. Reason for revert: It broke Chrome PFQ for a few days, See crbug.com/856144 for more details. Original change's description: > Add Android mojo_core binaries to Chrome deployment > > [This is essentially a re-land of > https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1066085 > with some bugs addressed.] > > Copies the 32- and 64-bit mojo_core DSOs built against the Android NDK > along with the rest of the cros Chrome deployment. > > Stripping is disabled here because the toolchain used by chromite (at > least in TestSimpleChromeWorkflow on pfq) is incapable of stripping such > binaries (see https://crbug.com/846393 ). This is fine since they're already > stripped at build-time with an appropriate toolchain anyway. > > These files are also completely excluded from the > chromite.cros.test.image_test.SymbolsTest.TestImportedSymbolsAreAvailable > since their NDK symbol imports can't be satisfied within the test > environment (see https://crbug.com/848082 ). > > Bug: 822034 > Change-Id: Ida58ed66ddcdc17d814500a8699aeb6c50ae8833 > Reviewed-on: https://chromium-review.googlesource.com/1106281 > Commit-Ready: Ken Rockot <rockot@chromium.org> > Tested-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dan Erat <derat@chromium.org> Bug: 822034 Change-Id: I9e8cc3affb2fa074c0ee46e4f4b95db796643dca Reviewed-on: https://chromium-review.googlesource.com/1113957 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Tested-by: Xiaoqian Dai <xdai@chromium.org> Trybot-Ready: Xiaoqian Dai <xdai@chromium.org> [modify] https://crrev.com/c8a626f49c098571561af9fdc2e560d652de34bd/cros/test/image_test.py [modify] https://crrev.com/c8a626f49c098571561af9fdc2e560d652de34bd/lib/chrome_util.py
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/139f97c9280ce00f7d7f1aab0e474da2207c0b57 commit 139f97c9280ce00f7d7f1aab0e474da2207c0b57 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Jun 25 20:11:58 2018 Roll src/third_party/chromite abae09e75336..c8a626f49c09 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/abae09e75336..c8a626f49c09 git log abae09e75336..c8a626f49c09 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 xdai@chromium.org Revert "Add Android mojo_core binaries to Chrome deployment" Created with: gclient setdep -r src/third_party/chromite@c8a626f49c09 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:822034 TBR=chrome-os-gardeners@chromium.org Change-Id: I6f0bc61794ea73128958886893bebc99251997ea Reviewed-on: https://chromium-review.googlesource.com/1113824 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570145} [modify] https://crrev.com/139f97c9280ce00f7d7f1aab0e474da2207c0b57/DEPS
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c03de9ae4eefba5ea3a8abd5bbea573a12105582 commit c03de9ae4eefba5ea3a8abd5bbea573a12105582 Author: Ken Rockot <rockot@chromium.org> Date: Wed Jun 27 20:52:36 2018 Reland "Add Android mojo_core binaries to Chrome deployment" This is a reland of 29f54a30992a4837e08c30d9ccdd7eb1855d0365 The underlying failure which led to its revert was actually a bug in an autotest script, tripped by these libraries. The bug is https://crbug.com/856144 and is fixed by https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1114198 This CL will be sent to the CQ after that one lands. Original change's description: > Add Android mojo_core binaries to Chrome deployment > > [This is essentially a re-land of > https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1066085 > with some bugs addressed.] > > Copies the 32- and 64-bit mojo_core DSOs built against the Android NDK > along with the rest of the cros Chrome deployment. > > Stripping is disabled here because the toolchain used by chromite (at > least in TestSimpleChromeWorkflow on pfq) is incapable of stripping such > binaries (see https://crbug.com/846393 ). This is fine since they're already > stripped at build-time with an appropriate toolchain anyway. > > These files are also completely excluded from the > chromite.cros.test.image_test.SymbolsTest.TestImportedSymbolsAreAvailable > since their NDK symbol imports can't be satisfied within the test > environment (see https://crbug.com/848082 ). > > Bug: 822034 > Change-Id: Ida58ed66ddcdc17d814500a8699aeb6c50ae8833 > Reviewed-on: https://chromium-review.googlesource.com/1106281 > Commit-Ready: Ken Rockot <rockot@chromium.org> > Tested-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dan Erat <derat@chromium.org> Bug: 822034 Change-Id: Iaff9e02a1cc9f16347f71fe1aef01acb32270645 TBR=stevenjb@chromium.org TBR=derat@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1113959 Commit-Ready: Ken Rockot <rockot@chromium.org> Tested-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> [modify] https://crrev.com/c03de9ae4eefba5ea3a8abd5bbea573a12105582/cros/test/image_test.py [modify] https://crrev.com/c03de9ae4eefba5ea3a8abd5bbea573a12105582/lib/chrome_util.py
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b539e97e3f700603836381f2f6945a4a40bf8505 commit b539e97e3f700603836381f2f6945a4a40bf8505 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Jun 28 00:20:43 2018 Roll src/third_party/chromite 47bb72284a37..c03de9ae4eef (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/47bb72284a37..c03de9ae4eef git log 47bb72284a37..c03de9ae4eef --date=short --no-merges --format='%ad %ae %s' 2018-06-27 rockot@chromium.org Reland "Add Android mojo_core binaries to Chrome deployment" Created with: gclient setdep -r src/third_party/chromite@c03de9ae4eef The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:822034 TBR=chrome-os-gardeners@chromium.org Change-Id: I043a23d1a36caede27c009bf790e454b51473526 Reviewed-on: https://chromium-review.googlesource.com/1117539 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570968} [modify] https://crrev.com/b539e97e3f700603836381f2f6945a4a40bf8505/DEPS
,
Oct 17
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 15 2018