New issue
Advanced search Search tips

Issue 822025 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Extract grid from tab_grid

Project Member Reported by edchin@chromium.org, Mar 14 2018

Issue description

Should we move the grid* files into a subdirectory to keep the dependencies cleaner?

This task is so that we make a decision on this. 
 

Comment 1 by cmasso@google.com, Mar 15 2018

Please add the user story label here

Comment 2 by edchin@chromium.org, Mar 20 2018

Labels: S-See-Open-Tabs
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b

commit f37e9c490f371f3a52fdc2814858b1ac5ea98f1b
Author: edchin <edchin@chromium.org>
Date: Tue Mar 20 19:04:48 2018

[ios] Move grid to subdirectory under tab_grid

Bug:  822025 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I77fa15f43aa2e1fc8953fce3c5b0ec388f5afb29
Reviewed-on: https://chromium-review.googlesource.com/969990
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544468}
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/BUILD.gn
[add] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/BUILD.gn
[add] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/OWNERS
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_cell.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_cell.mm
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_commands.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_constants.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_constants.mm
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_consumer.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_image_data_source.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_item.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_item.mm
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_layout.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_layout.mm
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_theme.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[add] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/resources/BUILD.gn
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/resources/grid_cell_close_button.imageset/Contents.json
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/resources/grid_cell_close_button.imageset/grid_cell_close_button.png
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/resources/grid_cell_close_button.imageset/grid_cell_close_button@2x.png
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/resources/grid_cell_close_button.imageset/grid_cell_close_button@3x.png
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/top_aligned_image_view.h
[rename] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/grid/top_aligned_image_view.mm
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/resources/BUILD.gn
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.h
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/showcase/tab_grid/BUILD.gn
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/showcase/tab_grid/sc_grid_cell_view_controller.mm
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/showcase/tab_grid/sc_grid_coordinator.mm
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/showcase/tab_grid/sc_image_view_controller.mm
[modify] https://crrev.com/f37e9c490f371f3a52fdc2814858b1ac5ea98f1b/ios/showcase/tab_grid/sc_tab_grid_coordinator.mm

Comment 4 by edchin@chromium.org, Mar 20 2018

Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-03-28

Sign in to add a comment