New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822021 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2

Blocked on:
issue 804500



Sign in to add a comment

Accessibility for tab grid page control

Project Member Reported by edchin@chromium.org, Mar 14 2018

Issue description

We need to figure out accessibility support for the segmented control, given that it's both a control that can drive the scroll view, and an indicator of scroll view state.

 

Comment 1 by marq@chromium.org, Mar 15 2018

Be sure to use the UIControl-specific accessibility attributes for this (https://developer.apple.com/documentation/uikit/uicontrol?language=objc#overview).

Comment 2 by cmasso@google.com, Mar 15 2018

Please add the user story label here

Comment 3 by edchin@chromium.org, Mar 21 2018

Status: Started (was: Assigned)

Comment 4 by cmasso@google.com, Mar 27 2018

Any update Ed?

Comment 5 by edchin@chromium.org, Mar 28 2018

Labels: -Q1 -small -S-See-Open-Tabs medium Q2 S-Tab-Grid-Polish
There are some technical barriers related to VoiceOver that I has prevented this story from completion. I am putting this work aside for now, given it is not high priority. I have filed a radar, and will work on this in Q2. 
The NextAction date has arrived: 2018-03-28
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f663172fed2b0f1123717ca96bdec410f1c72ad

commit 5f663172fed2b0f1123717ca96bdec410f1c72ad
Author: edchin <edchin@chromium.org>
Date: Fri Mar 30 22:26:30 2018

[ios] Accessibility for tab grid page control

This is an initial CL for accessibility for the tab grid page control.

This CL:
- Sets tappable targets for each page when VoiceOver is enabled.
- Reads the title for each page (e.g., "Incognito Tabs")
- Sets unique accessibility identifiers for automated testing.

A future CL may consider/implement the following:
- Give a hint that there are 3 pages.
- Read the number of tabs in that page.

Bug:  822021 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia3ad43eb05bb71391eb74e3fd017059177686ffe
Reviewed-on: https://chromium-review.googlesource.com/988817
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547289}
[modify] https://crrev.com/5f663172fed2b0f1123717ca96bdec410f1c72ad/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h
[modify] https://crrev.com/5f663172fed2b0f1123717ca96bdec410f1c72ad/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm
[modify] https://crrev.com/5f663172fed2b0f1123717ca96bdec410f1c72ad/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm

Status: Fixed (was: Started)
Any remaining considerations for accessibility for the page control can be handled in the  crbug.com/818442 . Marking this as completed. 

Comment 9 by cmasso@google.com, Apr 10 2018

NextAction: ----

Sign in to add a comment