New issue
Advanced search Search tips

Issue 822018 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Odd behavior with new playback UI

Project Member Reported by hubbe@chromium.org, Mar 14 2018

Issue description

Chrome Version: ToT
OS: Linux (but probably occurs on all desktop OS)

What steps will reproduce the problem?
(1) Load a video file in chrome from local disk.

What is the expected result?

Video starts playing.

What happens instead?

First second of video has a white haze.
Happens again every time I reload the page. (But not if I go back to the beginning of the video.)

Video showing the weird behavior: https://photos.app.goo.gl/xf9dWVZPFok4qTRJ2
 
Cc: steimel@chromium.org
Seems to also be causing a bunch of perf regressions.
Cc: amyroberts@chromium.org
Components: Blink>Media>Controls
The white haze is a loading panel briefly showing.

+amyroberts: Since we changed the scrim to be dark, we likely also want to make the loading animation dark. Not sure if this has been discussed in the new scrim mocks, but as of right now it covers the whole video and is white. I'm assuming we at least want to change it to black.
I'd suggest skipping the loading animation entirely in some cases, i.e. don't show loading animation until after some threshold and don't show it at all if playback has already started before then.
Note, this loading animation is causing dropped frames as well.

Comment 5 by hubbe@google.com, Mar 15 2018

Graying out the video when it's playing (not stopped/paused/buffering) seems wrong to me.

Cc: beccahughes@chromium.org
+beccahughes@ who may have some background on this.

I don't think we *want* to show the grey thing on top of the video when it's playing but there might be a reason why it's happening. My memory tells me that when the animation starts, it finishes a cycle before leaving. Could that be the problem? As in, we show the animation while there is no data but immediately attempts to remove it because the data are fast to show up?
Yes that sounds like the cause. We probably don't want to show it after we have clicked the playing button though (it should show the buffering animation instead).
Cc: mlamouri@chromium.org
Owner: amyroberts@chromium.org
Status: Assigned (was: Untriaged)
Sounds good. Assigning to Amy to decide on new look (with new scrim), whether or not we want to delay until some threshold (comment #3), and whether we immediately hide the animation when playback starts
(FYI...working through some fine tuning with steimel@, will circle back to provide detailed specs)  
Owner: steimel@chromium.org
mocks reflecting 3/22 in person work session: 
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZZIx9p6vbtpx/files/MCEdOxHPn27LrkFgvwigzzh9
Is this still something we want to work on?
Status: Fixed (was: Assigned)
This has actually been fixed, we just never closed it

Sign in to add a comment