Report Component Filter error in PrinterSetupResult |
|||
Issue descriptionMore epson printers are enabled via component cups filter and we expect users to use this soon. When use tried to user a component enabled printer via USB without connecting to internet, the UI shows whatever string 'kFatalError' represents. It's generally a good thing to have fine-grained error logging for CUPS. Proposal: Add an error code - kComponentUnavailable in PrinterSetupResult. Also report this to UMA metrics.
,
Apr 24 2018
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af1b2f6ee5cbd2dd2024de8d2d7c8ec8b5f2d8bb commit af1b2f6ee5cbd2dd2024de8d2d7c8ec8b5f2d8bb Author: Xiaochu Liu <xiaochu@chromium.org> Date: Thu May 17 20:25:06 2018 Report component error in PrinterSetupResult Add an error code that represents component installation error. This error is reported in UMA metrics. It is not surfaced to user since no action items for users on such occasions. BUG= chromium:822016 TEST=manually setup a printer successfully. Change-Id: I5b9e2e9ce0cc68a51ca1ce0d7c0c2bc0b6139663 Reviewed-on: https://chromium-review.googlesource.com/1026195 Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#559659} [modify] https://crrev.com/af1b2f6ee5cbd2dd2024de8d2d7c8ec8b5f2d8bb/chrome/browser/chromeos/printing/printer_configurer.cc [modify] https://crrev.com/af1b2f6ee5cbd2dd2024de8d2d7c8ec8b5f2d8bb/chrome/browser/chromeos/printing/printer_configurer.h [modify] https://crrev.com/af1b2f6ee5cbd2dd2024de8d2d7c8ec8b5f2d8bb/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc [modify] https://crrev.com/af1b2f6ee5cbd2dd2024de8d2d7c8ec8b5f2d8bb/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc [modify] https://crrev.com/af1b2f6ee5cbd2dd2024de8d2d7c8ec8b5f2d8bb/tools/metrics/histograms/enums.xml
,
May 17 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xiaochu@chromium.org
, Apr 24 2018