Issue 822006 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	carlosk@chromium.org
Closed:	Mar 2018
Cc:	crouleau@chromium.org
Components:	UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	1
Type:	----
M-67 Filed-Via-SoM Target-67

OfflinePageRequestJobTest.BigFile in unit_tests failing on chromium.memory/Android CFI

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Mar 14 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@chromium.org

OfflinePageRequestJobTest.BigFile in unit_tests failing on chromium.memory/Android CFI

Builders failed on: 
- Android CFI: 
  https://build.chromium.org/p/chromium.memory/builders/Android%20CFI

error is 

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FAndroid_CFI%2F269%2F%2B%2Frecipes%2Fsteps%2Funit_tests_on_Android%2F0%2Flogs%2FOfflinePageRequestJobTest.BigFile%2F0

[ RUN      ] OfflinePageRequestJobTest.BigFile
../../base/test/histogram_tester.cc:186: Failure
Expected equality of these values:
  expected_count
    Which is: 0
  actual_count
    Which is: 1
Histogram "OfflinePages.ClearTemporaryPages.Result" does not have the right total number of samples (0). It has (1).

Comment 1 by crouleau@chromium.org, Mar 14 2018

Components: UI>Browser>Offline

Comment 2 by crouleau@chromium.org, Mar 14 2018

Cc: carlosk@chromium.org

OfflinePageRequestJobTest::TearDown calls 
HistogramTester::ExpectTotalCount which calls 
HistogramTester::CheckTotalCount which gives the error.

Comment 3 by crouleau@chromium.org, Mar 14 2018

Revision range https://test-results.appspot.com/revision_range?start=543120&end=543151 shows no culprit.

Comment 4 by carlosk@chromium.org, Mar 14 2018

Cc: -carlosk@chromium.org
Labels: OS-Android
Owner: carlosk@chromium.org

I'll take a look. I noticed this has either been addressed or it's flaky as, so far, it only failed in build #269 of the "Android CFI" bot.

Comment 5 by rogerta@chromium.org, Mar 15 2018

Labels: -Sheriff-Chromium
Status: Assigned (was: Available)

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76882bfb9870ca181c949ca88ae07a1aedd83c73

commit 76882bfb9870ca181c949ca88ae07a1aedd83c73
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Fri Mar 16 04:21:08 2018

Tests can disable the execution of OPM maintenance tasks

To avoid postponed maintenance tasks form effecting Chrome unit tests
this change allows the scheduling and running of them to be disabled.

Bug:  822006 
Change-Id: I042bdef8b450531d0e4699779691a3b8cc3e65f7
Reviewed-on: https://chromium-review.googlesource.com/965257
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543621}
[modify] https://crrev.com/76882bfb9870ca181c949ca88ae07a1aedd83c73/chrome/browser/offline_pages/offline_page_request_job_unittest.cc
[modify] https://crrev.com/76882bfb9870ca181c949ca88ae07a1aedd83c73/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/76882bfb9870ca181c949ca88ae07a1aedd83c73/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/76882bfb9870ca181c949ca88ae07a1aedd83c73/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc

Comment 7 by carlosk@chromium.org, Mar 16 2018

Status: Fixed (was: Assigned)

The test didn't seem to fail after that build. Nevertheless I made small modifications to avoid long-running tests from running into this failure.

Comment 8 by gab@chromium.org, Apr 10 2018

More flakes in these tests today on CQ:

[ RUN      ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1416: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1433: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
[  FAILED  ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment (177 ms)
[----------] 2 tests from OfflinePageRequestJobTest (392 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (394 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage
[ RUN      ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1416: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1433: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
[  FAILED  ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment (172 ms)
[----------] 2 tests from OfflinePageRequestJobTest (345 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (346 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage
[ RUN      ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1416: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1433: Failure
Expected equality of these values:
  kFileSize2
    Which is: 444
  bytes_read()
    Which is: 461
[  FAILED  ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment (140 ms)
[----------] 2 tests from OfflinePageRequestJobTest (357 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (358 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage

Comment 9 by kgna...@chromium.org, Apr 10 2018

Labels: -Pri-2 Target-67 M-67 Pri-1

Same error obserevd on latest M67: 67.0.3393.1 

M67 - Test-official-arm: Unit Test failed @  OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage  and OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment


M65: 65.0.3325.74 failed Test:content_browsertests  

Link to Build:
https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2601

Unit Test: unit_tests Link: 

https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2601/steps/Unit%20Test%3A%20unit_tests/logs/stdio

Full Logs: 

C  424.761s Main  Detailed Logs
C  424.761s Main  ********************************************************************************
C  424.765s Main  [FAIL] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage:
C  424.765s Main  [ RUN      ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage
C  424.765s Main  ../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:837: Failure
C  424.765s Main  Expected equality of these values:
C  424.765s Main    expected_file_size
C  424.765s Main      Which is: 444
C  424.765s Main    bytes_read()
C  424.765s Main      Which is: 461
C  424.765s Main  [  FAILED  ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage (187 ms)
C  424.765s Main  [----------] 1 test from OfflinePageRequestJobTest (187 ms total)
C  424.765s Main  
C  424.765s Main  [----------] Global test environment tear-down
C  424.765s Main  [==========] 1 test from 1 test case ran. (188 ms total)
C  424.766s Main  [  PASSED  ] 0 tests.
C  424.766s Main  [  FAILED  ] 1 test, listed below:
C  424.766s Main  [  FAILED  ] OfflinePageRequestJobTest.LoadMostRecentlyCreatedOfflinePage
C  424.766s Main  
C  424.766s Main  [FAIL] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment:
C  424.766s Main  [ RUN      ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment
C  424.766s Main  ../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1416: Failure
C  424.766s Main  Expected equality of these values:
C  424.766s Main    kFileSize2
C  424.766s Main      Which is: 444
C  424.766s Main    bytes_read()
C  424.766s Main      Which is: 461
C  424.766s Main  ../../chrome/browser/offline_pages/offline_page_request_job_unittest.cc:1433: Failure
C  424.766s Main  Expected equality of these values:
C  424.766s Main    kFileSize2
C  424.766s Main      Which is: 444
C  424.766s Main    bytes_read()
C  424.766s Main      Which is: 461
C  424.766s Main  [  FAILED  ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment (217 ms)
C  424.766s Main  [----------] 1 test from OfflinePageRequestJobTest (219 ms total)
C  424.766s Main  
C  424.766s Main  [----------] Global test environment tear-down
C  424.766s Main  [==========] 1 test from 1 test case ran. (219 ms total)
C  424.766s Main  [  PASSED  ] 0 tests.
C  424.766s Main  [  FAILED  ] 1 test, listed below:
C  424.766s Main  [  FAILED  ] OfflinePageRequestJobTest.LoadOfflinePageForUrlWithFragment

►

Issue 822006 link

Issue metadata

OfflinePageRequestJobTest.BigFile in unit_tests failing on chromium.memory/Android CFI

Issue description

Comment 1 by crouleau@chromium.org, Mar 14 2018

Comment 1 Deleted

Comment 2 by crouleau@chromium.org, Mar 14 2018

Comment 2 Deleted

Comment 3 by crouleau@chromium.org, Mar 14 2018

Comment 3 Deleted

Comment 4 by carlosk@chromium.org, Mar 14 2018

Comment 4 Deleted

Comment 5 by rogerta@chromium.org, Mar 15 2018

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Mar 16 2018

Comment 6 Deleted

Comment 7 by carlosk@chromium.org, Mar 16 2018

Comment 7 Deleted

Comment 8 by gab@chromium.org, Apr 10 2018

Comment 8 Deleted

Comment 9 by kgna...@chromium.org, Apr 10 2018

Comment 9 Deleted

Sign in to add a comment