New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822004 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit build-ahead] Build ahead fails when run manually.

Project Member Reported by robert...@chromium.org, Mar 14 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3de4acd326083d8e153b3c5988f49b72e3906c85

commit 3de4acd326083d8e153b3c5988f49b72e3906c85
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Mar 14 22:15:38 2018

[Findit] Fix typo on request to get tree status.

This typo is causing chromium-status to return the data in text mode
rather than json mode, thus causing a failure to parse the incoming
data.

R=chanli,stgao,lijeffrey,wylieb
BUG= 822004 

Change-Id: Ie632f4ff11138c118b015d8e716e434d288d74c9
Reviewed-on: https://chromium-review.googlesource.com/963497
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/3de4acd326083d8e153b3c5988f49b72e3906c85/appengine/findit/services/build_ahead.py

Summary: [Findit build-ahead] Build ahead fails when run manually. (was: [Findit build-ahead] ValueError: No JSON object could be decoded)
This bug will remain open until build ahead works when running manually.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b17e783d3aca593aaea40b19c2bc2e340d326ea1

commit b17e783d3aca593aaea40b19c2bc2e340d326ea1
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Apr 04 23:02:26 2018

[Findit] Build ahead: skip platforms with no supported builders.

Current list of platforms to support build ahead on is hardcoded and
it's exhaustive, but not all platforms have been migrated to luci yet,
so rather than comment out the platforms that are not there yet, simply
skip them if there are no supported builders for that platform.

R=chanli,stgao

Bug:  822004 
Change-Id: I84bed3498b5f8019aae07ab07f1e011764edc324
Reviewed-on: https://chromium-review.googlesource.com/993395
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/b17e783d3aca593aaea40b19c2bc2e340d326ea1/appengine/findit/services/build_ahead.py
[modify] https://crrev.com/b17e783d3aca593aaea40b19c2bc2e340d326ea1/appengine/findit/services/test/build_ahead_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e86e67b4f35cecbae7177da58b7eff725222f59e

commit e86e67b4f35cecbae7177da58b7eff725222f59e
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Apr 13 17:39:54 2018

[Findit] Add default value for new property of old WfTryBotCache rows.

This is causing build ahead to fail when running manually, because some
of these rows existed before the change that added the field
full_build_commit_positions.

R=chanli,stgao,wylieb,lijeffrey
BUG= 822004 

Change-Id: Ia5288c0950d106cb9b66fcd59a4ffd3c00c724c1
Reviewed-on: https://chromium-review.googlesource.com/1008999
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/e86e67b4f35cecbae7177da58b7eff725222f59e/appengine/findit/services/test/build_ahead_test.py
[modify] https://crrev.com/e86e67b4f35cecbae7177da58b7eff725222f59e/appengine/findit/model/wf_try_bot_cache.py

Status: Fixed (was: Started)

Sign in to add a comment