New issue
Advanced search Search tips

Issue 821999 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

WindowSelectorTest.OverviewWidgetStackingOrder in ash_unittests failing chromeos builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Mar 14 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@chromium.org

WindowSelectorTest.OverviewWidgetStackingOrder in ash_unittests failing on multiple builders

Builders failed on: 
- linux-chromeos-rel: 
  https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel


 
Cc: sky@chromium.org
Owner: sammiequon@chromium.org
Status: Assigned (was: Available)
Labels: -Sheriff-Chromium
See also  issue 822049 
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92d3c1671a7914c2f0e60326e47b8541d7c3f33e

commit 92d3c1671a7914c2f0e60326e47b8541d7c3f33e
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Mar 16 00:13:13 2018

overview: Fix stacking order for new UI.

New UI bypasses some animations when in tablet mode. Old UI relied on
animation ended to stack windows properly. After this patch lands, the
enable new overview UI patch should be able to reland safely.

Test: ash_unittests WindowSelectorTest.OverviewWidgetStackingOrder
Bug:  821999 ,  822049 
Change-Id: I4028b9c045b0bfc93207d2d0bc6343e634eb6c89
Reviewed-on: https://chromium-review.googlesource.com/963693
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543567}
[modify] https://crrev.com/92d3c1671a7914c2f0e60326e47b8541d7c3f33e/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/92d3c1671a7914c2f0e60326e47b8541d7c3f33e/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/92d3c1671a7914c2f0e60326e47b8541d7c3f33e/ash/wm/overview/window_selector_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment