This includes work in native_theme_*, probably breaking out common colors from native_theme_aura to make them used across the board when not overridden by OS themes.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad18bcbf9e66cdafd792f3cca4d4a494f358155

commit dad18bcbf9e66cdafd792f3cca4d4a494f358155
Author: Peter Boström <pbos@chromium.org>
Date: Fri Apr 06 01:58:07 2018

Updates towards using GoogleGrey700 for UI icons.

Changes the explicit Chrome icon color to use kGoogleGrey700. Some icon
colors are derived however, most of which are addressed.

Derives icon colors based on text color and tab background colors based
on deriving GoogleGrey700 from GoogleGrey900 for most icons as well as
GoogleGrey700 from GoogleGrey800 for active tabs.

Also pulls in a new batch of favicon icons to match the GG700 update.

There are still text/context colors that have not been audited to use
GoogleGrey900, but the changes are believed to not be so dramatic that
they cannot be pulled in piecemeal.

Bug: chromium:821996
Change-Id: Ic8638391146c1e43a7e2e75e19a46f4b8219913f
Reviewed-on: https://chromium-review.googlesource.com/965030
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548637}
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/common/favicon_bookmarks.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/common/favicon_conflicts.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/common/favicon_downloads.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/common/favicon_extensions.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/common/favicon_print_preview.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/common/favicon_settings.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/legacy/favicon_laptop.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/legacy/favicon_phone.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_100_percent/legacy/favicon_tablet.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/common/favicon_bookmarks.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/common/favicon_conflicts.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/common/favicon_downloads.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/common/favicon_extensions.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/common/favicon_print_preview.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/common/favicon_settings.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/legacy/favicon_laptop.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/legacy/favicon_phone.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/theme/default_200_percent/legacy/favicon_tablet.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/app/vector_icons/profile_switcher_outline.icon
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/browser/ui/views/profiles/avatar_button.cc
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_100_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_100_percent/favicon_history.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_100_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_200_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_200_percent/favicon_history.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_200_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_300_percent/crash/favicon_sad_tab.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_300_percent/favicon_history.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/default_300_percent/flags_ui/favicon_flags.png
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/components/resources/sadtab.svg
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/ui/gfx/color_palette.h
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/ui/gfx/color_utils.cc
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/ui/views/controls/button/image_button_factory.cc
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/ui/views/controls/button/image_button_factory.h
[modify] https://crrev.com/dad18bcbf9e66cdafd792f3cca4d4a494f358155/ui/views/controls/button/image_button_factory_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e129764fd97838dec3ea0b96022b3b1e5125a246

commit e129764fd97838dec3ea0b96022b3b1e5125a246
Author: Peter Boström <pbos@chromium.org>
Date: Fri Apr 13 03:45:43 2018

Use gfx::kGoogleGrey900 as Harmony primary color

Changes the color from 212121 to 202124. This also makes sure that the
site permission (page info) icons are rendered close to their correct
GG700 by default (they are derived from this text color).

Bug:  chromium:820531 , chromium:821996
Change-Id: Ic1c52198e5a8a3d958684bb1ddb61e0510311ec1
Reviewed-on: https://chromium-review.googlesource.com/1011548
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550505}
[modify] https://crrev.com/e129764fd97838dec3ea0b96022b3b1e5125a246/chrome/browser/ui/views/harmony/harmony_typography_provider.cc

Making sure bugs have specs attached

Deleted: Chrome 01.png 174 KB

	Chrome 01.png 174 KB View Download

Deleted: Chrome 02.png 157 KB

	Chrome 02.png 157 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e129764fd97838dec3ea0b96022b3b1e5125a246

commit e129764fd97838dec3ea0b96022b3b1e5125a246
Author: Peter Boström <pbos@chromium.org>
Date: Fri Apr 13 03:45:43 2018

Use gfx::kGoogleGrey900 as Harmony primary color

Changes the color from 212121 to 202124. This also makes sure that the
site permission (page info) icons are rendered close to their correct
GG700 by default (they are derived from this text color).

Bug:  chromium:820531 , chromium:821996
Change-Id: Ic1c52198e5a8a3d958684bb1ddb61e0510311ec1
Reviewed-on: https://chromium-review.googlesource.com/1011548
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550505}
[modify] https://crrev.com/e129764fd97838dec3ea0b96022b3b1e5125a246/chrome/browser/ui/views/harmony/harmony_typography_provider.cc

From go/chrome-ux-gm2
https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g3232c09376_6_798

Tearsheet: go/chrome-ux-gm2-core

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d6fee994cc84be26d06b03ce6a38bb4e665587

commit b5d6fee994cc84be26d06b03ce6a38bb4e665587
Author: Peter Boström <pbos@chromium.org>
Date: Tue May 08 02:09:45 2018

Use GG700 / Chrome icon color for toolbar

Replaces GG800 with GG700 as icon color in a couple of places:

* Omnibox default chip (HTTP (i) icon for instance).
* BubbleIconView inside omnibar (these used to be GG700 but regressed
  to GG800 in Touchable / Refresh recently).
* Toolbar button icons.

Bug: chromium:821996,  chromium:834510 
Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef
Reviewed-on: https://chromium-review.googlesource.com/1040875
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556646}
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/omnibox/omnibox_theme.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/find_bar_icon.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/find_bar_icon.h
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/intent_picker_view.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/intent_picker_view.h
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/star_view.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/star_view.h
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/zoom_view.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/zoom_view.h
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
[modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3

commit a6598e5db8a6aada00c8ffc6d8000ef8638e12b3
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue May 08 05:35:37 2018

Revert "Use GG700 / Chrome icon color for toolbar"

This reverts commit b5d6fee994cc84be26d06b03ce6a38bb4e665587.

Reason for revert: Speculative revert for mash_browser_tests failure on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7672

Original change's description:
> Use GG700 / Chrome icon color for toolbar
> 
> Replaces GG800 with GG700 as icon color in a couple of places:
> 
> * Omnibox default chip (HTTP (i) icon for instance).
> * BubbleIconView inside omnibar (these used to be GG700 but regressed
>   to GG800 in Touchable / Refresh recently).
> * Toolbar button icons.
> 
> Bug: chromium:821996,  chromium:834510 
> Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef
> Reviewed-on: https://chromium-review.googlesource.com/1040875
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556646}

TBR=pkasting@chromium.org,estade@chromium.org,pbos@chromium.org,bsep@chromium.org

Change-Id: I1d56fd212cbe1ed50b620b61b9287cfa8abc5b48
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:821996,  chromium:834510 ,  chromium:840657 
Reviewed-on: https://chromium-review.googlesource.com/1049445
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556700}
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/omnibox/omnibox_theme.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/find_bar_icon.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/find_bar_icon.h
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/intent_picker_view.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/intent_picker_view.h
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/star_view.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/star_view.h
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/zoom_view.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/zoom_view.h
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
[modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acb195073e0f1d65cd2df44f8e129104262ce53e

commit acb195073e0f1d65cd2df44f8e129104262ce53e
Author: Peter Boström <pbos@chromium.org>
Date: Wed May 09 01:57:39 2018

Reland "Use GG700 / Chrome icon color for toolbar"

This reverts commit a6598e5db8a6aada00c8ffc6d8000ef8638e12b3.

Reason for revert: Partial reland that doesn't remove caching of tint_.

Original change's description:
> Revert "Use GG700 / Chrome icon color for toolbar"
>
> This reverts commit b5d6fee994cc84be26d06b03ce6a38bb4e665587.
>
> Reason for revert: Speculative revert for mash_browser_tests failure on linux-chromeos-rel
> https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7672
>
> Original change's description:
> > Use GG700 / Chrome icon color for toolbar
> >
> > Replaces GG800 with GG700 as icon color in a couple of places:
> >
> > * Omnibox default chip (HTTP (i) icon for instance).
> > * BubbleIconView inside omnibar (these used to be GG700 but regressed
> >   to GG800 in Touchable / Refresh recently).
> > * Toolbar button icons.
> >
> > Bug: chromium:821996,  chromium:834510 
> > Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef
> > Reviewed-on: https://chromium-review.googlesource.com/1040875
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Reviewed-by: Evan Stade <estade@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#556646}
>
> TBR=pkasting@chromium.org,estade@chromium.org,pbos@chromium.org,bsep@chromium.org
>
> Change-Id: I1d56fd212cbe1ed50b620b61b9287cfa8abc5b48
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:821996,  chromium:834510 ,  chromium:840657 
> Reviewed-on: https://chromium-review.googlesource.com/1049445
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556700}

TBR=pkasting@chromium.org,estade@chromium.org,bsep@chromium.org

Change-Id: I280c016c9cf772ce5919c29ebee4dba8535e44e3
Bug: chromium:821996,  chromium:834510 ,  chromium:840657 
Reviewed-on: https://chromium-review.googlesource.com/1050486
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557060}
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/omnibox/omnibox_theme.cc
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/find_bar_icon.cc
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/find_bar_icon.h
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/intent_picker_view.cc
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/intent_picker_view.h
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/star_view.cc
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/star_view.h
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/zoom_view.cc
[modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/zoom_view.h

thomasanderson noticed that background tabs don't seem to be pulling the GTK theme color in Refresh and suggested I add him to the relevant bug so he could take a look.  This seems like maybe that bug, I dunno.

+malaykeshav The background tab color on Linux with --top-chrome-md=material-refresh has the wrong color.  Looks to be caused by this:
https://cs.chromium.org/chromium/src/chrome/browser/themes/theme_service.cc?rcl=306871de3e87f2d1844952ee730112e1fdabbae4&l=473

Is is_newer_material the right condition to be using?  It seems we want a condition relevant to touch UI.

Yep, correct condition for the newer style just that Touchable was added first (out-of-date comment). Touchable / Refresh / Touchable Refresh all uses pretty much the same style.

Thanks pbos@.  Know what we would change the condition to?  Linux doesn't set COLOR_BACKGROUND_TAB so relies on that code for the fallback background tab color.

Looks like Windows doesn't tint the background tab either (if you enable accent colors for title bars), so it's a cross-platform issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fcfc72c61f88a2dab963b45c336f6d535614dfc

commit 7fcfc72c61f88a2dab963b45c336f6d535614dfc
Author: Peter Boström <pbos@chromium.org>
Date: Thu May 31 22:21:47 2018

Unify toolbar-related ink-drop colors

* Makes bookmarks-bar buttons use the toolbar ink-drop base color.
* Use the previously-touch opacities for hovered and selected ink-drop
  states unconditionally for toolbar buttons, extension icons, bookmark
  buttons and the 3-dot menu.
* Renames kTouchToolbar constants to reflect that they're no longer
  touch-only constants. Also does corresponding comment cleanup.

Bug: chromium:821996,  chromium:822069 ,  chromium:846416 
Change-Id: Ia28642afb2dd7381bff59428405fa895559be8bd
Reviewed-on: https://chromium-review.googlesource.com/1080552
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563398}
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h

Inactive tab looks ugly in dark GTK+ theme in MD refresh (69.0.3452.0)

Deleted: chrome_gtk_bug.png 9.0 KB

	chrome_gtk_bug.png 9.0 KB View Download

UI elements are hard to distinguish in custom dark themes from store. MD refresh (69.0.3452.0)

Deleted: dark_themes_bug.png 4.5 KB

	dark_themes_bug.png 4.5 KB View Download

Moving meta bugs to PM to make eng bandwidth more clear.

pbos: Can you look at comments 17-19 and comment 28 and split those off to separate bugs as warranted?  See also  bug 853841  which seems related here.

@29: Can you file that as a separate bug, and post a comparison screenshot of pre-refresh, as well as the exact details on the theme?

#17-19 should be covered by crrev.com/c/1107108

#29 is in current Dev which seems to be before we started painting directly on the background frame. Windows Dev looks similar if I use an accent color (see screenshot of Dev + Canary). Re #29, please try again in the next Dev version and file a bug if it persists.

Deleted: dev-vs-canary.png 15.7 KB

	dev-vs-canary.png 15.7 KB View Download