New issue
Advanced search Search tips

Issue 821992 link

Starred by 2 users
Status: Verified
Owner:
tiborg@chromium.org
Closed: Apr 2018
Cc:
mthiesse@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Incognito NTP has an offset at the top when in VR

Project Member Reported by tiborg@chromium.org, Mar 14 2018 
Since we hide the browser controls in VR the incognito NTP has an offset at the top. Remove that offset while in VR.

Comment 1 by tiborg@chromium.org, Mar 14 2018

Owner: ----
Status: Available (was: Assigned)

Comment 2 by yfried...@chromium.org, Apr 6 2018

Labels: Hotlist-VRB-MVP

Comment 3 by tiborg@chromium.org, Apr 6 2018

Cc: mthiesse@chromium.org
Labels: -Pri-2 Pri-1
Owner: tiborg@chromium.org
Status: Assigned (was: Available)

Comment 4 by tiborg@chromium.org, Apr 6 2018

Labels: -Pri-1 Pri-2

Comment 5 by tiborg@chromium.org, Apr 9 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44bb079b6bac9f240aca1a295b5cd5b9e7725a43

commit 44bb079b6bac9f240aca1a295b5cd5b9e7725a43
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Apr 12 22:15:29 2018

Make incognito NTP a BasicNativePage

A result of this change is the removal of offset on incognito NTP
if browser controls are hidden.

Bug:  821992 
Change-Id: I1aa499bf01ec2b259d4d9bcd5b8fee1edd42a5b2
Reviewed-on: https://chromium-review.googlesource.com/1001499
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550386}
[modify] https://crrev.com/44bb079b6bac9f240aca1a295b5cd5b9e7725a43/chrome/android/java/res/layout/new_tab_page_incognito.xml
[modify] https://crrev.com/44bb079b6bac9f240aca1a295b5cd5b9e7725a43/chrome/android/java/res/layout/new_tab_page_incognito_md.xml
[modify] https://crrev.com/44bb079b6bac9f240aca1a295b5cd5b9e7725a43/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
[modify] https://crrev.com/44bb079b6bac9f240aca1a295b5cd5b9e7725a43/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

Comment 7 by tiborg@chromium.org, Apr 12 2018

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44bb079b6bac9f240aca1a295b5cd5b9e7725a43

commit 44bb079b6bac9f240aca1a295b5cd5b9e7725a43
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Apr 12 22:15:29 2018

Make incognito NTP a BasicNativePage

A result of this change is the removal of offset on incognito NTP
if browser controls are hidden.

Bug:  821992 
Change-Id: I1aa499bf01ec2b259d4d9bcd5b8fee1edd42a5b2
Reviewed-on: https://chromium-review.googlesource.com/1001499
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550386}
[modify] https://crrev.com/44bb079b6bac9f240aca1a295b5cd5b9e7725a43/chrome/android/java/res/layout/new_tab_page_incognito.xml
[modify] https://crrev.com/44bb079b6bac9f240aca1a295b5cd5b9e7725a43/chrome/android/java/res/layout/new_tab_page_incognito_md.xml
[modify] https://crrev.com/44bb079b6bac9f240aca1a295b5cd5b9e7725a43/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
[modify] https://crrev.com/44bb079b6bac9f240aca1a295b5cd5b9e7725a43/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

Comment 9 by dougman@chromium.org, May 8 2018

Labels: Test-Complete
Status: Verified (was: Fixed)
Fix Verified in build 67.0.3396.29 beta.  Looks good.
►

Sign in to add a comment