New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821986 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GetBuilderStatusFromCIDB is dead code.

Project Member Reported by dgarr...@chromium.org, Mar 14 2018

Issue description

builder_status.GetBuilderStatusFromCIDB is dead code and should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5978d7dd749e58fb74f8f253066c54898b34ebc2

commit 5978d7dd749e58fb74f8f253066c54898b34ebc2
Author: Don Garrett <dgarrett@google.com>
Date: Mon Mar 19 21:19:10 2018

builder_status_lib: Remove GetBuilderStatusFromCIDB.

nxia@ found that this function is unused. Remove it.

BUG= chromium:821986 
TEST=run_tests

Change-Id: I020c12b8ce25b00dd5725ef529e534e60fd31979
Reviewed-on: https://chromium-review.googlesource.com/963514
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/5978d7dd749e58fb74f8f253066c54898b34ebc2/lib/builder_status_lib.py
[modify] https://crrev.com/5978d7dd749e58fb74f8f253066c54898b34ebc2/lib/builder_status_lib_unittest.py

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb4fdab05c5a9dccbf93ee2f598d081316c54890

commit bb4fdab05c5a9dccbf93ee2f598d081316c54890
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Mar 20 00:15:24 2018

Roll src/third_party/chromite/ 8d50e94a5..5978d7dd7 (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8d50e94a5bc9..5978d7dd749e

$ git log 8d50e94a5..5978d7dd7 --date=short --no-merges --format='%ad %ae %s'
2018-03-14 dgarrett builder_status_lib: Remove GetBuilderStatusFromCIDB.
2018-03-13 haddowk [chromite] Make moblab-vm important again

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:821986 , chromium:819695 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ie1aad5cf3d65e808393afe189cd50940170a2762
Reviewed-on: https://chromium-review.googlesource.com/969603
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544225}
[modify] https://crrev.com/bb4fdab05c5a9dccbf93ee2f598d081316c54890/DEPS

Sign in to add a comment