with the Windows 10 custom titlebar, popup window titles are black even if the frame color is dark |
|||||
Issue descriptionSee attached screenshot. The popup title should be white. This will require some new plumbing in GlassBrowserFrameView so window_title_ can change when the frame color changes.
,
Mar 26 2018
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70208163c827b40fb0e6ddfb37682b49fe54e492 commit 70208163c827b40fb0e6ddfb37682b49fe54e492 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Mar 27 03:09:10 2018 Fix popup window title color always being black with custom titlebar. This patch changes the window title color when the titlebar is painted. This ensures that the proper contrasting color is picked for both active and inactive states. The color is also made partially transparent when the window is inactive. The end result is that the window title should always be the same color as the window caption button symbols (unless a theme uses a button background with the opposite luma of the titlebar). Bug: 821980 Change-Id: Ib84edf0b9d2bb9415cd293d3683915b9d64b40be Reviewed-on: https://chromium-review.googlesource.com/979035 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#545933} [modify] https://crrev.com/70208163c827b40fb0e6ddfb37682b49fe54e492/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/70208163c827b40fb0e6ddfb37682b49fe54e492/chrome/browser/ui/views/frame/glass_browser_frame_view.h [modify] https://crrev.com/70208163c827b40fb0e6ddfb37682b49fe54e492/chrome/browser/ui/views/frame/windows_10_caption_button.cc
,
Mar 27 2018
,
Mar 29 2018
Able to reproduce this issue on build without fix. Hence verifying the fix on latest canary 67.0.3383.0 using windows 10. Observing faded font color when popup dialog is not active. Attaching screenshots for reference. As fix is working as expected, adding Verified labels. Thanks!
,
Mar 29 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bsep@chromium.org
, Mar 15 2018