New issue
Advanced search Search tips

Issue 821957 link

Starred by 1 user
Status: Archived
Owner:
ejcaruso@chromium.org
Closed: Jan 4
Cc:
derat@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Clean up extraneous D-Bus object managers

Project Member Reported by ejcaruso@chromium.org, Mar 14 2018 
Some D-Bus daemons use object managers because they were using code from early users of chromeos-dbus-bindings as a base. However, many of these object managers are functionally useless. Remove them to simplify things a bit and so it will be less confusing when we move to a different IPC system.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0c09bbdf15995409067f9a071887f437834507ea

commit 0c09bbdf15995409067f9a071887f437834507ea
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Mon Mar 19 21:19:04 2018

chaps: remove object manager

chaps has an object manager but nobody uses it and chaps does not
do any dynamic adding or removing of interfaces or objects, so we
can safely remove it.

BUG= chromium:821957 
TEST=unit tests, deploy to device, invoke via p11_replay

Change-Id: Ida4226d796ac6e301d5d51570f43b1eabcb91090
Reviewed-on: https://chromium-review.googlesource.com/963404
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/0c09bbdf15995409067f9a071887f437834507ea/chaps/dbus_bindings/constants.h
[modify] https://crrev.com/0c09bbdf15995409067f9a071887f437834507ea/chaps/chaps_adaptor.cc
[modify] https://crrev.com/0c09bbdf15995409067f9a071887f437834507ea/chaps/chaps_adaptor.h
[modify] https://crrev.com/0c09bbdf15995409067f9a071887f437834507ea/chaps/chapsd.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2c11cfb9b941abe0d0121664f1905655ed8142e1

commit 2c11cfb9b941abe0d0121664f1905655ed8142e1
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Thu Apr 12 22:22:13 2018

webserver: prefer NameOwnerChanged over ObjectManager

ObjectManager just makes things more complicated, and this is
the only use of a generated object manager proxy for
permission_broker, so we can remove it after getting rid of this
use.

BUG= chromium:821957 
TEST=unit tests, deploy, restart permission_broker and ensure
  that webservd reconfigures tcp ports

Change-Id: Ie89a6f03fc68a7b51b914d80e870e0fb2df83e1c
Reviewed-on: https://chromium-review.googlesource.com/1008833
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/2c11cfb9b941abe0d0121664f1905655ed8142e1/webserver/webservd/permission_broker_firewall.h
[modify] https://crrev.com/2c11cfb9b941abe0d0121664f1905655ed8142e1/webserver/webservd/permission_broker_firewall.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/02e54c7e66e8acf5920a6fa4a87d9d244ee45617

commit 02e54c7e66e8acf5920a6fa4a87d9d244ee45617
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Thu Apr 12 22:22:14 2018

permission_broker: remove unused ObjectManager

permission_broker has an object manager, presumably since the code
was taken from a chromeos-dbus-bindings user that had an object
manager. However, nobody references it, and permission_broker does
not dynamically add or remove interfaces or objects, so setting it
up is useless.

BUG= chromium:821957 
TEST=unit tests, deploy to device, call D-Bus methods via dbus-send

Change-Id: I85c4719b9ac08f6ab98909c5ab9aac6a1e7f94e4
Reviewed-on: https://chromium-review.googlesource.com/962836
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/02e54c7e66e8acf5920a6fa4a87d9d244ee45617/permission_broker/permission_broker_main.cc
[modify] https://crrev.com/02e54c7e66e8acf5920a6fa4a87d9d244ee45617/permission_broker/dbus_bindings/dbus-service-config.json
[modify] https://crrev.com/02e54c7e66e8acf5920a6fa4a87d9d244ee45617/permission_broker/dbus/org.chromium.PermissionBroker.conf
[modify] https://crrev.com/02e54c7e66e8acf5920a6fa4a87d9d244ee45617/permission_broker/permission_broker.h
[modify] https://crrev.com/02e54c7e66e8acf5920a6fa4a87d9d244ee45617/permission_broker/permission_broker.cc

Comment 4 by apronin@chromium.org, Oct 12

Components: OS>Systems>Security

Comment 5 by louiscollard@chromium.org, Dec 10 

Is this still active?

Comment 6 by louiscollard@chromium.org, Jan 4

Status: Archived (was: Started)
►

Sign in to add a comment