[CRD iOS] Help page link not working |
||||||||
Issue descriptionApp Version: 67.0.3371.0 OS Version: 11.2.6 What steps will reproduce the problem? (1) Tap the hamburger menu button (2) Tap `help` (3) Tap a link on the help page What is the expected result? The link is opened What happens instead? Nothing happens
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b69eacc0d62de928264252c29daa3883fb386ca commit 7b69eacc0d62de928264252c29daa3883fb386ca Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Mar 15 00:02:02 2018 [CRD iOS] Allow WebViewController to open webpage with target="_blank" Previously tapping a link on the help page has no effect because the links have target="_blank" attribute and we haven't properly set up the WebViewController to handle that. This CL makes the app open a target="_blank" link using the default browser, aka Safari. Bug: 821955 Change-Id: I1557a37d9b1a341186ee1b59fec1de77f075da1a Reviewed-on: https://chromium-review.googlesource.com/963690 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#543245} [modify] https://crrev.com/7b69eacc0d62de928264252c29daa3883fb386ca/remoting/ios/app/web_view_controller.mm
,
Mar 15 2018
This change only affects Chrome Remote Desktop for iOS app and doesn't affect the Chrome browser. This is a small change to allow links on the app's help page to work properly. Without this fix, some important help links like "Privacy Notice and Google Privacy Policy" will not work.
,
Mar 15 2018
Has this been verified in Canary?
,
Mar 15 2018
The change doesn't affect Chrome browser, so there's no Canary.
,
Mar 15 2018
I did verify that it works on Chrome Remote Desktop daily dogfood build @67.0.3371.0 though.
,
Mar 15 2018
This bug requires manual review: Less than 29 days to go before AppStore submit on M66 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 16 2018
Ping?
,
Mar 19 2018
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90be023172900f4af6849e9fd781e334daca13ea commit 90be023172900f4af6849e9fd781e334daca13ea Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Mar 19 18:27:29 2018 [CRD iOS] Allow WebViewController to open webpage with target="_blank" Previously tapping a link on the help page has no effect because the links have target="_blank" attribute and we haven't properly set up the WebViewController to handle that. This CL makes the app open a target="_blank" link using the default browser, aka Safari. Bug: 821955 Change-Id: I1557a37d9b1a341186ee1b59fec1de77f075da1a Reviewed-on: https://chromium-review.googlesource.com/963690 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543245}(cherry picked from commit 7b69eacc0d62de928264252c29daa3883fb386ca) Reviewed-on: https://chromium-review.googlesource.com/969282 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#314} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/90be023172900f4af6849e9fd781e334daca13ea/remoting/ios/app/web_view_controller.mm
,
Mar 22 2018
,
Jul 19
Verifed Fixed in 67.3396.22 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yuweih@chromium.org
, Mar 14 2018