New issue
Advanced search Search tips

Issue 821954 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 735518



Sign in to add a comment

Device Pixel Ratio client hint is not included on the main frame requests

Project Member Reported by tbansal@chromium.org, Mar 14 2018

Issue description

Currently, only device-memory client hint is included on the main frame requests. We need a mechanism to compute device pixel ratio in the browser, and include it as a request header.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b30b7532ac821911fdffeff467cbd139f5b5226d

commit b30b7532ac821911fdffeff467cbd139f5b5226d
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Mar 14 21:50:38 2018

Send DPR client hint on main frame requests

Compute DPR in the browser process and include it as a
client hint (if the origin requested it) on main
frame requests.

Bug:  821954 
Change-Id: I73a2017d426cb6d9403d41bc89e3107da44034b2
Reviewed-on: https://chromium-review.googlesource.com/963315
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543209}
[modify] https://crrev.com/b30b7532ac821911fdffeff467cbd139f5b5226d/chrome/browser/client_hints/client_hints.cc
[modify] https://crrev.com/b30b7532ac821911fdffeff467cbd139f5b5226d/chrome/browser/client_hints/client_hints_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment