Permission.query for "clipboard-read" fails |
|||||||||
Issue descriptionIt returns the following error: "Failed to read the 'query' property from 'Permissions': Async Clipboard flag is not enabled." The permission code checks the AsyncClipboardAPI feature flag and fails if it is not set. Currently this flag is only set for "experimental" so release channels will not be able to query this permissions. This feature check should be removed since it is now being used to enable/disable the unshipped portions of the Async Clipboard API.
,
Mar 14 2018
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b94978cfefdfbd0eb5f2cc6b6ef667da52763240 commit b94978cfefdfbd0eb5f2cc6b6ef667da52763240 Author: Gary Kacmarcik <garykac@chromium.org> Date: Thu Mar 15 21:34:55 2018 Remove flag check for clipboard-read/write permission.query The AsyncClipboardAPI feature flag used to control access to the entire async clipboard API, but (since we're now shipping the text portions of the API) its meaning has been changed to control access only to the parts of the API that are still under development (e.g., image and delayed generation support). The Clipboard permission is shipping as part of the text APIs, so it should no longer be checking this feature flag. Bug: 677564 , 821947 Change-Id: Ia57b57df3eae03c2d4372cf5e7472ef1d0532f49 Reviewed-on: https://chromium-review.googlesource.com/963287 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#543504} [modify] https://crrev.com/b94978cfefdfbd0eb5f2cc6b6ef667da52763240/third_party/WebKit/Source/modules/permissions/Permissions.cpp
,
Mar 15 2018
,
Mar 15 2018
,
Mar 15 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 16 2018
Able to reproduce the issue on win-10, mac 10.13.3 and ubuntu 14.04 using chrome version #67.0.3371.0. Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 14.04 using Chrome version #67.0.3372.0 as per the comment #0 and #1. Attaching screen shot for reference. Observed that permission.query for "clipboard-read" pass. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Mar 19 2018
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/110e2347eff57cf1c97b18663e75ad37f2c96a3f commit 110e2347eff57cf1c97b18663e75ad37f2c96a3f Author: Gary Kacmarcik <garykac@chromium.org> Date: Mon Mar 19 17:50:31 2018 Remove flag check for clipboard-read/write permission.query The AsyncClipboardAPI feature flag used to control access to the entire async clipboard API, but (since we're now shipping the text portions of the API) its meaning has been changed to control access only to the parts of the API that are still under development (e.g., image and delayed generation support). The Clipboard permission is shipping as part of the text APIs, so it should no longer be checking this feature flag. Bug: 677564 , 821947 Change-Id: Ia57b57df3eae03c2d4372cf5e7472ef1d0532f49 Reviewed-on: https://chromium-review.googlesource.com/963287 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543504}(cherry picked from commit b94978cfefdfbd0eb5f2cc6b6ef667da52763240) Reviewed-on: https://chromium-review.googlesource.com/969281 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#312} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/110e2347eff57cf1c97b18663e75ad37f2c96a3f/third_party/WebKit/Source/modules/permissions/Permissions.cpp
,
Mar 21 2018
Able to reproduce the issue on win-10, mac 10.13.3 and ubuntu 14.04 using chrome version #67.0.3371.0. Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 14.04 using Chrome version #66.0.3359.45 as per the comment #0 and #1. Attaching screen shot for reference. Observed that permission.query for "clipboard-read" pass. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jasonjmi...@google.com
, Mar 14 201852.6 KB
52.6 KB View Download