New issue
Advanced search Search tips

Issue 821946 link

Starred by 2 users
Status: Verified
Owner:
cjgrant@chromium.org
Cc:
cjgrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR

Blocking:
issue 768564
issue 808716
issue 808722



Sign in to add a comment

URL bar should support highlighting on URL, security icon, etc.

Project Member Reported by cjgrant@chromium.org, Mar 14 2018 
In order to highlight the clickable nature of the URL and security icon, the UX spec has been updated to have these highlight on hover.

Summary of changes:
- Color URL bar background when hovered
- Color security icon when hovered
- 200 ms transition on back button and mic button hover colors
- Invert colors according to latest UX spec
- Confirm whether we can remove the "Offline" text that appears on the URL bar while in offline mode.

Comment 1 by ericde@google.com, Mar 14 2018

Blocking: 808722
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/217663e0bae441071be836c179a4c648aef2572c

commit 217663e0bae441071be836c179a4c648aef2572c
Author: Christopher Grant <cjgrant@chromium.org>
Date: Fri Mar 23 17:29:14 2018

VR: Split apart the URL bar origin

This change refactors the URL bar into a set of buttons, layouts, and a
much smaller dedicated element to present the URL text.  In the future,
the URL text should be made into a Text subclass, or similar, to take
advantage of text layout.

This change also refactors and fixes some pieces of the vector icon
button class.

BUG= 821946 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I186e6c32dbf8c61ddba7a5f9fe01c584067bd43e
Reviewed-on: https://chromium-review.googlesource.com/976685
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545505}
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/button.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/button.h
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/disc_button_unittest.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/url_bar.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/url_bar.h
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/url_bar_texture.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/url_bar_texture.h
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/vector_icon_button.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/elements/vector_icon_button.h
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/217663e0bae441071be836c179a4c648aef2572c/chrome/browser/vr/ui_unittest.cc

Comment 3 by ericde@google.com, Mar 23 2018

Status: Started (was: Assigned)

Comment 4 by ericde@google.com, Mar 23 2018

Blocking: 808716

Comment 5 by cjgrant@chromium.org, Mar 25 2018 

This bug is technically complete, but I have a sizeable follow-up CL almost ready that refactors and cleans up a bunch of stuff (including colors) so that it's much easier to meet UX spec.  That should land on Monday.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f4547190059130eb6ceb6b5ff9b5c5740891a20

commit 9f4547190059130eb6ceb6b5ff9b5c5740891a20
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Mar 27 03:22:22 2018

VR: Omnibox color and layout refactoring.

This change restructures URL bar and omnibox code in several ways:

- Change all buttons to have transparent backgrounds, such that the
  UX-specified hover colors look correct.
- Enable background color animation on ALL buttons.
- Simplify the omnibox into a layout of transparent-background elements,
  with a single backblane (one element with rounded corners, background
  color and shadow).
- Make better use of layouts to remove instances of anchoring.
- Introduce helper functions to translate UX spec colors to constants.

BUG= 821946 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0dd6c9064cdec520ba45f0ad62aedf8fb4ad1364
Reviewed-on: https://chromium-review.googlesource.com/981050
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545957}
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/button.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/omnibox_formatting.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/omnibox_formatting_unittest.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/url_bar.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/url_bar.h
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/url_bar_texture.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/url_bar_texture.h
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/9f4547190059130eb6ceb6b5ff9b5c5740891a20/chrome/browser/vr/ui_unittest.cc

Comment 7 by cjgrant@chromium.org, Mar 27 2018

Status: Fixed (was: Started)

Comment 8 by cjgrant@chromium.org, Mar 27 2018

Cc: cjgrant@chromium.org
 Issue 799174  has been merged into this issue.

Comment 9 by sko...@chromium.org, Mar 30 2018

Blocking: 768564

Comment 10 by dougman@chromium.org, Mar 30 2018

Labels: Test-Complete
Status: Verified (was: Fixed)
Verified changes on 67.0.3384.0 canary build.  Verified both Normal and Incognito mode.  Both look good.

Added testcase "UI Elements Hover Indicators" to the "VR Browsing: 2D UI handling Test Plan".  It covers both color changes and button pop outs as appropriate.
►

Sign in to add a comment