New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821945 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Set up tricium for experimental analyzer development in fuchsia

Project Member Reported by qyears...@chromium.org, Mar 14 2018

Issue description

This will involve:
 - Setting up the service config: Adding the relevant fuchsia projects (repos). This will include repo location and gerrit project name.
 - Setting up each project config: Adding a project config for fuchsia. This will include "selections" of existant analyzers (e.g. spacey). This will also containspecifications of any experimental analyzers later on.
 - First turn it on without gerrit reporting. Then I should check to see if there are any logged errors.

This bug is just tracking the task to make sure everything is hooked up properly.


 
Cc: phosek@chromium.org
Cc: -juliehocket@google.com juliehockett@google.com
Discussion in https://groups.google.com/a/google.com/forum/#!topic/luci-eng/zMZ3e8fnrUw:

phosek@:
> In Chromium, the luci-config configuration usually lives on the infra/config branch in the repository registered as project in luci-config.

> In Fuchsia, we consolidated all the configuration into a single repository https://fuchsia.googlesource.com/infra/config/ which is registered in luci-config as "fuchsia" project. This works for everything except CQ which assumes one repository per project, so we came up with a hack where we still keep all the configuration in the same repository but we point to a subdirectory that's which contains the repository specific configuration...

> Is it too late to change Tricium configuration to support configuring multiple repositories in the same config? Ideally, we would like to have only one tricium.cfg file in https://fuchsia.googlesource.com/infra/config/+/master/services/ rather than having one per repository.


Tricium uses the luci-config project name to get the project details and project config; each project details entry includes a git repo (required to check out files) and gerrit project (required to poll and report to gerrit).

In order to have one project config with multiple git repos and gerrit projects, project details should be referenced by something other than luci-config project name, e.g. git repo (or something else).
So, currently, there are multiple luci-config projects, one per repo, so it's OK to go ahead with this for me.

This CL would enable polling and running analyzers but would keep reporting to Gerrit disabled.

The change to the service config is at:
https://chrome-internal-review.googlesource.com/c/infradata/config/+/588614

This won't do anything until project configs are added (in https://fuchsia.googlesource.com/infra/config/+/master/repositories) which add analyzer selections for already-defined analyzers (like https://chromium.googlesource.com/infra/luci/luci-py/+/infra/config/tricium-prod.cfg) or analyzer definitions.

So, that's the next step. After adding project configs and confirming that it seems OK, then we'll add Gerrit plugin config(s) and enable reporting.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/a0eebeaf10142c5961f5115caf10e385069219c0

commit a0eebeaf10142c5961f5115caf10e385069219c0
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Mar 19 21:58:27 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b79233012b822d614a4a9b53697679276cf022f4

commit b79233012b822d614a4a9b53697679276cf022f4
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Mar 23 18:07:53 2018

Status: Fixed (was: Started)
Technically everything is now hooked up and we confirmed that Spacey works.

We're now experimenting with the first new analyzer after Spacey which Julie added, which isn't yet running:  bug 832920 .

Sign in to add a comment