New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 821926 link

Starred by 1 user
Status: Fixed
Owner:
█ elkurin@google.com
Last visit > 30 days ago
Closed: Aug 27
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
sarakato@chromium.org
yawano@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Chromevox only counts menuitem role, ignoring menuitemcheckbox and menuitemradio

Project Member Reported by joguntebi@google.com, Mar 14 2018 
Chrome Version: 64.0.3282.190 (Official Build) (64-bit)
OS: Chrome OS 10176.76.0 (Official Build) stable-channel eve

What steps will reproduce the problem?
(1) Enable Chromevox (Ctrl-Alt-Z)
(2) Have a parent element with role="menu"
(3) Have some child elements. Some with role="menuitem", some with role="menuitemcheckbox", some with role="menuitemradio".
(4) Open the menu

What is the expected result?
(5) Chromevox announces "Menu with # items". # is the total number of elements with any menuitem.* role.

What happens instead?
(5) Chromevox announces "Menu with # items". # is the number of elements with role="menuitem". The other menu item types are not counted.

Please use labels and text to provide additional information.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques lists valid Aria roles.

One might say that if you have a mix of different menu item roles, it's not clear what Chromevox should announce. The bug is the same if all the child elements are menuitemcheckbox or all of them are menuitemradio. The announcement is "Menu with 0 items".

Comment 1 by dtapu...@chromium.org, May 29 2018

Components: UI>Accessibility>ChromeVox

Comment 2 by yawano@chromium.org, Jul 31

Cc: lpalmaro@chromium.org dtseng@chromium.org yawano@chromium.org
Labels: cvox-starter-bug OS-Chrome
I think at least we can fix for the all menuitemradio and menuitemcheckbox case. countChildren for menu role in output.js only counts menuitem for now.

Comment 3 by yawano@chromium.org, Aug 1

Owner: elkurin@google.com
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 1

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "elkurin@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by yawano@chromium.org, Aug 2

Owner: elkurin@google.com
Status: Assigned (was: Untriaged)
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 2

Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "elkurin@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by yawano@chromium.org, Aug 6

Owner: elkurin@google.com
Status: Assigned (was: Untriaged)

Comment 8 by yawano@chromium.org, Aug 6 

One more try...
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 6

Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "elkurin@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by yawano@chromium.org, Aug 7

Owner: elkurin@google.com
Status: Assigned (was: Untriaged)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b5a44ba444346ed22a378fee557112fcec50027

commit 1b5a44ba444346ed22a378fee557112fcec50027
Author: Eriko Kurimoto <elkurin@google.com>
Date: Fri Aug 10 07:27:40 2018

When menu is focused, menuItemCheckBox and menuItemRadio are counted.

Bug:  821926 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie1a0d74985a7fb689ff0d47ba9404fd15803f0f8
Reviewed-on: https://chromium-review.googlesource.com/1158315
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#582084}
[modify] https://crrev.com/1b5a44ba444346ed22a378fee557112fcec50027/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/1b5a44ba444346ed22a378fee557112fcec50027/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7946b2318dae824d76c8ccfde42cc0ff36ed8853

commit 7946b2318dae824d76c8ccfde42cc0ff36ed8853
Author: Eriko Kurimoto <elkurin@google.com>
Date: Fri Aug 17 04:27:15 2018

When menuItem is focused, menuItemCheckBox and menuItemRadio are counted.

Reference
https://chromium-review.googlesource.com/c/chromium/src/+/1158315

Bug:  821926 
Change-Id: Iaf50ca97a9cceed98a915971b816ca7bdbcd515a
Reviewed-on: https://chromium-review.googlesource.com/1172307
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583960}
[modify] https://crrev.com/7946b2318dae824d76c8ccfde42cc0ff36ed8853/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/7946b2318dae824d76c8ccfde42cc0ff36ed8853/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

Comment 13 by yawano@chromium.org, Aug 24

Cc: sarakato@chromium.org

Comment 14 by elkurin@google.com, Aug 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment