Issue metadata
Sign in to add a comment
|
25kb regression in resource_sizes (MonochromePublic.apk) at 543067:543067 |
||||||||||||||||||||
Issue descriptionCaused by “Adding task queue congestion control experiment.” Commit: 19bea5135f0012774abf8d83e64ea5ade39e3c58 Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=543067 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase Based on the graph: 25kb of native code. It's not clear to me whether or not this increase was expected. Please have a look and either: Close as “Won't Fix” with a short justification, or Land a revert / fix-up.
,
Mar 14 2018
Assigning to webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com because this is the only CL in range: Roll src/third_party/webrtc/ e63afff36..31a12c557 (15 commits) https://webrtc.googlesource.com/src.git/+log/e63afff36496..31a12c557dcd $ git log e63afff36..31a12c557 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8c0d39963bc29a0d4aabf6774b5747bcd6ce6f15 Reviewed-on: https://chromium-review.googlesource.com/962341 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543067}
,
Mar 14 2018
465 symbols added (+), 8 changed (~), 1 removed (-), 852172 unchanged (not shown)
Of changed symbols, 469 grew, 2 shrank
Number of unique symbols 501019 -> 501244 (+225)
15 paths added, 0 removed, 2 changed
Showing 474 symbols (732 -> 1,129 unique) with total pss: 22175 bytes
Histogram of symbols based on PSS:
(-64,-32]: 1 (0,1): 85 [4,8): 49 [32,64): 64 [256,512): 13
(-4,-2]: 1 [1,2): 9 [8,16): 42 [64,128): 63 [512,1024): 3
{{0}}: 3 [2,4): 22 [16,32): 88 [128,256): 28 [1024,2048): 3
.text=20.1kb .rodata=912 bytes .data.rel.ro=672 bytes .data=0 bytes .bss=48 bytes .pak.translations=0 bytes .pak.nontranslated=0 bytes .other=-1 bytes total=21.7kb
Number of unique paths: 22
Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss, p=.pak.translations, P=.pak.nontranslated, o=.other
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
+ 0) 1300 (4.9%) t@0x17804cc 1300 (0->1300) third_party/webrtc/modules/congestion_controller/goog_cc/probe_bitrate_estimator.cc
webrtc::webrtc_cc::ProbeBitrateEstimator::HandleProbeAndEstimateBitrate
~ 1) 2392 (9.1%) t@Group 1092 (358244->359336) {{no path}}
** lld merge strings (count=2)
+ 2) 3420 (13.0%) t@0x23e3090 1028 (0->1028) third_party/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc
webrtc::webrtc_cc::GoogCcNetworkController::OnTransportPacketsFeedback
+ 3) 4186 (15.9%) t@0x23e1fe0 766 (0->764) third_party/webrtc/modules/congestion_controller/rtp/transport_feedback_adapter.cc
webrtc::webrtc_cc::TransportFeedbackAdapter::GetPacketFeedbackVector
+ 4) 4744 (18.0%) t@0x23e25f0 558 (0->556) third_party/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc
webrtc::webrtc_cc::GoogCcNetworkController::GoogCcNetworkController
+ 5) 5298 (20.2%) t@0x23e1498 554 (0->552) third_party/webrtc/modules/congestion_controller/rtp/send_side_congestion_controller.cc
webrtc::webrtc_cc::SendSideCongestionController::OnTransportFeedback
+ 6) 5782 (22.0%) t@0x23e3b00 484 (0->480) third_party/webrtc/modules/congestion_controller/goog_cc/probe_controller.cc
webrtc::webrtc_cc::ProbeController::SetEstimatedBitrate
+ 7) 6224 (23.7%) t@0x23deeec 442 (0->442) third_party/webrtc/modules/congestion_controller/rtp/send_side_congestion_controller.cc
std::__ndk1::__sort<> (num_aliases=2)
+ 8) 6662 (25.3%) t@0x23e2a14 438 (0->436) third_party/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc
webrtc::webrtc_cc::GoogCcNetworkController::OnNetworkRouteChange
+ 9) 7068 (26.9%) t@0x23e3cf8 406 (0->400) third_party/webrtc/modules/congestion_controller/goog_cc/probe_controller.cc
webrtc::webrtc_cc::ProbeController::RequestProbe
+ 10) 7468 (28.4%) t@0x177fd18 400 (0->400) third_party/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc
webrtc::webrtc_cc::DelayBasedBwe::DelayBasedBwe
+ 11) 7858 (29.9%) t@0x23e37a0 390 (0->384) third_party/webrtc/modules/congestion_controller/goog_cc/probe_controller.cc
webrtc::webrtc_cc::ProbeController::SetBitrates
+ 12) 8246 (31.4%) t@0x23e0838 388 (0->384) third_party/webrtc/modules/congestion_controller/rtp/send_side_congestion_controller.cc
webrtc::webrtc_cc::send_side_cc_internal::ControlHandler::OnNetworkInvalidation
+ 13) 8618 (32.8%) t@0x1780230 372 (0->372) third_party/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc
webrtc::webrtc_cc::DelayBasedBwe::MaybeUpdateEstimate
+ 14) 8988 (34.2%) t@0x177fef4 370 (0->368) third_party/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc
webrtc::webrtc_cc::DelayBasedBwe::IncomingPacketFeedbackVector
+ 15) 9340 (35.5%) t@0x1780068 352 (0->348) third_party/webrtc/modules/congestion_controller/goog_cc/delay_based_bwe.cc
webrtc::webrtc_cc::DelayBasedBwe::IncomingPacketFeedback
+ 16) 9668 (36.8%) t@0x23e232c 328 (0->328) third_party/webrtc/modules/congestion_controller/goog_cc/alr_detector.cc
webrtc::webrtc_cc::AlrDetector::AlrDetector
+ 17) 9978 (38.0%) t@0x23e2858 310 (0->308) third_party/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc
webrtc::webrtc_cc::GoogCcNetworkController::UpdateBitrateConstraints
+ 18) 10258 (39.0%) t@0x23e0ac4 280 (0->280) third_party/webrtc/modules/congestion_controller/rtp/send_side_congestion_controller.cc
webrtc::webrtc_cc::SendSideCongestionController::SendSideCongestionController
+ 19) 10498 (39.9%) t@0x23e397c 240 (0->240) third_party/webrtc/modules/congestion_controller/goog_cc/probe_controller.cc
webrtc::webrtc_cc::ProbeController::InitiateProbing
+ 20) 10734 (40.8%) t@0x23e3e88 236 (0->236) third_party/webrtc/modules/congestion_controller/goog_cc/probe_controller.cc
webrtc::webrtc_cc::ProbeController::Process
+ 21) 10964 (41.7%) t@0x23e2c38 230 (0->228) third_party/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc
webrtc::webrtc_cc::GoogCcNetworkController::MaybeTriggerOnNetworkChanged
+ 22) 11194 (42.6%) t@0x23e0cf4 230 (0->230) third_party/webrtc/modules/congestion_controller/rtp/send_side_congestion_controller.cc
webrtc::webrtc_cc::SendSideCongestionController::MaybeCreateControllers
+ 23) 11416 (43.4%) t@0x23e2e6e 222 (0->222) third_party/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc
webrtc::webrtc_cc::GoogCcNetworkController::OnStreamsConfig
+ 24) 11636 (44.3%) t@0x23e2f4c 220 (0->220) third_party/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc
webrtc::webrtc_cc::GoogCcNetworkController::UpdatePacingRates
+ 25) 11850 (45.1%) t@Group 214 (0->214) third_party/webrtc/modules/congestion_controller/rtp/send_side_congestion_controller.cc
webrtc::webrtc_cc::SendSideCongestionController::~SendSideCongestionController (count=2)
+ 26) 12054 (45.8%) t@0x23e2474 204 (0->204) third_party/webrtc/modules/congestion_controller/goog_cc/alr_detector.cc
webrtc::webrtc_cc::AlrDetector::OnBytesSent
+ 27) 12258 (46.6%) t@0x23e1846 204 (0->204) third_party/webrtc/modules/congestion_controller/rtp/send_side_congestion_controller.cc
webrtc::webrtc_cc::SendSideCongestionController::OnReceivedRtcpReceiverReportBlocks
I 1209529 Creating: Resource Sizes Diff
******************************Resource Sizes Diff******************************
MonochromePublic.apk_Breakdown (+25,263 bytes)
+25,264 bytes Native code size
-1 bytes Package metadata size
MonochromePublic.apk_Specifics
+25,263 bytes normalized apk size
+25,264 bytes main lib size
,
Mar 15 2018
Since we are adding a parallel implementation of the send side congestion controller running on a task queue as an experiment this seems reasonable. this is just until we have validated that the new version doesn't have any issues. Some of the size could potentially be reduced if it's a priority to do this before the expected time frame of the roll out (a few weeks). Marking as won't fix under the assumption that this isn't a big issue as it's temporary. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 14 2018