New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821900 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.3% regression in rasterize_and_record_micro.top_25 at 541993:542031

Project Member Reported by hjd@google.com, Mar 14 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 14 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=821900

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a6d4fae0b14a0207564b4487001dcde0f934ee2371c45fa6893ee09c9c5641a8


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 15 2018

Cc: dgozman@chromium.org bokan@chromium.org pdr@chromium.org skobes@chromium.org enne@chromium.org
Owner: bokan@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1184eeee440000

Prevent scroll contents being smaller than clip by bokan@chromium.org
https://chromium.googlesource.com/chromium/src/+/cead2e78a8e7e9acba07fd4f3d6ab2c9b3713e18

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by bokan@chromium.org, Mar 16 2018

Status: Started (was: Assigned)

Comment 5 by bokan@chromium.org, Mar 16 2018

Cc: vmp...@chromium.org
Components: Blink>Scroll
I looked into this a bit - I think it's expected since we've made the scrolling contents layer taller. In the gmail story, for example, the scrolling contents layer previously had about 400px less in height than the clipping layer. Mine and skobes@' patches make them equal which is necessary for correct pinch/scroll functioning in CC (the scrolling contents layer is now the outer viewport) and painting of content. e.g., if I add a bottom-fixed, uncomposited element to the gmail page, we would previously (reverting mine and skobes' patches) clip it out erroneously so the fix improves correctness.

+vmpstr@ as owner of the benchmark: taking the gmail case as an example, it doesn't look like we actually have to rasterize any page content in that newly region at the bottom of the page, it's all empty. Is a small bump here expected? I'm guessing we need to do more work at raster to clear these extra pixels?

Comment 6 by enne@chromium.org, Mar 20 2018

I think a larger visible region means more rasterization time because more content is being rasterized.  I think this should just be considered a new baseline and WontFix.

Comment 7 by bokan@chromium.org, Mar 20 2018

Status: WontFix (was: Started)
Ok, thanks!

Comment 8 by bokan@chromium.org, Mar 29 2018

Cc: chrishtr@chromium.org briander...@chromium.org
 Issue 813995  has been merged into this issue.

Comment 9 by bokan@chromium.org, Apr 3 2018

Cc: lukasza@chromium.org khushals...@chromium.org nick@chromium.org jam@chromium.org ericrk@chromium.org
 Issue 821396  has been merged into this issue.

Sign in to add a comment