New issue
Advanced search Search tips

Issue 821881 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Chromium-Packagers


Sign in to add a comment

Stretched background images in Minimize/Maximize/Close title buttons with OSX-Arc-White GTK theme

Reported by evange...@foutrelis.com, Mar 14 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36

Steps to reproduce the problem:
Observe that the title buttons have a background that is stretched to fill the whole .titlebutton area instead of being centered and retaining their original size.

The desktop environment is Xfce (but also reported to happen on Cinnamon and GNOME). The issue is visible when using the OSX-Arc-White GTK theme. GTK version is 3.22.28 but it should be reproducible with 3.20.x too.

What is the expected behavior?

What went wrong?
The attached screenshots demonstrate the size difference between M64 and M65.

Did this work before? Yes 64.0.3282.186

Chrome version: 65.0.3325.162  Channel: stable
OS Version: 
Flash Version: 

Seems related to  https://crbug.com/819594  but affects current GTK versions.
 
64.0.3282.186.png
61.5 KB View Download
65.0.3325.162.png
62.8 KB View Download
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
This is also happening to vanilla Arc theme on GTK+ 3.22.


Screenshot from 2018-03-16 11-50-06.png
259 KB View Download
GTK+ version is 3.22.24, BTW.

jianglai@jianglai:~$ dpkg -l | grep libgtk-3
ii  libgtk-3-0:amd64                                  3.22.24-3                                 amd64        GTK+ graphical user interface library
ii  libgtk-3-bin                                      3.22.24-3                                 amd64        programs for the GTK+ graphical user interface library
ii  libgtk-3-common                                   3.22.24-3                                 all          common files for the GTK+ graphical user interface library
ii  libgtk-3-dev:amd64                                3.22.24-3                                 amd64        development files for the GTK+ library

Friendly ping. Is there any plan to fix this soon? I gather it should not be any harder than  https://crbug.com/819594 , whose specifically only applies to GTK+ < 3.20?
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ef426c221d11b53b6de507b398e35e8d7b3cc94

commit 7ef426c221d11b53b6de507b398e35e8d7b3cc94
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Apr 04 01:23:26 2018

Fix frame buttons rendering too large when using OSX-Arc-White GTK theme

The check for GTK 3.20 was incorrect as the issue it was trying to fix
was still occurring on GTK 3.20+ systems.  This CL adds the correct,
but more complex, check.

Verified on these configurations:
{GTK 3.18, GTK 3.22} X
{Breeze, Adwaita, OSX-Arc-White, Greybird} X
{scale=1, scale=2} X
{fullscreen, restored}

BUG= 821881 
R=thestig

Change-Id: I05afa35c1452a46a1abf4c39191a13657bfd8e2c
Reviewed-on: https://chromium-review.googlesource.com/990717
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547921}
[modify] https://crrev.com/7ef426c221d11b53b6de507b398e35e8d7b3cc94/chrome/browser/ui/libgtkui/nav_button_provider_gtk3.cc

Status: Fixed (was: Started)
Labels: Needs-Feedback
Tested this issue on the Ubuntu 14.04 with desktop environment Cinnamon with Adwaita theme as per comment #6 on the reported version 65.0.3325.162 and the latest M67 build 67.0.3388.0.

Issue is not reproducible on the reported version at TE end. Could not observe any difference in the Minimize/Maximize/Close title buttons on the build with and without fix.
Attached is the screen shot for reference.

thomasanderson@ Request you to check and help us in verifying the fix on latest M67 build.

Thanks..
821881.png
754 KB View Download
Status: Verified (was: Fixed)
Screenshot from 2018-04-04 17-02-47.png
118 KB View Download

Sign in to add a comment