New issue
Advanced search Search tips

Issue 821872 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Implement WebViewCompat.setDataDirectorySuffix() for the support library

Project Member Reported by gsennton@chromium.org, Mar 14 2018

Issue description

Corresponding buganizer bug: b/73346423

Had a chat with Torne, and we realized that it might be possible to delay the WebView data-directory creation until the point at which chromium is lazily initialized (from WebViewChromiumAwInit.ensureChromiumStartedLocked(..)).

The benefit of doing so would be that we can set the data directory suffix from the WebView Support Library (the support library hooks into chromium only after one of WebViewChromiumFactory ctors is called), without some ugly hack like having Chromium use reflection to check a support library class.


It's difficult to say whether the data directory is used at some point which we cannot delay to the lazy chromium initialization, so the idea here is to rework PathUtils a little bit to expect a data-directory suffix, and then have PathUtils crash if that suffix has not been set before the data directory is used/created - so that we can find any locations where the data directory is used during initialization.


Torne, I'm assigning this to you (since you offered and know this area ;)), it'd be awesome to get an idea of whether this will work within this week or the next (since 67 Feature freeze is in two weeks).
 

Sign in to add a comment