New issue
Advanced search Search tips

Issue 821856 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: ----
Pri: 2
Type: Task
Q1



Sign in to add a comment

Popup Menu: Position the popup menu relatively to the named layout guide

Project Member Reported by gambard@chromium.org, Mar 14 2018

Issue description

The popup menu originate from a button which has an associated layout guide.
The popup should be positioned relatively to this button.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda96ad1c030689887d9787e48eb409ae69a223c

commit eda96ad1c030689887d9787e48eb409ae69a223c
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Mar 21 07:58:14 2018

Position the popup menu to their layout guide

This CL changes the popup menu presenter such as the popup is correctly
presented relatively to its layout guide.

Bug:  821856 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I426d8b5dfee8bf6fe81644cfa5d03bb7e0f58dcf
Reviewed-on: https://chromium-review.googlesource.com/966028
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544653}
[modify] https://crrev.com/eda96ad1c030689887d9787e48eb409ae69a223c/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
[modify] https://crrev.com/eda96ad1c030689887d9787e48eb409ae69a223c/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm
[modify] https://crrev.com/eda96ad1c030689887d9787e48eb409ae69a223c/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm

Status: Fixed (was: Assigned)
NextAction: 2018-03-28
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e636ba3f5ee24fee06066e8ab82503dd309d2a2

commit 8e636ba3f5ee24fee06066e8ab82503dd309d2a2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 23 13:49:20 2018

Change the sizing of popup menus

If scroll views are presented in the popup menu, the size of the view
needs to be set directly, as it cannot rely on its internal element to
size its outside view.
This CL adds a method to get the ideal size for the elements in the
table view, allowing to have a table view with a minimal width.

Bug:  821856 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4d0c56fbc9897e604526fd1ae5ccc29c801506a4
Reviewed-on: https://chromium-review.googlesource.com/973444
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545420}
[modify] https://crrev.com/8e636ba3f5ee24fee06066e8ab82503dd309d2a2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_item.h
[modify] https://crrev.com/8e636ba3f5ee24fee06066e8ab82503dd309d2a2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm
[modify] https://crrev.com/8e636ba3f5ee24fee06066e8ab82503dd309d2a2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h
[modify] https://crrev.com/8e636ba3f5ee24fee06066e8ab82503dd309d2a2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[modify] https://crrev.com/8e636ba3f5ee24fee06066e8ab82503dd309d2a2/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
[modify] https://crrev.com/8e636ba3f5ee24fee06066e8ab82503dd309d2a2/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm

The NextAction date has arrived: 2018-03-28

Sign in to add a comment