New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 821849

Blocking:
issue 759794



Sign in to add a comment

Update code coverage documentation on chromium.org

Project Member Reported by mmoroz@chromium.org, Mar 14 2018

Issue description

Thanks Hans for pointing that out: https://www.chromium.org/developers/code-coverage

Assuming that current content on that page is obsolete, we may put something like:

"Please follow the instructions from https://cs.chromium.org/chromium/src/tools/code_coverage/coverage.py"

to that page in the mean time? How does it sound?

Later, we can add more details.
 

Comment 1 by mmoroz@chromium.org, Mar 14 2018

Blockedon: 821849
I think it's better to remove that page completely and add a docs/clang_code_coverage.md
I created a CL weeks ago, but forgot to send it out for review, WDYT?
https://chromium-review.googlesource.com/c/chromium/src/+/952296/2/docs/clang_code_coverage.md

Comment 4 by mmoroz@chromium.org, Mar 14 2018

That's great, I'll review it in a bit! Let's then replace that page with a link to docs/clang_code_coverage.md.

I don't want to remove the page completely, as it appears to be the first Google Search result :)
Owner: liaoyuke@chromium.org
Status: Started (was: Available)
that's a good point! I'll also talk to Dirk to ask what's our general strategy regarding obsolete pages.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3b46273e30e56f055b20cec785974e7aa150000

commit d3b46273e30e56f055b20cec785974e7aa150000
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Mar 14 18:25:14 2018

[Coverage] Add documentation for Clang source based code coverage.

Change-Id: I6c3920ca92cf05b41fe69c74936cc0578841847f

Bug:  chromium:821851 
Change-Id: I6c3920ca92cf05b41fe69c74936cc0578841847f
Reviewed-on: https://chromium-review.googlesource.com/952296
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543125}
[add] https://crrev.com/d3b46273e30e56f055b20cec785974e7aa150000/docs/code_coverage.md
[modify] https://crrev.com/d3b46273e30e56f055b20cec785974e7aa150000/tools/code_coverage/coverage.py

Comment 8 by mmoroz@chromium.org, Mar 14 2018

Woohoo! Thanks Yuke!

Sign in to add a comment