Inline histogram names in SavePasswordsPreferences |
||
Issue descriptionKeeping them in String constants prevents presubmit checks on the histograms being used.
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07ef4996a501f1a447e9e605d927452e9f273d44 commit 07ef4996a501f1a447e9e605d927452e9f273d44 Author: Vaclav Brozek <vabr@chromium.org> Date: Fri Mar 16 12:28:16 2018 Inline histograme name in SavePasswordsPreferences.java The histogram name "PasswordManager.Android.PasswordSearchTriggered" is put in a String constant in SavePasswordsPreferences. There are two reasons to inline it instead: (1) Inlining allows better presubmit checks for undefined histogram names. (2) There is only one place where the String constant is used, anyway. This CL inlines the histogram name. Bug: 821823 Change-Id: I16d5ed0e23e3402d0307f537eb904ae7220a2c5b Reviewed-on: https://chromium-review.googlesource.com/964842 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543672} [modify] https://crrev.com/07ef4996a501f1a447e9e605d927452e9f273d44/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
,
Mar 16 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by vabr@chromium.org
, Mar 15 2018