Issue metadata
Sign in to add a comment
|
Location Bar: update tests to work with the flag |
||||||||||||||||||||||
Issue descriptionUpdate the tests to work with the flag. Expected issues: - the security status is not a button anymore, the security info popup is now displayed through the tools menu - The omnibox will not be detected in the view hierarchy when defocused, so everything tapping omnibox will need an update
,
Mar 14 2018
,
Apr 5 2018
,
May 14 2018
,
May 23 2018
The NextAction date has arrived: 2018-05-23
,
May 25 2018
I started looking at this, but I currently have trouble reproducing bot failures locally.
,
May 25 2018
,
May 28 2018
,
May 29 2018
,
May 30 2018
,
Jun 1 2018
This is about halfway done, judging by the number of tests fixed/still broken.
,
Jun 6 2018
The NextAction date has arrived: 2018-06-06
,
Jun 7 2018
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b8fd19bad139dd44c8ee5eb496f43d79fdea128 commit 2b8fd19bad139dd44c8ee5eb496f43d79fdea128 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Fri Jun 08 17:10:35 2018 Fix tests with Refresh Location Bar flag ON. Fixes the tests broken by enabling the refresh location bar, introducing helpers as necessary. Bug: 834345 , 821821 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifb767a192c3f4d3f35bf4714768352a83d4a1d99 Reviewed-on: https://chromium-review.googlesource.com/1070147 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565664} [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/ui/browser_view_controller_egtest.mm [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/web/browsing_egtest.mm [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/browser/web/cache_egtest.mm [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/2b8fd19bad139dd44c8ee5eb496f43d79fdea128/ios/chrome/test/earl_grey/chrome_matchers.mm
,
Jun 11 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/18e9fa151677c53f0a8b85910b635d24b4ff17f1 commit 18e9fa151677c53f0a8b85910b635d24b4ff17f1 Author: stkhapugin@chromium.org <stkhapugin@google.com> Date: Mon Jun 11 08:06:27 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f4a77131bb9fa7108b3b400b59cd1ba8b8a545f commit 1f4a77131bb9fa7108b3b400b59cd1ba8b8a545f Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Wed Jun 13 09:31:40 2018 Enable Location Bar flag by default. Enables the UI Refresh location bar flag by default. Fixes a test that was attempting to tap the location view twice. Bug: 821821 Tbr: noyau@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I02ad0dfbc98d86183b1a3628e2195b28e8993cd6 Reviewed-on: https://chromium-review.googlesource.com/1090929 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#566774} [modify] https://crrev.com/1f4a77131bb9fa7108b3b400b59cd1ba8b8a545f/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/1f4a77131bb9fa7108b3b400b59cd1ba8b8a545f/ios/chrome/browser/ui/ui_feature_flags.cc
,
Jun 13 2018
,
Jun 19 2018
Location bar is enabled by default now. Verified in iPad 5th Gen iOS 10.3.3, iPhoneX iOS12 M69.0.3465.0 dev
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by stkhapugin@chromium.org
, Mar 14 2018