New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821817 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 4
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-04
OS: iOS
Pri: 1
Type: Task
Q2

Blocked on:
issue 838824

Blocking:
issue 821816



Sign in to add a comment

Location Bar: implement specs for the popup

Project Member Reported by stkhapugin@chromium.org, Mar 14 2018

Issue description

The suggestions popup should be presented differently (per mocks)
 
Labels: -Q1 Q2
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20f5b3ea445da6079fc3a5b5123bf306af7b5cfb

commit 20f5b3ea445da6079fc3a5b5123bf306af7b5cfb
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Thu Mar 22 11:27:24 2018

[iOS] Add new feature flag and helper for popup presentation.

Adds new feature flag, kRefreshPopupPresentation, for UI refresh omnibox
popup presentation.

Bug:  821817 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib4ed4f181e49849d5c5858b2457e14553f8d60af
Reviewed-on: https://chromium-review.googlesource.com/973308
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545039}
[modify] https://crrev.com/20f5b3ea445da6079fc3a5b5123bf306af7b5cfb/ios/chrome/browser/ui/ui_feature_flags.cc
[modify] https://crrev.com/20f5b3ea445da6079fc3a5b5123bf306af7b5cfb/ios/chrome/browser/ui/ui_feature_flags.h
[modify] https://crrev.com/20f5b3ea445da6079fc3a5b5123bf306af7b5cfb/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/20f5b3ea445da6079fc3a5b5123bf306af7b5cfb/ios/chrome/browser/ui/ui_util.mm

Status: Assigned (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b61f7a814310e5da99c87adaf101c755da1c7f64

commit b61f7a814310e5da99c87adaf101c755da1c7f64
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Mar 23 11:12:30 2018

Make omnibox popup view controller not a table view controller.

In order to be able to swap table view class with a custom table view,
decouple popup presentation from using specifically UITableViewController,
use a UIViewController with a UITableView instead.

Bug:  821817 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1256cb95d5f6ffaff45fb3d7a5d972a9210a338d
Reviewed-on: https://chromium-review.googlesource.com/973615
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545402}
[modify] https://crrev.com/b61f7a814310e5da99c87adaf101c755da1c7f64/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/b61f7a814310e5da99c87adaf101c755da1c7f64/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.h
[modify] https://crrev.com/b61f7a814310e5da99c87adaf101c755da1c7f64/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.mm
[modify] https://crrev.com/b61f7a814310e5da99c87adaf101c755da1c7f64/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.h
[modify] https://crrev.com/b61f7a814310e5da99c87adaf101c755da1c7f64/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[add] https://crrev.com/b61f7a814310e5da99c87adaf101c755da1c7f64/ios/chrome/browser/ui/omnibox/popup/table_view_owning.h

Comment 6 by cmasso@google.com, Apr 5 2018

Labels: Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de350e487efb7cb1636db34f193ee24206d52527

commit de350e487efb7cb1636db34f193ee24206d52527
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Apr 13 17:17:57 2018

Create a self-sizing table view.

Creates a new class, SelfSizingTableView, which is a table view that
is capable of calculating its intrinsic size.
Use this class for the omnibox popup table view.

Bug:  821817 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc01dfcd20ed1f14e15162ac0085f40273747eac
Reviewed-on: https://chromium-review.googlesource.com/973617
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550661}
[modify] https://crrev.com/de350e487efb7cb1636db34f193ee24206d52527/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/de350e487efb7cb1636db34f193ee24206d52527/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[add] https://crrev.com/de350e487efb7cb1636db34f193ee24206d52527/ios/chrome/browser/ui/omnibox/popup/self_sizing_table_view.h
[add] https://crrev.com/de350e487efb7cb1636db34f193ee24206d52527/ios/chrome/browser/ui/omnibox/popup/self_sizing_table_view.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bfe1f71313e66c9d4c97948926d0dbec1e7073b

commit 8bfe1f71313e66c9d4c97948926d0dbec1e7073b
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Tue Apr 17 14:42:42 2018

[iOS] Use autolayout to present the omnibox popup.

Makes the omnibox popup presenter use autolayout to display the
popup view controller. The correct height of the popup is then
communicated by means of intrinsicContentSize of the popup table view.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I521adfbff62c3c42e7120fb7bb5f7f5b09bfd2b3
Bug:  821817 
Reviewed-on: https://chromium-review.googlesource.com/978177
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551326}
[modify] https://crrev.com/8bfe1f71313e66c9d4c97948926d0dbec1e7073b/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/8bfe1f71313e66c9d4c97948926d0dbec1e7073b/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.h
[modify] https://crrev.com/8bfe1f71313e66c9d4c97948926d0dbec1e7073b/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.mm
[modify] https://crrev.com/8bfe1f71313e66c9d4c97948926d0dbec1e7073b/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.h
[modify] https://crrev.com/8bfe1f71313e66c9d4c97948926d0dbec1e7073b/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[delete] https://crrev.com/75cb62133ff9fcb020cc76c41e10cf35b1aefcbc/ios/chrome/browser/ui/omnibox/popup/table_view_owning.h

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de350e487efb7cb1636db34f193ee24206d52527

commit de350e487efb7cb1636db34f193ee24206d52527
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Apr 13 17:17:57 2018

Create a self-sizing table view.

Creates a new class, SelfSizingTableView, which is a table view that
is capable of calculating its intrinsic size.
Use this class for the omnibox popup table view.

Bug:  821817 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc01dfcd20ed1f14e15162ac0085f40273747eac
Reviewed-on: https://chromium-review.googlesource.com/973617
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550661}
[modify] https://crrev.com/de350e487efb7cb1636db34f193ee24206d52527/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/de350e487efb7cb1636db34f193ee24206d52527/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[add] https://crrev.com/de350e487efb7cb1636db34f193ee24206d52527/ios/chrome/browser/ui/omnibox/popup/self_sizing_table_view.h
[add] https://crrev.com/de350e487efb7cb1636db34f193ee24206d52527/ios/chrome/browser/ui/omnibox/popup/self_sizing_table_view.mm

NextAction: 2018-05-23
The NextAction date has arrived: 2018-05-23
Cc: stkhapugin@chromium.org
Owner: pschaffner@chromium.org
There are multiple mocks for the popup and it's unclear which one to use. Pete, please provide the mocks, and new assets if necessary. 
Labels: Proj-UIRefresh
Blockedon: 838824
NextAction: 2018-06-20

Comment 16 by lod@chromium.org, Jun 8 2018

Blocking: 821816
Cc: lod@chromium.org
Summary: Location Bar: provide specs for the popup (was: Location Bar: update presentation of the popup on iPad)
Per offline discussion, this needs to be similar to today's popup, but with new fonts/icons/colors. Please provide a spec.
NextAction: 2018-06-14
The NextAction date has arrived: 2018-06-14
NextAction: 2018-06-15
The NextAction date has arrived: 2018-06-15
Owner: stkhapugin@chromium.org
SPECS
=====

## Container View
- remove top edge shadow
- remove bottom edge shadow (RxR)
- background: same visual effect view used in toolbar for CxA / AxC; #fafafa opaque in RxR (same as toolbar)

## Cells
- match collection cells for icon + label + sub-label layout
- match highlight state of collection/menu cells
- match collection cell label typography
- primary label color: black and white in incognito
- sub-label (url) color: black @ 0.41 alpha and white @ 0.5 alpha
- keep existing elision logic
- keep existing "append query" icon but tint black @ 0.3 alpha and white @ 0.5 alpha for incognito
- completion type icon subview: 28x28pt rect background rect with 7pt corner radius and black @ 0.03 alpha and white @ 0.05 alpha in incognito; completion type icons (attached) black @ 0.33 alpha and white @ 0.4 alpha in incognito

## Completion Type Icons (in omnibox)
- 20x20pt frame, inset 10pt from leading edge of omnibox container view
- tint black @ 0.2 alpha and white @ 0.3 alpha in incognito
Screen Shot 2018-06-15 at 17.30.08.png
240 KB View Download
Screen Shot 2018-06-15 at 17.30.59.png
216 KB View Download
omnibox_completion_icons.zip
15.5 KB Download
Summary: Location Bar: implement specs for the popup (was: Location Bar: provide specs for the popup)
 Issue 821816  has been merged into this issue.
Project Member

Comment 25 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bef88184e7d1ac04dfbcc874ece29e702b75233

commit 7bef88184e7d1ac04dfbcc874ece29e702b75233
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jun 20 20:17:13 2018

[iOS] Create a new popup presenter for UI Refresh.

Creates a new popup presenter, renames the old one to "Legacy". Removes
existing forking on IsUIRefreshPhase1Enabled, otherwise the new class
is a copy of the Legacy one.
Adds a protocol to allow having two implementations for presenters.

This will allow not having forking everywhere in the file.

Bug:  821817 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1c3ee5c30d50123544f2288ec95d8e80e7b59032
Reviewed-on: https://chromium-review.googlesource.com/1107981
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568969}
[modify] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
[add] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_generic_presenter.h
[add] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_legacy_presenter.h
[add] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_legacy_presenter.mm
[modify] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.h
[modify] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.mm
[modify] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.h
[modify] https://crrev.com/7bef88184e7d1ac04dfbcc874ece29e702b75233/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.mm

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8da8f8a71836bc73ab3a9929f204f2d959acfd2

commit c8da8f8a71836bc73ab3a9929f204f2d959acfd2
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Jun 22 09:56:23 2018

[iOS] Style the UI Refresh popup.

Styles the popup per spec:
* removes shadows
* makes background match the toolbar background

Bug:  821817 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9073e78aa6a83b00ab97d45abf590b01ce90886e
Reviewed-on: https://chromium-review.googlesource.com/1108210
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569566}
[modify] https://crrev.com/c8da8f8a71836bc73ab3a9929f204f2d959acfd2/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/c8da8f8a71836bc73ab3a9929f204f2d959acfd2/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
[modify] https://crrev.com/c8da8f8a71836bc73ab3a9929f204f2d959acfd2/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.h
[modify] https://crrev.com/c8da8f8a71836bc73ab3a9929f204f2d959acfd2/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.mm
[modify] https://crrev.com/c8da8f8a71836bc73ab3a9929f204f2d959acfd2/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm

## Typography Specs (because you asked)
- Primary label (top): 17pt SF 
- Secondary label (bottom): 12pt SF
- Bold completion highlighting for both labels: SF semibold

## Selection state
- normal black @ 0.05 alpha; incognito white @ 0.1
Status: Started (was: Assigned)
Cc: rohitrao@chromium.org mard...@chromium.org sczs@chromium.org martijnb@chromium.org thegreenfrog@chromium.org
 Issue 847795  has been merged into this issue.
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a24b0916e841babc508cd003073dd36b4341e6

commit e1a24b0916e841babc508cd003073dd36b4341e6
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Tue Jun 26 09:18:11 2018

[iOS UI Refresh] Use proper colors for popup.

Use colors from the popup spec for the omnibox popup.

Bug:  821817 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic90f502e54b4d338ebfbc4532e70467f890dac8a
Reviewed-on: https://chromium-review.googlesource.com/1111856
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570356}
[modify] https://crrev.com/e1a24b0916e841babc508cd003073dd36b4341e6/ios/chrome/browser/ui/omnibox/autocomplete_match_formatter.mm
[modify] https://crrev.com/e1a24b0916e841babc508cd003073dd36b4341e6/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.mm

Attaching the calculator (equal sign) assets.
calculator_icons.zip
1.4 KB Download

Comment 32 by marq@chromium.org, Jun 27 2018

NextAction: 2018-07-04
Moving open tasks to the current sprint.
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b72a45e9ac8da164737860cc1e25909bb88b8c5

commit 5b72a45e9ac8da164737860cc1e25909bb88b8c5
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jun 27 12:58:32 2018

[UI Refresh] Omnibox popup styling.

Uses new icons, adds a background for the icons, changes the icon
offset to match the new omnibox layout.

Bug:  821817 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibdd074891eb1f4b0853c28b9117d1e84f05e070c
Reviewed-on: https://chromium-review.googlesource.com/1114744
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570743}
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/BUILD.gn
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/autocomplete_match_formatter.mm
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/autocomplete_suggestion.h
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/omnibox_util.cc
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/omnibox_util.h
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.h
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.mm
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/BUILD.gn
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_bookmark.imageset/Contents.json
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_bookmark.imageset/omnibox_completion_bookmark.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_bookmark.imageset/omnibox_completion_bookmark@2x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_bookmark.imageset/omnibox_completion_bookmark@3x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_calculator.imageset/Contents.json
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_calculator.imageset/omnibox_completion_calculator.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_calculator.imageset/omnibox_completion_calculator@2x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_calculator.imageset/omnibox_completion_calculator@3x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_default_favicon.imageset/Contents.json
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_default_favicon.imageset/omnibox_completion_default_favicon.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_default_favicon.imageset/omnibox_completion_default_favicon@2x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_default_favicon.imageset/omnibox_completion_default_favicon@3x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_history.imageset/Contents.json
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_history.imageset/omnibox_completion_history.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_history.imageset/omnibox_completion_history@2x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_history.imageset/omnibox_completion_history@3x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_search.imageset/Contents.json
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_search.imageset/omnibox_completion_search.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_search.imageset/omnibox_completion_search@2x.png
[add] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/omnibox/resources/omnibox_completion_search.imageset/omnibox_completion_search@3x.png
[modify] https://crrev.com/5b72a45e9ac8da164737860cc1e25909bb88b8c5/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm

One thing left here is the iPad multitasking, which should be the same as iPhone but currently is very different. I am still working on this. 
Project Member

Comment 35 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42418b4b8d715228f5763cbeccfdfecb4d3ccc93

commit 42418b4b8d715228f5763cbeccfdfecb4d3ccc93
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Jun 29 12:05:31 2018

[iOS] Make UI Refresh popup change appearance with size classes.

iPad multitasking UI should match iPhone or normal iPad depending on
size class:
 * in RxR size class, it should show the suggestion icons and align
to the icon in the omnibox
 * in other size classes, it should be left-aligned and have no
suggestion icons

However, pre-UI Refresh UI should remain the same.

Bug:  821817 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibeed9ecf4f4b1058e80e7e4d45523b1d1f0d4ee8
Reviewed-on: https://chromium-review.googlesource.com/1118225
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571445}
[modify] https://crrev.com/42418b4b8d715228f5763cbeccfdfecb4d3ccc93/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.mm
[modify] https://crrev.com/42418b4b8d715228f5763cbeccfdfecb4d3ccc93/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm

The NextAction date has arrived: 2018-07-04
Status: Fixed (was: Started)

Sign in to add a comment