New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821815 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Location Bar: update icons for security states

Project Member Reported by stkhapugin@chromium.org, Mar 14 2018

Issue description

Use new icons for security states. 
 
Labels: -Q1 Q2
Labels: -Small Medium

Comment 3 by cmasso@google.com, Apr 5 2018

Labels: Pri-1
Labels: Proj-UIRefresh
Cc: stkhapugin@chromium.org
Owner: lod@chromium.org
NextAction: 2018-06-20
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cdd975c34feaba7bee1bc3572a79575c368f41c

commit 6cdd975c34feaba7bee1bc3572a79575c368f41c
Author: Elodie Banel <lod@google.com>
Date: Fri Jun 08 14:36:24 2018

Swap icons for location bar security states
This CL is the first step: create new imagesets + 1 function to return the
correct image name.

Bug:  821815 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia2ce8dc327226857b3105605b23b5b220edb9ff6
Reviewed-on: https://chromium-review.googlesource.com/1088912
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565628}
[modify] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/BUILD.gn
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/Contents.json
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous.png
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@2x.png
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@3x.png
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/Contents.json
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure.png
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@2x.png
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@3x.png
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/Contents.json
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure.png
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@2x.png
[add] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@3x.png
[modify] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/omnibox/omnibox_util.cc
[modify] https://crrev.com/6cdd975c34feaba7bee1bc3572a79575c368f41c/ios/chrome/browser/ui/omnibox/omnibox_util.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0036e486338c0c55972235c5f7b764090b30e0c0

commit 0036e486338c0c55972235c5f7b764090b30e0c0
Author: Elodie Banel <lod@google.com>
Date: Fri Jun 08 15:20:34 2018

Use new icons for security state in omnibox.

Bug:  821815 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifc9c196dc725cda6e4b369473aefdfea284fd36f
Reviewed-on: https://chromium-review.googlesource.com/1089050
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565637}
[modify] https://crrev.com/0036e486338c0c55972235c5f7b764090b30e0c0/ios/chrome/browser/ui/location_bar/BUILD.gn
[modify] https://crrev.com/0036e486338c0c55972235c5f7b764090b30e0c0/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm

Comment 9 by lod@chromium.org, Jun 8 2018

Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-06-20

Sign in to add a comment