Issue metadata
Sign in to add a comment
|
Location Bar: match placeholder text behavior to mocks |
||||||||||||||||||||||
Issue descriptionMatch placeholder behaviour to the mocks: hide it and show it when necessary
,
Mar 15 2018
,
Mar 28 2018
The NextAction date has arrived: 2018-03-28
,
Apr 5 2018
,
Apr 9 2018
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 10 2018
,
Apr 11 2018
,
Apr 16 2018
,
Apr 16 2018
,
May 14 2018
,
May 17 2018
,
May 17 2018
The placeholder text is the text visible in the textfield when there is no text. For example, without UI Refresh, focus omnibox and remove the URL, then type one symbol, than hit backspace. "Search or type URL" placeholder text will appear. Before UI Refresh, we had to support a corner case of iPad NTP. On iPad NTP, we were showing both the omnibox textfield and the fakebox. It was visually unpleasing to have the placeholder text twice, so we had special logic to not show the placeholder text on iPad NTP. In UI Refresh, placeholder text can only be seen in edit state; in steady state on NTP nothing is visible without any special placeholder text handling. Therefore, that custom logic is not necessary anymore.
,
May 23 2018
The NextAction date has arrived: 2018-05-23
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de7475c004e950176afc687deaf3aa907decbb56 commit de7475c004e950176afc687deaf3aa907decbb56 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Wed May 23 12:13:09 2018 Add placeholder text to UI Refresh omnibox. Adds placeholder text to the omnibox. Bug: 821814 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I48efe7c94afd4ed929b2020f8c68e4031376fea8 Reviewed-on: https://chromium-review.googlesource.com/1064411 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#561042} [modify] https://crrev.com/de7475c004e950176afc687deaf3aa907decbb56/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
,
May 23 2018
Issue 845863 has been merged into this issue.
,
May 23 2018
,
May 28 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by stkhapugin@chromium.org
, Mar 14 2018