New issue
Advanced search Search tips

Issue 821814 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 0
Type: Task
Q2



Sign in to add a comment

Location Bar: match placeholder text behavior to mocks

Project Member Reported by stkhapugin@chromium.org, Mar 14 2018

Issue description

Match placeholder behaviour to the mocks: hide it and show it when necessary
 
NextAction: 2018-04-28

Comment 2 by cmasso@google.com, Mar 15 2018

NextAction: 2018-03-28
The NextAction date has arrived: 2018-03-28

Comment 4 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by cmasso@google.com, Apr 10 2018

Labels: -Q1 Q2

Comment 7 by cmasso@google.com, Apr 11 2018

NextAction: ----

Comment 8 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags

Comment 9 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
NextAction: 2018-05-23
Status: Started (was: Assigned)
The placeholder text is the text visible in the textfield when there is no text. For example, without UI Refresh, focus omnibox and remove the URL, then type one symbol, than hit backspace. "Search or type URL" placeholder text will appear.

Before UI Refresh, we had to support a corner case of iPad NTP. On iPad NTP, we were showing both the omnibox textfield and the fakebox. It was visually unpleasing to have the placeholder text twice, so we had special logic to not show the placeholder text on iPad NTP.

In UI Refresh, placeholder text can only be seen in edit state; in steady state on NTP nothing is visible without any special placeholder text handling. Therefore, that custom logic is not necessary anymore. 


The NextAction date has arrived: 2018-05-23
Project Member

Comment 14 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de7475c004e950176afc687deaf3aa907decbb56

commit de7475c004e950176afc687deaf3aa907decbb56
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed May 23 12:13:09 2018

Add placeholder text to UI Refresh omnibox.

Adds placeholder text to the omnibox.

Bug:  821814 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I48efe7c94afd4ed929b2020f8c68e4031376fea8
Reviewed-on: https://chromium-review.googlesource.com/1064411
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561042}
[modify] https://crrev.com/de7475c004e950176afc687deaf3aa907decbb56/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm

Issue 845863 has been merged into this issue.
Status: Fixed (was: Started)
Labels: Proj-UIRefresh

Sign in to add a comment