New issue
Advanced search Search tips

Issue 821810 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2



Sign in to add a comment

Location Bar: implement share icon, defocused

Project Member Reported by stkhapugin@chromium.org, Mar 14 2018

Issue description

In defocused state, there should be a voice search icon that launches voice search. 
 
NextAction: 2018-04-28

Comment 2 by cmasso@google.com, Mar 15 2018

NextAction: 2018-03-28
The NextAction date has arrived: 2018-03-28

Comment 4 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by cmasso@google.com, Apr 10 2018

Labels: -Q1 Q2

Comment 7 by cmasso@google.com, Apr 11 2018

NextAction: ----
Summary: Location Bar: implement share icon, defocused (was: Location Bar: implement voice search icon, defocused)
Status: Started (was: Assigned)

Comment 10 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags

Comment 11 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72a05021f6b0647233e5bef0efe59416c3264dbd

commit 72a05021f6b0647233e5bef0efe59416c3264dbd
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Tue Apr 17 14:05:05 2018

[iOS UI Refresh] Add share button to location view.

Adds a share button in steady state location view. The button is only
shown in compact environments; in regular it would duplicate the one in
the toolbar so it's not shown.

Temporarily uses the icon from the similar toolbar button.

Bug:  821810 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2fcfa9673b80851fe63fb0a8e040450b5bb8e0c0
Reviewed-on: https://chromium-review.googlesource.com/1012064
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551315}
[modify] https://crrev.com/72a05021f6b0647233e5bef0efe59416c3264dbd/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
[modify] https://crrev.com/72a05021f6b0647233e5bef0efe59416c3264dbd/ios/chrome/browser/ui/location_bar/location_bar_steady_view.h
[modify] https://crrev.com/72a05021f6b0647233e5bef0efe59416c3264dbd/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
[modify] https://crrev.com/72a05021f6b0647233e5bef0efe59416c3264dbd/ios/chrome/browser/ui/location_bar/location_bar_view_controller.h
[modify] https://crrev.com/72a05021f6b0647233e5bef0efe59416c3264dbd/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm

Status: Fixed (was: Started)
Labels: Proj-UIRefresh

Sign in to add a comment