Location Bar: exit fullscreen on first tap when scrolled away, only focus on second tap |
||||||||||
Issue descriptionWhen tapped, the defocused location bar focuses the omnibox. Except when it's scrolled away in fullscreen - in this case, it should quit fullscreen and not focused.
,
Apr 5 2018
,
Apr 11 2018
,
Apr 25 2018
,
May 7 2018
Thanks to Kurt, there's now a simple API to do this: http://crrev.com/c/1009068
,
May 28 2018
,
Jun 11 2018
,
Jun 11 2018
,
Jun 25 2018
,
Jun 25 2018
I ran into crbug.com/856220 while implementing this, but otherwise CL 1113749 should do the trick.
,
Jun 26 2018
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec9769001347865fca0f2dbda5c12c8a7d7b7875 commit ec9769001347865fca0f2dbda5c12c8a7d7b7875 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Tue Jun 26 09:14:11 2018 [UI Refresh] Exit fullscreen when tapping the fullscreen steady locbar. When the steady location bar is tapped when in scrolled-away state, it now exits fullscreen first; only the second tap focuses the omnibox. Bug: 821807 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iadaed09fa545d4335872f4f5990d6201a2351782 Reviewed-on: https://chromium-review.googlesource.com/1113749 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570353} [modify] https://crrev.com/ec9769001347865fca0f2dbda5c12c8a7d7b7875/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by stkhapugin@chromium.org
, Mar 14 2018