New issue
Advanced search Search tips

Issue 821804 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Location Bar: match mocks for defocused state

Project Member Reported by stkhapugin@chromium.org, Mar 14 2018

Issue description

Make defocused state look per mocks - correct font, spacing, colors
 
Labels: -Q1 Q2

Comment 2 by cmasso@google.com, Apr 5 2018

Labels: Pri-1
NextAction: 2018-05-23
This also requires making the path visible on ipad 
The NextAction date has arrived: 2018-05-23
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d42ffeb3d227f908b62432338885df98bddf258

commit 3d42ffeb3d227f908b62432338885df98bddf258
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Thu May 24 15:42:35 2018

[UI Refresh] Update share/voice search icons in the location bar.

Adds and uses new button icons for the location bar's trailing button.

Bug:  821804 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icf1ca41bb65610940545dee1e94a7e16ca33895f
Reviewed-on: https://chromium-review.googlesource.com/1069356
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561511}
[modify] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/BUILD.gn
[modify] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
[modify] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/BUILD.gn
[add] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/Contents.json
[add] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share.png
[add] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@2x.png
[add] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@3x.png
[add] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/Contents.json
[add] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice.png
[add] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@2x.png
[add] https://crrev.com/3d42ffeb3d227f908b62432338885df98bddf258/ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@3x.png

Cc: pschaffner@chromium.org mard...@chromium.org martijnb@chromium.org
NextAction: ----
Status: Assigned (was: Started)
This is mostly done. There is an ongoing debate regarding showing the path on iPad which will affect the defocused state behavior and animations. I am blocked on a final decision here.
Is there a way to reflect the "mostly done"-ness of this by forking off a new bug for the path debate, so the completeness is accurately reflected in the dashboard?
Project Member

Comment 10 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d

commit c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri May 25 16:17:36 2018

[UI Refresh] Location bar icons for NTP and Offline pages.

Makes the location bar not show any icon on NTP. Adds a new offline
icon and uses it for offline pages.

Bug:  821804 , 845956
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icd8aba94af4fcabed9c35f3e322312624cb24835
Reviewed-on: https://chromium-review.googlesource.com/1071511
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561899}
[modify] https://crrev.com/c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d/ios/chrome/browser/ui/location_bar/BUILD.gn
[modify] https://crrev.com/c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm
[modify] https://crrev.com/c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d/ios/chrome/browser/ui/location_bar/resources/BUILD.gn
[add] https://crrev.com/c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d/ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/Contents.json
[add] https://crrev.com/c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d/ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline.png
[add] https://crrev.com/c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d/ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@2x.png
[add] https://crrev.com/c9d21aee0dcb7fd8e3f8c6c93da6b0380271cc2d/ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@3x.png

Labels: Proj-UIRefresh
Status: Fixed (was: Assigned)
As discussed over email, we're not going to show the path on iPads, thus this is done. 

Sign in to add a comment