New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821802 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
hobby only
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix password export warning style to match the mocks

Project Member Reported by vabr@chromium.org, Mar 14 2018

Issue description

The design for a warning dialog for exporting passwords from Chrome on Android settings (go/ajcah) prescribes grey font colour.

The dialog was implemented with the AlertDialog with SimpleDialog style in r535552. The text was added via AlertDialog.Builder.setMessage, and appeared black. maxwalker@ filed an internal bug (b/70147365) for this being inconsistent with Material Design guidelines.

In the meantime, I discovered that if the message is set not in the builder, but by including a TextView in the dialog's layout and setting the text on that TextView, the result looks like the mocks (grey).

This bug tracks changing the dialog so that it more closely matches the mocks. Cc-ing Max to shout if he has any objections.
 

Comment 1 by vabr@chromium.org, Mar 14 2018

Cc: maxwalker@chromium.org
Uploading the screenshots of the old dialog and the new one for reference.

Also adding Max for real now. Max -- please object if you don't think the style from the new_warning.png should replace the style from the old_warning.png. (There are no text changes, just the font colour of the message.)
old_warning.png
94.8 KB View Download
new_warning.png
89.8 KB View Download

Comment 2 by vabr@chromium.org, Mar 14 2018

Description: Show this description

Comment 3 by vabr@chromium.org, Mar 14 2018

CL in review at https://crrev.com/c/962602

Comment 4 by vabr@chromium.org, Mar 14 2018

Status: WontFix (was: Started)
In the discussion on the CL, twellington@ made a good case about fixing this particular dialog being just a one-off hack, which could possible make a general solution (bug 792272) harder to achieve.

Because the current API is deemed acceptable, I will mark this as WontFix and we can wait until the work in bug 792272 is done.

Sign in to add a comment