Fix password export warning style to match the mocks |
|||
Issue descriptionThe design for a warning dialog for exporting passwords from Chrome on Android settings (go/ajcah) prescribes grey font colour. The dialog was implemented with the AlertDialog with SimpleDialog style in r535552. The text was added via AlertDialog.Builder.setMessage, and appeared black. maxwalker@ filed an internal bug (b/70147365) for this being inconsistent with Material Design guidelines. In the meantime, I discovered that if the message is set not in the builder, but by including a TextView in the dialog's layout and setting the text on that TextView, the result looks like the mocks (grey). This bug tracks changing the dialog so that it more closely matches the mocks. Cc-ing Max to shout if he has any objections.
,
Mar 14 2018
,
Mar 14 2018
CL in review at https://crrev.com/c/962602
,
Mar 14 2018
In the discussion on the CL, twellington@ made a good case about fixing this particular dialog being just a one-off hack, which could possible make a general solution (bug 792272) harder to achieve. Because the current API is deemed acceptable, I will mark this as WontFix and we can wait until the work in bug 792272 is done. |
|||
►
Sign in to add a comment |
|||
Comment 1 by vabr@chromium.org
, Mar 14 201894.8 KB
94.8 KB View Download
89.8 KB
89.8 KB View Download