subj
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb77e079e161308f82c8e61a59badf06f2335999 commit bb77e079e161308f82c8e61a59badf06f2335999 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Wed Mar 14 18:26:22 2018 [iOS] Stop using LocationBarControllerIOS for UI Refresh. Replaces LBCI with a slimmer class - WebOmniboxEditControllerImpl - to interface with omnibox components API. Reimplements LBCI's logic in WOECImpl, OmniboxCoordinator. Forks necessary classes to support this. The classes replacing LBCI only implement logic that is necessary for UI Refresh, dropping: - Security icons (To be implemented in LocationBarMediator/VController) - Showing page info popup (to be implemented elsewhere) - Hint text (To be implemented in the LBViewController) With this CL, the omnibox loses the location icon, but otherwise the app is functional, with working omnibox and popup. Bug: 821801 , 821799 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3cdc064acc3bb642d2f60d4a47d61cf4ce60da8d Reviewed-on: https://chromium-review.googlesource.com/941131 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#543127} [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/BUILD.gn [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_legacy_consumer.h [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.h [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.mm [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_legacy_mediator.h [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_legacy_mediator.mm [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_legacy_view.h [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_legacy_view.mm [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/location_bar/location_bar_mediator_unittest.mm [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/BUILD.gn [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.h [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/omnibox_coordinator.h [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/omnibox_coordinator.mm [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.h [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller_impl.h [add] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller_impl.mm [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm [modify] https://crrev.com/bb77e079e161308f82c8e61a59badf06f2335999/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
On track for 3/28?
The NextAction date has arrived: 2018-03-28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0901c3a7fd6545043c59ed1bf99e20e365a181a3 commit 0901c3a7fd6545043c59ed1bf99e20e365a181a3 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Tue Apr 10 11:39:51 2018 [iOS] Add defocused state of location bar in UI refresh. Makes the location bar transform to a new defocused state where the ToolbarModel's display URL and security icon are displayed. Transitions to normal textfield on touch. Introduces new class: LocationView, a simple view displaying the location icon and text. Introduces new class: LocationBarViewController, which displays the two location bar views: LocationView and LocationBarView. Removes unused focus/defocus animation code from location bar view. Bug: 821801 , 821799 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If058ec14fdc466b13f7917ba668be80d4781a4f8 Reviewed-on: https://chromium-review.googlesource.com/943861 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549487} [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/BUILD.gn [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_consumer.h [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [add] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_edit_view.h [add] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_edit_view.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_generic_coordinator.h [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.h [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_legacy_view.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_mediator.h [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm [add] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_steady_view.h [add] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm [delete] https://crrev.com/c0b13303bc02cd111f5d5985ec0a763e635919d2/ios/chrome/browser/ui/location_bar/location_bar_view.h [delete] https://crrev.com/c0b13303bc02cd111f5d5985ec0a763e635919d2/ios/chrome/browser/ui/location_bar/location_bar_view.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_view_controller.h [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/omnibox/BUILD.gn [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/omnibox/omnibox_coordinator.h [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/omnibox/omnibox_coordinator.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/toolbar/keyboard_assist/BUILD.gn [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/0901c3a7fd6545043c59ed1bf99e20e365a181a3/ios/chrome/test/earl_grey/chrome_matchers.mm
The URL is displayed, but it's not in the correct format yet. Another CL is pending to implement that.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e276a96b580bada06b6a4ca38d3dcd1862ef05e commit 3e276a96b580bada06b6a4ca38d3dcd1862ef05e Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Fri Apr 13 13:13:59 2018 Change format types of display URL on iOS Modifies the format types passed to the URL formatter in GetURLForDisplay() on iOS to trim after host. Bug: 821801 Change-Id: Ib744a161d0488b5e0f3ee8e0d81947da17bb22cb Reviewed-on: https://chromium-review.googlesource.com/1007079 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550605} [modify] https://crrev.com/3e276a96b580bada06b6a4ca38d3dcd1862ef05e/components/toolbar/toolbar_model_impl.cc
Comment 1 by stkhapugin@chromium.org
, Mar 14 2018