Notification activation not delivered |
||||
Issue descriptionSteps to repro: 1. Install Canary, version 67.0.3370.0. 2. Enable Native Notifications (chrome://flags/#enable-native-notifications) 3. Navigate to https://tests.peter.sh/notification-generator/ 4. Allow notifications (popup). 5. Under Action (scroll to bottom), select 'Open new window'. 6. Click 'Display the notification'. 7. Click the notification that just appeared. Expected: Notification disappears and a new window appear. Actual: Only the former happens.
,
Mar 14 2018
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/490cbadc4d5f5a6533064264998a7f43e5943bb0 commit 490cbadc4d5f5a6533064264998a7f43e5943bb0 Author: Xi Cheng <chengx@chromium.org> Date: Thu Mar 15 18:52:57 2018 Fix passing activation information from startup to NotificationPlatformBridgeWin This should fix the issue that notification activation is not working in some cases. Bug: 734095 , 821793 Change-Id: If19f1c802b7da3b1cd0476c0a585138a2d2edcaa Reviewed-on: https://chromium-review.googlesource.com/963685 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#543461} [modify] https://crrev.com/490cbadc4d5f5a6533064264998a7f43e5943bb0/chrome/browser/notifications/notification_platform_bridge_win.cc [modify] https://crrev.com/490cbadc4d5f5a6533064264998a7f43e5943bb0/chrome/browser/notifications/notification_platform_bridge_win.h [modify] https://crrev.com/490cbadc4d5f5a6533064264998a7f43e5943bb0/chrome/browser/ui/startup/startup_browser_creator_impl.cc
,
Mar 15 2018
This is a regression introduced by crrev/c/955482. Since the notification activation flow touches quite a few components -- notification_helper, startup, notifications, or even shortcut, it is quite easy to go wrong. Sadly, we don't have a test to catch this sort of thing yet. We definitely need this to happen, otherwise Finnur and I are likely to be in trouble maintaining this feature in the future.
,
Mar 16 2018
Verified the fix on Windows-10 using Chrome version #67.0.3372.0 as per the comment #0. Attaching screen cast for reference. Observed that Notification disappeared and a new window appeared. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 67.0.3370.0 Thanks...!! |
||||
►
Sign in to add a comment |
||||
Comment 1 by finnur@chromium.org
, Mar 14 2018