Implement TracingController APIs for the support library |
||||||
Issue descriptionSomething I just realized: It would be nice to use the constants in android.webkit.TracingConfig in the support library as well - which we can do in the support library package, but on the chromium side we cannot import those constants (since we do not build against P yet), unless we add a downstream component to the support library. I think it makes most sense to just temporarily declare our own constants, in the support library glue layer, which correspond exactly to the constants in TracingConfig. Torne/Tim WDYT?
,
Jun 4 2018
-> nate I guess
,
Jun 4 2018
Actually, I think Tim is the best person to implement this. It's blocked on "How to contribute" docs, but those are rolling out this week. Arbitrarily adding the M-69 milestone, but Tim would have a better idea about how pressing it is for internal teams.
,
Sep 14
amalova@ do you want to take this (since you've uploaded http://crrev/c/1225874)?
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c3cd553d6401aa479cdaa32913a3f5d3e883933 commit 4c3cd553d6401aa479cdaa32913a3f5d3e883933 Author: First-name Last-name <amalova@google.com> Date: Tue Sep 25 14:22:37 2018 [WebView Support Library] Support TracingController API. Add boundary interface and support lib glue for TracingController. Introduce a new class which adapts common code between framework and support library API and forward calls to the Chromium internal implementation of TracingController. Bug: 821792 Change-Id: I032cb57d61c5bd2fc8012e4d3f85f68ce22742d0 Reviewed-on: https://chromium-review.googlesource.com/1225874 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593921} [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/glue/BUILD.gn [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/glue/java/src/com/android/webview/chromium/GlueApiHelperForP.java [add] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/glue/java/src/com/android/webview/chromium/SharedTracingControllerAdapter.java [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/glue/java/src/com/android/webview/chromium/TracingControllerAdapter.java [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/support_library/BUILD.gn [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/support_library/boundary_interfaces/BUILD.gn [add] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/TracingControllerBoundaryInterface.java [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebViewProviderFactoryBoundaryInterface.java [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java [add] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibTracingControllerAdapter.java [modify] https://crrev.com/4c3cd553d6401aa479cdaa32913a3f5d3e883933/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
,
Sep 26
Are we targeting this to any specific milestone (before it was M69)? If so, we need add the milestone, so it would be easy for tracking.
,
Sep 26
,
Nov 23
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gsennton@chromium.org
, May 31 2018Status: Available (was: Assigned)