Issue metadata
Sign in to add a comment
|
1%-5% regression in system_health.memory_desktop at 539412:541841 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 14 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12c99fce440000
,
Mar 15 2018
📍 Found significant differences after each of 16 commits. https://pinpoint-dot-chromeperf.appspot.com/job/12c99fce440000 Move exception handler table into instruction stream. by mstarzinger@chromium.org https://chromium.googlesource.com/v8/v8/+/fafd1cdd358f21edb2dfabb642a0dd3288abaa11 Add the LaunchUninstallFlow() function by pmonette@chromium.org https://chromium.googlesource.com/chromium/src/+/5e06564abe4c3b49a41b35f9379df9f6106c4cc1 Revert "Add the LaunchUninstallFlow() function" by chengx@chromium.org https://chromium.googlesource.com/chromium/src/+/2738eadb5789ae74a10df971c94bee5de3a47dcc [runtime] Move validity cell from PrototypeInfo to Map. by ishell@chromium.org https://chromium.googlesource.com/v8/v8/+/40a3e6dcb9bdb5cb2a7f6e29fa8e4de75e538ef6 Reland "[parser] Remove pretenuring of closures assigned to properties" by adamk@chromium.org https://chromium.googlesource.com/v8/v8/+/3d7ad2e7e53d3cd6add51512580c054abf7e5805 [runtime] Always store the name in a function's ScopeInfo by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/01488b9c4f1b4c8e2b66494b24d7e7ff8a826860 [bigint] Make MSan happy: zero-initialize unused bits by jkummerow@chromium.org https://chromium.googlesource.com/v8/v8/+/824358f07bacb4a4d5d58defbae8490cfa0fa85c [bigint] Fix throwing in Exponentiate() by jkummerow@chromium.org https://chromium.googlesource.com/v8/v8/+/62d1f78245b552ce7cb806de15d35ff29c867647 Roll V8 back to 6.6.346. by grt@chromium.org https://chromium.googlesource.com/chromium/src/+/1808b6997fe1e50153125f054a6589863733b5bf [runtime] Move validity cell from PrototypeInfo to Map. by ishell@chromium.org https://chromium.googlesource.com/v8/v8/+/40a3e6dcb9bdb5cb2a7f6e29fa8e4de75e538ef6 Reland "[parser] Remove pretenuring of closures assigned to properties" by adamk@chromium.org https://chromium.googlesource.com/v8/v8/+/3d7ad2e7e53d3cd6add51512580c054abf7e5805 [runtime] Always store the name in a function's ScopeInfo by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/01488b9c4f1b4c8e2b66494b24d7e7ff8a826860 [ic] Introduce new IC for storing into array literals. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/2e2860f74f9c610d5ffb3ee1778d937055d25dea [builtins] Enable embedded builtins and add testing variants by jgruber@chromium.org https://chromium.googlesource.com/v8/v8/+/abcc28ced071faee637d5fd59d06cfdf80d8ea3f [interpreter] Only create spread-related feedback slots when necessary. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/cf8cd1c444e7975211915fc77c52fe3c66876f78 [es2015] Refactor the JSArrayIterator. by bmeurer@chromium.org https://chromium.googlesource.com/v8/v8/+/06ee127b75726f9ee541aab10f6aecfe4d96675a Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 15 2018
Pinpoint results seem to point at Reland "[parser] Remove pretenuring of closures assigned to properties" by adamk@chromium.org
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/5cf2ae5a4d7224198a0474eb27cc618b6843bc32 commit 5cf2ae5a4d7224198a0474eb27cc618b6843bc32 Author: Adam Klein <adamk@chromium.org> Date: Mon Mar 26 19:09:22 2018 Revert "Reland "[parser] Remove pretenuring of closures assigned to properties"" This reverts commit 3d7ad2e7e53d3cd6add51512580c054abf7e5805. Reason for revert: too many regressions to handle for now. Original change's description: > Reland "[parser] Remove pretenuring of closures assigned to properties" > > The memory gains were significant, so despite the bluebird-doxbee > regression, we think it's better to have this patch than not. > See the attached Chromium bug for more discussion. > > This is a reland of 20e346bd08591caff2f7c45de762ca4d4e3f72c8. > > Original change's description: > > [parser] Remove pretenuring of closures assigned to properties > > > > This pretenuring was added in https://codereview.chromium.org/5220007, > > back when it was necessary in order to allow use of the closure > > as a "constant function" property. This should no longer be the case, > > and the pretenuring causes some unfortunate downstream effects. > > > > This patch removes the parser's setting of this bit. If it doesn't > > cause regressions on the perf bots, followup CLs will remove the > > rest of the support for this feature. > > > > Bug: v8:7442 > > Change-Id: I27c43dd4293ce5de921be6c78571e712778d138a > > Reviewed-on: https://chromium-review.googlesource.com/914610 > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Commit-Queue: Adam Klein <adamk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#51254} > > Bug: v8:7442 , chromium:814182 > Change-Id: I228c59dccef3844803f115749e72ae6c5f286eda > Reviewed-on: https://chromium-review.googlesource.com/938241 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51668} Tbr: gsathya@chromium.org Bug: v8:7442 , v8:7524 , chromium:814182 , chromium:818627 , chromium:818672 , chromium:819994 , chromium:821788 Change-Id: Ib760d63f879613f3b874889c5cb29ba2a77ba430 Reviewed-on: https://chromium-review.googlesource.com/980795 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52233} [modify] https://crrev.com/5cf2ae5a4d7224198a0474eb27cc618b6843bc32/src/parsing/parser-base.h [modify] https://crrev.com/5cf2ae5a4d7224198a0474eb27cc618b6843bc32/src/parsing/parser.h [modify] https://crrev.com/5cf2ae5a4d7224198a0474eb27cc618b6843bc32/src/parsing/preparser.h
,
Mar 27 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 14 2018