New issue
Advanced search Search tips

Issue 821780 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

style-sheet-interfaces-001.html uses assert_readonly on |media|

Project Member Reported by cnardi@chromium.org, Mar 14 2018

Issue description

See https://w3c-test.org/css/cssom/style-sheet-interfaces-001.html; this works fine in stable (65) and fails in dev (66) so it regressed somewhere in there.
 

Comment 1 by cnardi@chromium.org, Mar 14 2018

Labels: Hotlist-Interop
Status: Started (was: Assigned)
Summary: style-sheet-interfaces-001.html uses assert_readonly on |media| (was: CSSOM initial serialization of media item is "alla")
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e692a41dc7ea371fb7efa687b2469d1b420a444

commit 8e692a41dc7ea371fb7efa687b2469d1b420a444
Author: Chris Nardi <cnardi@chromium.org>
Date: Mon Apr 02 16:55:41 2018

Remove test that CSSStyleSheet.media is read-only

style-sheet-interfaces-001.html tested that styleSheet.media was
read-only, but the spec changed to add a [PutForwards] attribute to
|media|, meanining that the attribute is no longer truly read-only.
assert_readonly can have side-effects if the property has a
[PutForwards] attribute, so remove this check, as it was causing the
next test to fail.

Bug:  821780 
Change-Id: I77bee2f11484f6e679e4aee6b0641179c686d1d3
Reviewed-on: https://chromium-review.googlesource.com/989407
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547451}
[delete] https://crrev.com/a4e84198827b69216c1e0910b79427b6a60cee20/third_party/WebKit/LayoutTests/external/wpt/css/cssom/style-sheet-interfaces-001-expected.txt
[modify] https://crrev.com/8e692a41dc7ea371fb7efa687b2469d1b420a444/third_party/WebKit/LayoutTests/external/wpt/css/cssom/style-sheet-interfaces-001.html

Status: Fixed (was: Started)

Sign in to add a comment