Issue metadata
Sign in to add a comment
|
11.6% regression in thread_times.key_silk_cases at 542622:542688 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 14 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14a4b81e440000
,
Mar 14 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14a4b81e440000 [Blink] Make PaintLayer::AncestorDependentCompositingInputs in-place by trchen@chromium.org https://chromium.googlesource.com/chromium/src/+/0d2f4351ca12d64119d1aed52faf538a852a12c0 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 15 2018
Issue 821775 has been merged into this issue.
,
Mar 19 2018
The graph has been discontinued for a while: https://chromeperf.appspot.com/report?sid=61010c6d4b0b938b0e5568bc5a05f0f347043f98b6b517f011d63afdcc08be5c Do you know what happened, Victor? I have a speculative fix, and I would like to verify it actually fix the regression with graphs to support it. Thanks!
,
Mar 20 2018
Could it have been this bug?: https://bugs.chromium.org/p/chromium/issues/detail?id=823315 (also seems to have come back now)
,
Mar 20 2018
Yes, I think hjd@ is right. Some thread renaming broke this measurement, but it is back now.
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28f75e04b5a1091303e3bddd9621ee04df91ac4d commit 28f75e04b5a1091303e3bddd9621ee04df91ac4d Author: Tien-Ren Chen <trchen@chromium.org> Date: Mon Mar 26 23:15:31 2018 [Blink] Make PaintLayer::AncestorDependentCompositingInput external again A previous CL https://chromium.googlesource.com/chromium/src/+/0d2f4351ca12d64119d1aed52faf538a852a12c0 embedded the structure to PaintLayer itself, in order to avoid the cost of heap allocation. However that regressed transform animation with lots of layers on a number of Android devices. It is speculated that the increase in PaintLayer size put more pressure on L2 cache. This CL changes the structure back to external again. Note that this is not equivalent to reverting the previous CL. Before the regressed CL, the structure is reallocated everytime we updated it. With this CL applied, it will become a lazy rare data that will be allocated on first use, but then reused throughout PaintLayer's lifetime. BUG= 821773 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia65b8dba8c4d07eed22aed9903a57472ad06960f Reviewed-on: https://chromium-review.googlesource.com/974282 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545882} [modify] https://crrev.com/28f75e04b5a1091303e3bddd9621ee04df91ac4d/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/28f75e04b5a1091303e3bddd9621ee04df91ac4d/third_party/WebKit/Source/core/paint/PaintLayer.h
,
Mar 27 2018
The nexus5x graph showed that we recovered much of the regression. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 14 2018