The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d85f41294db36d1c5e04dff411678fbbe339ab0

commit 8d85f41294db36d1c5e04dff411678fbbe339ab0
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Mon Mar 19 20:50:48 2018

[bluetooth] CleanUp BluetoothDeviceWin Interface

This change removes the unused NetLog and NetLogSource from
BluetoothDeviceWin and adds a few missing #includes.

Bug:  821766 
Change-Id: I74e0f888398ced801072f25e8d90a8e338dc8e79
Reviewed-on: https://chromium-review.googlesource.com/968513
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544152}
[modify] https://crrev.com/8d85f41294db36d1c5e04dff411678fbbe339ab0/device/bluetooth/bluetooth_adapter_win.cc
[modify] https://crrev.com/8d85f41294db36d1c5e04dff411678fbbe339ab0/device/bluetooth/bluetooth_device_win.cc
[modify] https://crrev.com/8d85f41294db36d1c5e04dff411678fbbe339ab0/device/bluetooth/bluetooth_device_win.h
[modify] https://crrev.com/8d85f41294db36d1c5e04dff411678fbbe339ab0/device/bluetooth/bluetooth_device_win_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd89eb6fdea027dcd1a610e433bccd4386ade5e3

commit bd89eb6fdea027dcd1a610e433bccd4386ade5e3
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Mar 22 08:50:21 2018

[bluetooth] Fix GattServicesDiscovered on Win

This change fixes GattServicesDiscovered on Windows to only be called
once all services, characteristics and descriptors are discovered.
Furthermore it removes the deprecated GattDiscoveryCompleteForService
notification.

Bug:  507419 ,  821766 
Change-Id: I234409cb159a022e0443b8c2d2a4b1c90fac9b15
Reviewed-on: https://chromium-review.googlesource.com/850357
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545016}
[modify] https://crrev.com/bd89eb6fdea027dcd1a610e433bccd4386ade5e3/device/bluetooth/bluetooth_remote_gatt_service_win.cc
[modify] https://crrev.com/bd89eb6fdea027dcd1a610e433bccd4386ade5e3/device/bluetooth/bluetooth_remote_gatt_service_win.h

Jan, do you think this is still feasible for M68?

Yes, I believe so. M-67 is likely not possible, but M-68 should be do-able.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdbea2ac86c63bace4dd852b1cd4065f42542e6d

commit cdbea2ac86c63bace4dd852b1cd4065f42542e6d
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed Apr 18 15:38:18 2018

[bluetooth] Run DiscoverySessionErrorCallback Once

This change changes BluetoothAdapter::DiscoverySessionErrorCallback from
base::Callback to base::OnceCallback. Furthermore, it updates relevant
methods to pass it by value and to std::move instances of the callback.

Bug:  821766 , 834319

Change-Id: Ibac2304c7540f2e9d80069ff19abb36ccbbd5527
Reviewed-on: https://chromium-review.googlesource.com/1013944
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551686}
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter_android.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter_android.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter_mac.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter_win.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter_win.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluetooth_adapter_win_unittest.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/bluez/bluetooth_adapter_bluez.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/cast/bluetooth_adapter_cast.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/cast/bluetooth_adapter_cast.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/dbus/bluetooth_adapter_client.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/dbus/bluetooth_adapter_client.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/dbus/fake_bluetooth_adapter_client.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/dbus/fake_bluetooth_adapter_client.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/test/mock_bluetooth_adapter.cc
[modify] https://crrev.com/cdbea2ac86c63bace4dd852b1cd4065f42542e6d/device/bluetooth/test/mock_bluetooth_adapter.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4a2c85fd78a47feabcf78284f2f1111fd37d06a

commit e4a2c85fd78a47feabcf78284f2f1111fd37d06a
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed Apr 18 20:41:01 2018

[base] Provide IAsyncOperation Implementation

This change implements Windows::Foundation::IAsyncOperation. It provides
a simple interface and allows clients to specify desired results via a
callback.

This is mostly useful for tests, when custom fake implementations of
UWP interfaces are required. Some of these implementations must provide
Async methods, that return an instantiation of IAsyncOperation.

Bug:  821766 
Change-Id: I728c0bb5311898fac4ee5f5e54d8a64b2aa61d94
Reviewed-on: https://chromium-review.googlesource.com/984194
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551811}
[modify] https://crrev.com/e4a2c85fd78a47feabcf78284f2f1111fd37d06a/base/BUILD.gn
[add] https://crrev.com/e4a2c85fd78a47feabcf78284f2f1111fd37d06a/base/win/async_operation.h
[add] https://crrev.com/e4a2c85fd78a47feabcf78284f2f1111fd37d06a/base/win/async_operation_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2c472c41c1ceb5771d9ed939333a060b6c07295

commit a2c472c41c1ceb5771d9ed939333a060b6c07295
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Tue May 08 08:08:25 2018

[bluetooth] Add Feature Flag for WinRT BLE

This change adds a base::Feature for the BLE implementation using WinRT
UWP APIs.

Bug: 579202,  821766 
Change-Id: I94d64ce60aff2286b0bcaf98e01b68b44db9bf43
Reviewed-on: https://chromium-review.googlesource.com/1046545
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556720}
[modify] https://crrev.com/a2c472c41c1ceb5771d9ed939333a060b6c07295/device/base/features.cc
[modify] https://crrev.com/a2c472c41c1ceb5771d9ed939333a060b6c07295/device/base/features.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35e6711e43eacfbb5873c149af44fbbb9572f8a8

commit 35e6711e43eacfbb5873c149af44fbbb9572f8a8
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Tue May 08 10:35:05 2018

[bluetooth] Introduce BluetoothAdapterWinrt

This change introduces BluetoothAdapterWinrt, which will contain an
adapter implementation using Mirosoft UWP BLE APIs. This change merely
provides a skeleton, where each member function is NOTIMPLEMENTED().
Further functionality will be provided in future CLs.

Bug: 579202,  821766 
Change-Id: I207e14de292f9d24b7d16710437e0dae839c82ec
Reviewed-on: https://chromium-review.googlesource.com/1046589
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556748}
[modify] https://crrev.com/35e6711e43eacfbb5873c149af44fbbb9572f8a8/device/bluetooth/BUILD.gn
[modify] https://crrev.com/35e6711e43eacfbb5873c149af44fbbb9572f8a8/device/bluetooth/bluetooth_adapter_unittest.cc
[add] https://crrev.com/35e6711e43eacfbb5873c149af44fbbb9572f8a8/device/bluetooth/bluetooth_adapter_winrt.cc
[add] https://crrev.com/35e6711e43eacfbb5873c149af44fbbb9572f8a8/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/35e6711e43eacfbb5873c149af44fbbb9572f8a8/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/35e6711e43eacfbb5873c149af44fbbb9572f8a8/device/bluetooth/test/bluetooth_test_win.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73f3b634e497d8fecb588a35be3efd42db978f13

commit 73f3b634e497d8fecb588a35be3efd42db978f13
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Tue May 08 16:01:50 2018

[bluetooth] Introduce BluetoothDeviceWinrt

This change introduces a skeleton for BluetoothDeviceWinrt. All of its
methods are NOTIMPLEMENTED, and no code creates an instance of it.
Further functionality will be added in future CLs.

Bug:  507419 ,  821766 
Change-Id: Ieafdad50ff3404239c0c2bb71c00e625b8a433fc
Reviewed-on: https://chromium-review.googlesource.com/1046654
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556812}
[modify] https://crrev.com/73f3b634e497d8fecb588a35be3efd42db978f13/device/bluetooth/BUILD.gn
[add] https://crrev.com/73f3b634e497d8fecb588a35be3efd42db978f13/device/bluetooth/bluetooth_device_winrt.cc
[add] https://crrev.com/73f3b634e497d8fecb588a35be3efd42db978f13/device/bluetooth/bluetooth_device_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5

commit cc0bd295f53605bffa6a69e42819fa2da7a8c7b5
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Mon May 14 12:28:28 2018

[bluetooth] Get Default WinRT Bluetooth Adapter

This change implements talking to the UWP APIs to obtain an instance of
the system's default adapter. Furthermore, it introduces logic to obtain
the adapter's address and name. Lastly, it also provides necessary test
framework to integrate with the existing BluetoothAdapter unittests.

Bug:  507419 ,  821766 
Change-Id: I1235d441fd8708e6280d1eecbed45afdc6c42a11
Reviewed-on: https://chromium-review.googlesource.com/973620
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558267}
[modify] https://crrev.com/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5/device/BUILD.gn
[modify] https://crrev.com/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5/device/bluetooth/test/bluetooth_test_win.h
[add] https://crrev.com/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5/device/bluetooth/test/fake_bluetooth_adapter_winrt.cc
[add] https://crrev.com/cc0bd295f53605bffa6a69e42819fa2da7a8c7b5/device/bluetooth/test/fake_bluetooth_adapter_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07e67cc7ed7a9784f450efac3bddc8213efc49dd

commit 07e67cc7ed7a9784f450efac3bddc8213efc49dd
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed May 16 18:59:52 2018

[base] Provide ITypedEventHandler Implementation

This change provides an implementation of Windows::Foundation's
ITypedEventHandlder. It serves as a thin wrapper around a
base::RepeatingCallback of the appropriate signature.

Bug:  821766 
Change-Id: Ib940ebc5a4d90e5304be2c08839efbc020011180
Reviewed-on: https://chromium-review.googlesource.com/1060054
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559212}
[modify] https://crrev.com/07e67cc7ed7a9784f450efac3bddc8213efc49dd/base/BUILD.gn
[add] https://crrev.com/07e67cc7ed7a9784f450efac3bddc8213efc49dd/base/win/typed_event_handler.h
[add] https://crrev.com/07e67cc7ed7a9784f450efac3bddc8213efc49dd/base/win/typed_event_handler_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f82110c6df6c8984f0c41c91c9676b619c3fff1

commit 4f82110c6df6c8984f0c41c91c9676b619c3fff1
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Fri May 18 17:48:24 2018

[bluetooth] Enable using BluetoothAdapterWinrt in Production

This change enables using the new BluetoothAdapterWinrt in production
code. As this interface is still WIP, this is gated behind a feature
flag. Furthermore this change does minor clean-ups in BluetoothTestWin.

Bug:  821766 
Change-Id: Id48141d08a4cb3aa2908ce550444ebcc7e62b278
Reviewed-on: https://chromium-review.googlesource.com/1061530
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559949}
[modify] https://crrev.com/4f82110c6df6c8984f0c41c91c9676b619c3fff1/device/bluetooth/bluetooth_adapter_win.cc
[modify] https://crrev.com/4f82110c6df6c8984f0c41c91c9676b619c3fff1/device/bluetooth/bluetooth_adapter_win.h
[modify] https://crrev.com/4f82110c6df6c8984f0c41c91c9676b619c3fff1/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/4f82110c6df6c8984f0c41c91c9676b619c3fff1/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/4f82110c6df6c8984f0c41c91c9676b619c3fff1/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/4f82110c6df6c8984f0c41c91c9676b619c3fff1/device/bluetooth/test/bluetooth_test_win.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4dc778de21c0585c815ccf469c40196317c4be2

commit d4dc778de21c0585c815ccf469c40196317c4be2
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Jun 04 09:38:13 2018

[bluetooth] Add Winrt Fakes for LE Advertisements

This change adds empty fake implementations for WinRT LE Advertisements.
These fakes will be required in an upcoming CL that implements listening
to LE Advertisements for Winrt. So far, these are merely stubs and don't
provide any functionality.

Bug:  821766 
Change-Id: Icf98eacb0f3cf6085c3031b12ca7282c98f1f46e
Reviewed-on: https://chromium-review.googlesource.com/1066060
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564035}
[modify] https://crrev.com/d4dc778de21c0585c815ccf469c40196317c4be2/device/BUILD.gn
[add] https://crrev.com/d4dc778de21c0585c815ccf469c40196317c4be2/device/bluetooth/test/fake_bluetooth_le_advertisement_received_event_args_winrt.cc
[add] https://crrev.com/d4dc778de21c0585c815ccf469c40196317c4be2/device/bluetooth/test/fake_bluetooth_le_advertisement_received_event_args_winrt.h
[add] https://crrev.com/d4dc778de21c0585c815ccf469c40196317c4be2/device/bluetooth/test/fake_bluetooth_le_advertisement_watcher_winrt.cc
[add] https://crrev.com/d4dc778de21c0585c815ccf469c40196317c4be2/device/bluetooth/test/fake_bluetooth_le_advertisement_watcher_winrt.h
[add] https://crrev.com/d4dc778de21c0585c815ccf469c40196317c4be2/device/bluetooth/test/fake_bluetooth_le_advertisement_winrt.cc
[add] https://crrev.com/d4dc778de21c0585c815ccf469c40196317c4be2/device/bluetooth/test/fake_bluetooth_le_advertisement_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/222296734f928c131bd283e634d59945fd6857aa

commit 222296734f928c131bd283e634d59945fd6857aa
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Sat Jun 09 05:40:00 2018

[base] Implement IVector

This change provides implementations for the IVector WinRT interface.
Vector is a thin wrapper around a std::vector, and also implements the
IObservableVector interface.

Bug:  821766 
Change-Id: I2e81b843d87e53f023b659a07af46d2752a65cc9
Reviewed-on: https://chromium-review.googlesource.com/1059784
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565865}
[modify] https://crrev.com/222296734f928c131bd283e634d59945fd6857aa/base/BUILD.gn
[add] https://crrev.com/222296734f928c131bd283e634d59945fd6857aa/base/win/vector.cc
[add] https://crrev.com/222296734f928c131bd283e634d59945fd6857aa/base/win/vector.h
[add] https://crrev.com/222296734f928c131bd283e634d59945fd6857aa/base/win/vector_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23cbf4c32c3b0d1b303e183de1c14938fe886f0a

commit 23cbf4c32c3b0d1b303e183de1c14938fe886f0a
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Jun 11 18:14:11 2018

[bluetooth] Introduce BluetoothDeviceWinrt

This change implements device discovery in BluetoothAdapterWinrt and
adds the BluetoothDeviceWinrt class.

Bug:  821766 
Change-Id: I1ecc4c84a49f2a5b2977ed23689c6a405c74ede5
Reviewed-on: https://chromium-review.googlesource.com/1027880
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566060}
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_device_winrt.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_device_winrt.h
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_uuid.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_uuid.h
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/bluetooth_uuid_unittest.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/fake_bluetooth_adapter_winrt.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/fake_bluetooth_adapter_winrt.h
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/fake_bluetooth_le_advertisement_received_event_args_winrt.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/fake_bluetooth_le_advertisement_received_event_args_winrt.h
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/fake_bluetooth_le_advertisement_watcher_winrt.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/fake_bluetooth_le_advertisement_watcher_winrt.h
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/fake_bluetooth_le_advertisement_winrt.cc
[modify] https://crrev.com/23cbf4c32c3b0d1b303e183de1c14938fe886f0a/device/bluetooth/test/fake_bluetooth_le_advertisement_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e2fa88b939e81f5aa031a2c7711c2f3cc996ae1

commit 0e2fa88b939e81f5aa031a2c7711c2f3cc996ae1
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Tue Jun 12 02:13:59 2018

[bluetooth] Introduce WinRT Event Utils

This change moves PostAsyncResults and AddTypedEventHandler from the
anonymous namespace of BluetoothAdapterWinrt into a more central
location. Furthermore, it introduces changes to guarantee that ComPtrs
are only dereferenced in the correct COM apartments.

Bug:  821766 
Change-Id: I07b2fd7d23f9174952203864dcb872f4a273c1c4
Reviewed-on: https://chromium-review.googlesource.com/1091659
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566274}
[modify] https://crrev.com/0e2fa88b939e81f5aa031a2c7711c2f3cc996ae1/device/bluetooth/BUILD.gn
[modify] https://crrev.com/0e2fa88b939e81f5aa031a2c7711c2f3cc996ae1/device/bluetooth/bluetooth_adapter_winrt.cc
[add] https://crrev.com/0e2fa88b939e81f5aa031a2c7711c2f3cc996ae1/device/bluetooth/event_utils_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc7c81c7ad36862d69efe101508b5006ffc899f6

commit dc7c81c7ad36862d69efe101508b5006ffc899f6
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Tue Jun 12 07:34:38 2018

[bluetooth] Implement IsPowered and SetPowered for WinRT

This change implements IsPowered() and SetPowered() for WinRT Bluetooth
Adapters using the UWP API. While this API is not yet available when
running x86 binaries on an x64 system, it works fine for x64 binaries.

Bug:  821766 
Change-Id: I7e3cbc30a610d1cf9caea55f2a5feb42725f5a5c
Reviewed-on: https://chromium-review.googlesource.com/1085907
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566352}
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/BUILD.gn
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/test/fake_bluetooth_adapter_winrt.cc
[modify] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/test/fake_bluetooth_adapter_winrt.h
[add] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/test/fake_radio_winrt.cc
[add] https://crrev.com/dc7c81c7ad36862d69efe101508b5006ffc899f6/device/bluetooth/test/fake_radio_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce567f0154deea317a6ebb16ae75f794e0b15aca

commit ce567f0154deea317a6ebb16ae75f794e0b15aca
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Jun 13 23:39:46 2018

[bluetooth] Unify SimulateLowEnergyDevice for BlueZ and Win

This change aims to reduce code duplication in the implementations of
BluetoothTest::SimulateLowEnergyDevice for BlueZ and Windows. In order
to do so it adds a utility struct and method to BluetoothTestBase, that
implementations of SimulateLowEnergyDevice make use of.

Bug:  821766 
Change-Id: I5283a1eb55e50d68dce2c9810994cf6c4ed80212
Reviewed-on: https://chromium-review.googlesource.com/1096675
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567047}
[modify] https://crrev.com/ce567f0154deea317a6ebb16ae75f794e0b15aca/device/bluetooth/test/bluetooth_test.cc
[modify] https://crrev.com/ce567f0154deea317a6ebb16ae75f794e0b15aca/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/ce567f0154deea317a6ebb16ae75f794e0b15aca/device/bluetooth/test/bluetooth_test_bluez.cc
[modify] https://crrev.com/ce567f0154deea317a6ebb16ae75f794e0b15aca/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/ce567f0154deea317a6ebb16ae75f794e0b15aca/device/bluetooth/test/bluetooth_test_win.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d

commit d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Mon Jun 18 17:35:43 2018

[bluetooth] Skeletons for WinRT GATT Service Discovery

This change adds class skeletons required for the implementation and
testing of GATT service discovery on WinRT. No functionality is added,
this CL is simply meant to reduce the size and boilerplate of the
following change.

Bug:  821766 
Change-Id: Ie20629235f08dff9e5ffcb38273cc8ddb2a8e5e0
Reviewed-on: https://chromium-review.googlesource.com/1102023
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568056}
[modify] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/BUILD.gn
[modify] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/BUILD.gn
[add] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[add] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/bluetooth_remote_gatt_service_winrt.h
[add] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[add] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[add] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[add] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/test/fake_gatt_device_service_winrt.h
[add] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/test/fake_gatt_device_services_result_winrt.cc
[add] https://crrev.com/d9b78b9aa5e44a8f4b21d8f2d2fc1e22fc9a215d/device/bluetooth/test/fake_gatt_device_services_result_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c19d0eaab57c8c103c5e82a2586583b3fce3e4e

commit 3c19d0eaab57c8c103c5e82a2586583b3fce3e4e
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed Jun 20 07:44:50 2018

[base] Simplify IAsyncOperation Implementation

This change simplifies base/win/async_operation.h by deduplicating logic
and flattening the class hierarchy. This is possible by introducing two
compile time switches, that pick the correct storage and result type
depending on the provided template instantiation.

Bug:  821766 
Change-Id: Ia04dc4cdbc42a4005204491cc47650d35f413cdb
Reviewed-on: https://chromium-review.googlesource.com/1106382
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568758}
[modify] https://crrev.com/3c19d0eaab57c8c103c5e82a2586583b3fce3e4e/base/win/async_operation.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc599fc69e7a33eaa31046bede174e68b7b2ce7d

commit dc599fc69e7a33eaa31046bede174e68b7b2ce7d
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed Jun 20 16:45:21 2018

[base] Implement Windows::Foundation::IReference

This change provides an implementation of Windows::Foundation's
IReference interface. This class is supposed to be used for optional
POD types, as a null value usually is not possible here.

Bug:  821766 
Change-Id: Icc6ff4f5313e2cfa13ca33f8d54e150efa616d76
Reviewed-on: https://chromium-review.googlesource.com/1106385
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568877}
[modify] https://crrev.com/dc599fc69e7a33eaa31046bede174e68b7b2ce7d/base/BUILD.gn
[add] https://crrev.com/dc599fc69e7a33eaa31046bede174e68b7b2ce7d/base/win/reference.h
[add] https://crrev.com/dc599fc69e7a33eaa31046bede174e68b7b2ce7d/base/win/reference_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce8d3b30d669404e39f59e18a3bc61b3ced29374

commit ce8d3b30d669404e39f59e18a3bc61b3ced29374
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Jun 28 16:24:49 2018

[bluetooth] Implement GATT Connections for WinRT

This change implements initiating GATT connections for WinRT. While
currently no GATT discovery is attempted, this will be provided in a
future CL. GATT connections are created by obtaining an instance of
BluetoothLEDevice.

Bug:  821766 
Change-Id: I7f20127a84b781859300af18b31da0e9ee24a32b
Reviewed-on: https://chromium-review.googlesource.com/1090217
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571156}
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/bluetooth_device_winrt.cc
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/bluetooth_device_winrt.h
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/test/fake_gatt_device_services_result_winrt.cc
[modify] https://crrev.com/ce8d3b30d669404e39f59e18a3bc61b3ced29374/device/bluetooth/test/fake_gatt_device_services_result_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce19c6d80b6c7b601a55f55acbad78b0bc20bed7

commit ce19c6d80b6c7b601a55f55acbad78b0bc20bed7
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Jul 03 09:42:51 2018

[base] Use ComPtrs in base::win::Vector

This change modifies base::win::Vector to use ComPtrs in the backing
storage for types derived from IUnknown.

Bug:  821766 
Change-Id: Ib531a3e3c15e8cae1ec94de3f11b36d01b7a5acf
Reviewed-on: https://chromium-review.googlesource.com/1120337
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572160}
[modify] https://crrev.com/ce19c6d80b6c7b601a55f55acbad78b0bc20bed7/base/win/vector.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d9a1a66ab75149bbdf9f2a40729c852b96a6097

commit 5d9a1a66ab75149bbdf9f2a40729c852b96a6097
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Jul 05 17:55:32 2018

[bluetooth] Implement obtaining GATT Services for WinRT

This change implements GATT Service discovery for WinRT. It does
so by instantiating a BluetoothGattDiscoverer, which reports
back to the BluetoothDevice once it is done. Follow-up CLs will
implement discovery of Characteristics and Descriptors.

Bug:  821766 
Change-Id: If7bcbdda8b27e0983d44a1c16367d3c5969c1831
Reviewed-on: https://chromium-review.googlesource.com/1103571
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572826}
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/BUILD.gn
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_device_winrt.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_device_winrt.h
[add] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[add] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_remote_gatt_service_winrt.h
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_uuid.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_uuid.h
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/bluetooth_uuid_unittest.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/event_utils_winrt.h
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/test/fake_gatt_device_service_winrt.h
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/test/fake_gatt_device_services_result_winrt.cc
[modify] https://crrev.com/5d9a1a66ab75149bbdf9f2a40729c852b96a6097/device/bluetooth/test/fake_gatt_device_services_result_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d66e0a92a5889a06a612b9fab6415e672417903d

commit d66e0a92a5889a06a612b9fab6415e672417903d
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Sat Jul 07 10:48:19 2018

[bluetooth] Add WinRT Skeletons for GATT Characteristics

Similarly to r568056 this change adds skeletons required for the
implementation and testing of GATT Characteristic discovery on WinRT.
No functionality is added, this will follow in a future CL.

Bug:  821766 
Change-Id: I68ea08d15036159fedb75cc322ccaabe833aff02
Reviewed-on: https://chromium-review.googlesource.com/1127945
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573161}
[modify] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/BUILD.gn
[modify] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/BUILD.gn
[add] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[add] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[add] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[add] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[add] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/test/fake_gatt_characteristics_result_winrt.cc
[add] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/test/fake_gatt_characteristics_result_winrt.h
[modify] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/d66e0a92a5889a06a612b9fab6415e672417903d/device/bluetooth/test/fake_gatt_device_service_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6971f08006c58729a9ac82aa246ba0ea33322a3

commit c6971f08006c58729a9ac82aa246ba0ea33322a3
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Jul 11 19:14:44 2018

[bluetooth] Make optional Advertisement Data base::Optionals

This change changes the signature of BluetoothDevice's
UpdateAdvertisementData to pass flags and rx power as base::Optionals
instead of nullptrs. Also it includes the clearing of advertisment flags
into BluetoothDevice::ClearAdvertisementData().

Bug:  821766 
Change-Id: Idcbc3ac38844d75c49ade5eff61013034ffbec38
Reviewed-on: https://chromium-review.googlesource.com/1129219
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574278}
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/chromeos/components/proximity_auth/bluetooth_low_energy_connection_finder_unittest.cc
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/device/bluetooth/bluetooth_adapter_android.cc
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/device/fido/fido_ble_device_unittest.cc
[modify] https://crrev.com/c6971f08006c58729a9ac82aa246ba0ea33322a3/device/fido/fido_cable_discovery_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efd642e61e6933f8e78a607f02b2478652547e92

commit efd642e61e6933f8e78a607f02b2478652547e92
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Jul 12 13:43:27 2018

[bluetooth] Move Map of Characteristics in Gatt Service

This change cleans up BluetoothRemoteGattService and its implementations
by moving the map of characteristics into the base class. This allows
for less code duplication and a simplified interface. Furthermore, a
AddCharacterisitic helper method is introduced.

Bug:  821766 
Change-Id: Ib370c599f1c8519d497a379c976c89c48d7ecb56
Reviewed-on: https://chromium-review.googlesource.com/1131178
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574552}
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service_android.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service_android.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service_mac.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service_mac.mm
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service_win.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service_win.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluetooth_remote_gatt_service_winrt.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/cast/bluetooth_remote_gatt_service_cast.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/cast/bluetooth_remote_gatt_service_cast.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/device_unittest.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/test/fake_remote_gatt_service.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/test/fake_remote_gatt_service.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/test/mock_bluetooth_gatt_service.cc
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/bluetooth/test/mock_bluetooth_gatt_service.h
[modify] https://crrev.com/efd642e61e6933f8e78a607f02b2478652547e92/device/fido/fido_ble_connection_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af

commit 2ccef118870e30bc4abb6c47fe0e20b81bf5c8af
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Jul 17 11:06:10 2018

[bluetooth] Move DescriptorMap in Base Class

Similarly to r574552 this change moves the map of descriptors from the
platform implementations to the BluetoothRemoteGattCharacteristic base
class. In addition, default implementations for GetDescriptor() and
GetDescriptors() are provided. Lastly, this change cleans up a few lint
errors, mostly missing includes.

Bug:  821766 
Change-Id: Iada71c198d241acf3bddcc1414ff89aa150c1c84
Reviewed-on: https://chromium-review.googlesource.com/1136296
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575603}
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic_android.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluetooth_remote_gatt_descriptor.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/cast/bluetooth_remote_gatt_characteristic_cast.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/cast/bluetooth_remote_gatt_characteristic_cast.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/test/fake_remote_gatt_characteristic.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/test/fake_remote_gatt_characteristic.h
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/test/mock_bluetooth_gatt_characteristic.cc
[modify] https://crrev.com/2ccef118870e30bc4abb6c47fe0e20b81bf5c8af/device/bluetooth/test/mock_bluetooth_gatt_characteristic.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c75765a755d7309f66fdc633df4422da1b5701dd

commit c75765a755d7309f66fdc633df4422da1b5701dd
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Fri Jul 20 11:36:18 2018

[bluetooth] WinRT: Extract remaining Advertising Data

This change implements extracting remaining Advertising Data for WinRT.

This includes the following data:
- Advertising Data Flags
- Tx Power
- Service Data
- Manufacturer Data

For tx power and Service Data Windows does not provide specialized
platform APIs and the raw advertising data sections need to be parsed.

Bug:  821766 , 661814

Change-Id: Ic5f60ce5ee866c4ac130084f9b404f038d5e0886
Reviewed-on: https://chromium-review.googlesource.com/1103574
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576829}
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/BUILD.gn
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/bluetooth_device_winrt.h
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/bluetooth_test.cc
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/bluetooth_test_win.cc
[add] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_advertisement_data_section_winrt.cc
[add] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_advertisement_data_section_winrt.h
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_advertisement_received_event_args_winrt.cc
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_advertisement_received_event_args_winrt.h
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_advertisement_watcher_winrt.cc
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_advertisement_watcher_winrt.h
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_advertisement_winrt.cc
[modify] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_advertisement_winrt.h
[add] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_manufacturer_data_winrt.cc
[add] https://crrev.com/c75765a755d7309f66fdc633df4422da1b5701dd/device/bluetooth/test/fake_bluetooth_le_manufacturer_data_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1568d039155f062ae4427d4506ba98fb304268c0

commit 1568d039155f062ae4427d4506ba98fb304268c0
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Jul 27 14:24:16 2018

[bluetooth] Discover Characteristics for WinRT

This implements the discovery of BluetoothRemoteGattCharacteristics for
WinRT.

Bug:  821766 
Change-Id: Iba0cbe9f7bae4d5a4403bd12193077ad57358387
Reviewed-on: https://chromium-review.googlesource.com/1136310
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578631}
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_device_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/bluetooth_remote_gatt_service_winrt.h
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_gatt_characteristics_result_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_gatt_characteristics_result_winrt.h
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_gatt_device_service_winrt.h
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_gatt_device_services_result_winrt.cc
[modify] https://crrev.com/1568d039155f062ae4427d4506ba98fb304268c0/device/bluetooth/test/fake_gatt_device_services_result_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bd49eed07463d2e4e7864307eef261b82b519fa

commit 1bd49eed07463d2e4e7864307eef261b82b519fa
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Mon Jul 30 10:59:00 2018

[Bluetooth][WinRT] Implement Reading and Writing GATT Characteristics

This change implements ReadRemoteCharacteristic(),
WriteRemoteCharacteristic() and WriteWithoutResponse() for WinRT's
BluetoothRemoteGattCharacteristic. Furthermore, appropriate tests are
enabled.

Bug:  821766 
Change-Id: I7bb11038ad88beda8103b723f9a69ad91106d30a
Reviewed-on: https://chromium-review.googlesource.com/1151325
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579007}
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/BUILD.gn
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/fake_gatt_device_service_winrt.h
[add] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/fake_gatt_read_result_winrt.cc
[add] https://crrev.com/1bd49eed07463d2e4e7864307eef261b82b519fa/device/bluetooth/test/fake_gatt_read_result_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e068840a359d570a942c222812095383487c24cf

commit e068840a359d570a942c222812095383487c24cf
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Tue Jul 31 07:56:44 2018

[Bluetooth][WinRT] Perform Explicit Connection Check

This change contains a small fix to perform an explicit connection check
after receiving a BluetoothLEDevice instance. This is necessary for
paired devices, where the connection handler gets registered too late to
get notified of the initial GATT connection initiated by the OS.

Bug:  821766 
Change-Id: Ic022035f101324daa9a0772940740550e948e5fb
Reviewed-on: https://chromium-review.googlesource.com/1154920
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579338}
[modify] https://crrev.com/e068840a359d570a942c222812095383487c24cf/device/bluetooth/bluetooth_device_winrt.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9

commit 2a3e6c9dca8748d6c58323c4033e6df01aa92fc9
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Tue Jul 31 08:39:16 2018

[Bluetooth][WinRT] Add RemoteGattDescriptor Skeletons

Similarly to r568056 and 573161 this change adds skeletons required for
the implementation and testing of GATT Descriptor discovery on WinRT. No
functionality is added, this will follow in a future CL.

Bug:  821766 
Change-Id: Ib6cb238c97899c94f54fcf5146a5e36ede69b909
Reviewed-on: https://chromium-review.googlesource.com/1155119
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579348}
[modify] https://crrev.com/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9/device/BUILD.gn
[modify] https://crrev.com/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9/device/bluetooth/BUILD.gn
[add] https://crrev.com/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[add] https://crrev.com/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[add] https://crrev.com/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[add] https://crrev.com/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[add] https://crrev.com/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[add] https://crrev.com/2a3e6c9dca8748d6c58323c4033e6df01aa92fc9/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b008c40edcc970be2dd2c6ddf291f13570448d

commit f5b008c40edcc970be2dd2c6ddf291f13570448d
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed Aug 01 08:12:56 2018

[Bluetooth][WinRT] Finer Grained GATT Error Handling

This change implements more fine grained error handling for reading and
writing Gatt Characteristics on WinRT. Appropriate tests are enabled.

Bug:  821766 
Change-Id: If2d8eae67620122f3b0273d9d387790bec2f3ee8
Reviewed-on: https://chromium-review.googlesource.com/1154789
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579724}
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/BUILD.gn
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/bluetooth_remote_gatt_service_winrt.h
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/test/fake_gatt_read_result_winrt.cc
[modify] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/test/fake_gatt_read_result_winrt.h
[add] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/test/fake_gatt_write_result_winrt.cc
[add] https://crrev.com/f5b008c40edcc970be2dd2c6ddf291f13570448d/device/bluetooth/test/fake_gatt_write_result_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20f64257cc9c09b466c4ae3944dbc165f83a9ae8

commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed Aug 01 16:30:15 2018

[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors

This change implements obtainining Remote Gatt Descriptors for WinRT by
hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
appropriate tests are enabled.

Bug:  821766 
Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
Reviewed-on: https://chromium-review.googlesource.com/1156392
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579830}
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/20f64257cc9c09b466c4ae3944dbc165f83a9ae8/device/bluetooth/test/fake_gatt_device_service_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f61df6f91aee2f8073ee409ab2ed624cd390931a

commit f61df6f91aee2f8073ee409ab2ed624cd390931a
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed Aug 01 16:49:40 2018

[Bluetooth][WinRT] Implement Reading and Writing of Descriptors

This change implements reading and writing of Remote Gatt Descriptors
for WinRT. Furthermore, it enables corresponding tests.

Bug:  821766 
Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
Reviewed-on: https://chromium-review.googlesource.com/1156703
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579838}
[modify] https://crrev.com/f61df6f91aee2f8073ee409ab2ed624cd390931a/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/f61df6f91aee2f8073ee409ab2ed624cd390931a/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/f61df6f91aee2f8073ee409ab2ed624cd390931a/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/f61df6f91aee2f8073ee409ab2ed624cd390931a/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/f61df6f91aee2f8073ee409ab2ed624cd390931a/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/f61df6f91aee2f8073ee409ab2ed624cd390931a/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/f61df6f91aee2f8073ee409ab2ed624cd390931a/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/f61df6f91aee2f8073ee409ab2ed624cd390931a/device/bluetooth/test/fake_gatt_descriptor_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d01b7c9e8df0568084a589486949a54ca82e89f1

commit d01b7c9e8df0568084a589486949a54ca82e89f1
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Thu Aug 02 04:28:47 2018

Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"

This reverts commit f61df6f91aee2f8073ee409ab2ed624cd390931a.

Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change.

Sample builds:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235

failures:
BluetoothTestWinrtOnly.GattServices_ObserversCalls/0
BluetoothTestWinrt.GetPrimaryServices/1
BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1
BluetoothTestWinrt.GetPrimaryServicesByUUID/1
BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0
BluetoothTestWinrt.GetGattServices_and_GetGattService/1
BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1
BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0

Original change's description:
> [Bluetooth][WinRT] Implement Reading and Writing of Descriptors
> 
> This change implements reading and writing of Remote Gatt Descriptors
> for WinRT. Furthermore, it enables corresponding tests.
> 
> Bug:  821766 
> Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
> Reviewed-on: https://chromium-review.googlesource.com/1156703
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579838}

TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 
Reviewed-on: https://chromium-review.googlesource.com/1159961
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580062}
[modify] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/d01b7c9e8df0568084a589486949a54ca82e89f1/device/bluetooth/test/fake_gatt_descriptor_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67ca5a07611f7b375f58f822364ce294a2d8b5fc

commit 67ca5a07611f7b375f58f822364ce294a2d8b5fc
Author: Christos Froussios <cfroussios@chromium.org>
Date: Thu Aug 02 08:02:09 2018

Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"

This reverts commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8.

Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)

Original change's description:
> [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
> 
> This change implements obtainining Remote Gatt Descriptors for WinRT by
> hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
> appropriate tests are enabled.
> 
> Bug:  821766 
> Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
> Reviewed-on: https://chromium-review.googlesource.com/1156392
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579830}

TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 ,  870208 
Reviewed-on: https://chromium-review.googlesource.com/1159943
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580106}
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/67ca5a07611f7b375f58f822364ce294a2d8b5fc/device/bluetooth/test/fake_gatt_device_service_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd

commit 9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Aug 02 15:29:48 2018

[Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set

BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of
std::set_union in order to merge advertised uuids and service uuids.
However, std::set_union requires sorted ranges as input, which wasn't
necessarily guaranteed before this change. When using a
std::unordered_set the order of elements is not specified and
std::set_union is not guaranteed to work correctly. Using a
base::flat_set for UUIDSet instead fixes this issue. In order to prevent
future regressions this change also replaces the usage of std::set_union
with base::STLSetUnion performing an explicit IsSorted() check in Debug
builds.

Bug:  821766 ,  870208 
Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0
Reviewed-on: https://chromium-review.googlesource.com/1159374
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580198}
[modify] https://crrev.com/9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd/device/bluetooth/bluetooth_device.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2632acba18473ed38a6d093e0f654aadcc0bea

commit be2632acba18473ed38a6d093e0f654aadcc0bea
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Thu Aug 02 15:37:55 2018

Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"

This reverts commit 67ca5a07611f7b375f58f822364ce294a2d8b5fc.

Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.

Original change's description:
> Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> 
> This reverts commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8.
> 
> Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)
> 
> Original change's description:
> > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
> > 
> > This change implements obtainining Remote Gatt Descriptors for WinRT by
> > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
> > appropriate tests are enabled.
> > 
> > Bug:  821766 
> > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
> > Reviewed-on: https://chromium-review.googlesource.com/1156392
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#579830}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 ,  870208 
> Reviewed-on: https://chromium-review.googlesource.com/1159943
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580106}

TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org

Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 ,  870208 
Reviewed-on: https://chromium-review.googlesource.com/1160901
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580200}
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/be2632acba18473ed38a6d093e0f654aadcc0bea/device/bluetooth/test/fake_gatt_device_service_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffac89b53cf458497a4f1b8022e9aaccc22495e2

commit ffac89b53cf458497a4f1b8022e9aaccc22495e2
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Thu Aug 02 15:39:52 2018

Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"

This reverts commit d01b7c9e8df0568084a589486949a54ca82e89f1.

Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.

Original change's description:
> Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> 
> This reverts commit f61df6f91aee2f8073ee409ab2ed624cd390931a.
> 
> Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change.
> 
> Sample builds:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235
> 
> failures:
> BluetoothTestWinrtOnly.GattServices_ObserversCalls/0
> BluetoothTestWinrt.GetPrimaryServices/1
> BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1
> BluetoothTestWinrt.GetPrimaryServicesByUUID/1
> BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0
> BluetoothTestWinrt.GetGattServices_and_GetGattService/1
> BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1
> BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0
> 
> Original change's description:
> > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors
> > 
> > This change implements reading and writing of Remote Gatt Descriptors
> > for WinRT. Furthermore, it enables corresponding tests.
> > 
> > Bug:  821766 
> > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
> > Reviewed-on: https://chromium-review.googlesource.com/1156703
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#579838}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 
> Reviewed-on: https://chromium-review.googlesource.com/1159961
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580062}

TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 
Reviewed-on: https://chromium-review.googlesource.com/1160902
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580201}
[modify] https://crrev.com/ffac89b53cf458497a4f1b8022e9aaccc22495e2/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/ffac89b53cf458497a4f1b8022e9aaccc22495e2/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/ffac89b53cf458497a4f1b8022e9aaccc22495e2/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/ffac89b53cf458497a4f1b8022e9aaccc22495e2/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/ffac89b53cf458497a4f1b8022e9aaccc22495e2/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/ffac89b53cf458497a4f1b8022e9aaccc22495e2/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/ffac89b53cf458497a4f1b8022e9aaccc22495e2/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/ffac89b53cf458497a4f1b8022e9aaccc22495e2/device/bluetooth/test/fake_gatt_descriptor_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43db955e7da0a36e38823c84371ebac3b6eff326

commit 43db955e7da0a36e38823c84371ebac3b6eff326
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Aug 02 19:16:24 2018

[Bluetooth][WinRT] Implement Subscribing to Notifications

This change implements subscribing to Gatt Notifications for WinRT and
enables corresponding tests.

Bug:  821766 
Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7
Reviewed-on: https://chromium-review.googlesource.com/1156686
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580279}
[modify] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/BUILD.gn
[modify] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[add] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.cc
[add] https://crrev.com/43db955e7da0a36e38823c84371ebac3b6eff326/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bfa3b56405a9d622dd43939ee7c7ad4e777d760

commit 1bfa3b56405a9d622dd43939ee7c7ad4e777d760
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Thu Aug 02 20:53:40 2018

Revert "[Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set"

This reverts commit 9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd.

Reason for revert: Linux CFI and Android CFI both breaking on bluetooth tests after this landed:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9368
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2352

Original change's description:
> [Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set
> 
> BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of
> std::set_union in order to merge advertised uuids and service uuids.
> However, std::set_union requires sorted ranges as input, which wasn't
> necessarily guaranteed before this change. When using a
> std::unordered_set the order of elements is not specified and
> std::set_union is not guaranteed to work correctly. Using a
> base::flat_set for UUIDSet instead fixes this issue. In order to prevent
> future regressions this change also replaces the usage of std::set_union
> with base::STLSetUnion performing an explicit IsSorted() check in Debug
> builds.
> 
> Bug:  821766 ,  870208 
> Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0
> Reviewed-on: https://chromium-review.googlesource.com/1159374
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580198}

TBR=ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: I6e3ce514af12bc718a2b759d73086d24d3446c9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 ,  870208 
Reviewed-on: https://chromium-review.googlesource.com/1161022
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580312}
[modify] https://crrev.com/1bfa3b56405a9d622dd43939ee7c7ad4e777d760/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/1bfa3b56405a9d622dd43939ee7c7ad4e777d760/device/bluetooth/bluetooth_device.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c62545a1caf3dc17c5045a83094a73695371da6d

commit c62545a1caf3dc17c5045a83094a73695371da6d
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Aug 03 03:30:11 2018

Revert "[Bluetooth][WinRT] Implement Subscribing to Notifications"

This reverts commit 43db955e7da0a36e38823c84371ebac3b6eff326.

Reason for revert: Broka device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 

Original change's description:
> [Bluetooth][WinRT] Implement Subscribing to Notifications
> 
> This change implements subscribing to Gatt Notifications for WinRT and
> enables corresponding tests.
> 
> Bug:  821766 
> Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7
> Reviewed-on: https://chromium-review.googlesource.com/1156686
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580279}

TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: I8db3ae54ee129c51522a879bff6cad32431b6cb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 , 870208 
Reviewed-on: https://chromium-review.googlesource.com/1161661
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580437}
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/BUILD.gn
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/c62545a1caf3dc17c5045a83094a73695371da6d/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[delete] https://crrev.com/553ec6dab428099a9b73418e016c68f4d45edbf8/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.cc
[delete] https://crrev.com/553ec6dab428099a9b73418e016c68f4d45edbf8/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa8728a79dce84609c98f92911e862b6c7cf280

commit dfa8728a79dce84609c98f92911e862b6c7cf280
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Aug 03 03:34:50 2018

Revert "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors""

This reverts commit ffac89b53cf458497a4f1b8022e9aaccc22495e2.

Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 

Original change's description:
> Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> 
> This reverts commit d01b7c9e8df0568084a589486949a54ca82e89f1.
> 
> Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
> 
> Original change's description:
> > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> > 
> > This reverts commit f61df6f91aee2f8073ee409ab2ed624cd390931a.
> > 
> > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change.
> > 
> > Sample builds:
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235
> > 
> > failures:
> > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0
> > BluetoothTestWinrt.GetPrimaryServices/1
> > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1
> > BluetoothTestWinrt.GetPrimaryServicesByUUID/1
> > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0
> > BluetoothTestWinrt.GetGattServices_and_GetGattService/1
> > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1
> > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0
> > 
> > Original change's description:
> > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors
> > > 
> > > This change implements reading and writing of Remote Gatt Descriptors
> > > for WinRT. Furthermore, it enables corresponding tests.
> > > 
> > > Bug:  821766 
> > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
> > > Reviewed-on: https://chromium-review.googlesource.com/1156703
> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#579838}
> > 
> > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > 
> > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  821766 
> > Reviewed-on: https://chromium-review.googlesource.com/1159961
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580062}
> 
> TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 
> Reviewed-on: https://chromium-review.googlesource.com/1160902
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580201}

TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

Change-Id: I0b4eac30dd4f35b8fb275bed74d69f7b7b1b0f38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 , 870208 
Reviewed-on: https://chromium-review.googlesource.com/1161681
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580440}
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/dfa8728a79dce84609c98f92911e862b6c7cf280/device/bluetooth/test/fake_gatt_descriptor_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b050a38a869f3259cbef8c3862b7ad0c06f7f01e

commit b050a38a869f3259cbef8c3862b7ad0c06f7f01e
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Aug 03 03:38:45 2018

Revert "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors""

This reverts commit be2632acba18473ed38a6d093e0f654aadcc0bea.

Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 

Original change's description:
> Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> 
> This reverts commit 67ca5a07611f7b375f58f822364ce294a2d8b5fc.
> 
> Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
> 
> Original change's description:
> > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> > 
> > This reverts commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8.
> > 
> > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)
> > 
> > Original change's description:
> > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
> > > 
> > > This change implements obtainining Remote Gatt Descriptors for WinRT by
> > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
> > > appropriate tests are enabled.
> > > 
> > > Bug:  821766 
> > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
> > > Reviewed-on: https://chromium-review.googlesource.com/1156392
> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#579830}
> > 
> > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > 
> > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  821766 ,  870208 
> > Reviewed-on: https://chromium-review.googlesource.com/1159943
> > Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> > Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580106}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 ,  870208 
> Reviewed-on: https://chromium-review.googlesource.com/1160901
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580200}

TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org

Change-Id: I9bd3f94b1be3b58b7975e1e57dff09cd7a9c2910
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821766 ,  870208 
Reviewed-on: https://chromium-review.googlesource.com/1161682
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580442}
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/b050a38a869f3259cbef8c3862b7ad0c06f7f01e/device/bluetooth/test/fake_gatt_device_service_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d

commit 922ae26be08b68e6ffc18509a8e37f0f3da2aa6d
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Aug 03 14:00:18 2018

Reland "[Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set"

This is a reland of 9a6c55fc56a2a195f9352eeabdad8fcc28d6b1fd

In order to address the CFI failures [1,2] causing the revert of the
initial CL, this change also de-virtualizes BluetoothUUID. BluetoothUUID
has no subclasses and is meant to use as a value type, which is why a virtual
destructor does not make sense.

[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9368
[2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2352

Original change's description:
> [Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set
>
> BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of
> std::set_union in order to merge advertised uuids and service uuids.
> However, std::set_union requires sorted ranges as input, which wasn't
> necessarily guaranteed before this change. When using a
> std::unordered_set the order of elements is not specified and
> std::set_union is not guaranteed to work correctly. Using a
> base::flat_set for UUIDSet instead fixes this issue. In order to prevent
> future regressions this change also replaces the usage of std::set_union
> with base::STLSetUnion performing an explicit IsSorted() check in Debug
> builds.
>
> Bug:  821766 ,  870208 
> Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0
> Reviewed-on: https://chromium-review.googlesource.com/1159374
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580198}

TBR=ortuno@chromium.org

Bug:  821766 ,  870208 
Change-Id: I3fc55939ff5b8b136db0d45978c5b19083adb1d9
Reviewed-on: https://chromium-review.googlesource.com/1161883
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580530}
[modify] https://crrev.com/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/922ae26be08b68e6ffc18509a8e37f0f3da2aa6d/device/bluetooth/bluetooth_uuid.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4

commit 7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Aug 06 09:06:57 2018

Reland "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors""

This reverts commit b050a38a869f3259cbef8c3862b7ad0c06f7f01e.

Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by this CL.

Original change's description:
> Revert "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors""
> 
> This reverts commit be2632acba18473ed38a6d093e0f654aadcc0bea.
> 
> Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 
> 
> Original change's description:
> > Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> > 
> > This reverts commit 67ca5a07611f7b375f58f822364ce294a2d8b5fc.
> > 
> > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
> > 
> > Original change's description:
> > > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
> > > 
> > > This reverts commit 20f64257cc9c09b466c4ae3944dbc165f83a9ae8.
> > > 
> > > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)
> > > 
> > > Original change's description:
> > > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
> > > > 
> > > > This change implements obtainining Remote Gatt Descriptors for WinRT by
> > > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
> > > > appropriate tests are enabled.
> > > > 
> > > > Bug:  821766 
> > > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
> > > > Reviewed-on: https://chromium-review.googlesource.com/1156392
> > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#579830}
> > > 
> > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > > 
> > > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug:  821766 ,  870208 
> > > Reviewed-on: https://chromium-review.googlesource.com/1159943
> > > Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> > > Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#580106}
> > 
> > TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
> > 
> > Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  821766 ,  870208 
> > Reviewed-on: https://chromium-review.googlesource.com/1160901
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580200}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I9bd3f94b1be3b58b7975e1e57dff09cd7a9c2910
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 ,  870208 
> Reviewed-on: https://chromium-review.googlesource.com/1161682
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580442}

TBR=reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  821766 ,  870208 
Change-Id: I29824289cbd23722a5e0397f07f40b62769549d4
Reviewed-on: https://chromium-review.googlesource.com/1163382
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580828}
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_gatt_discoverer_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_characteristic.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_descriptor_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_descriptors_result_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_descriptors_result_winrt.h
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/7dd23fd6faaa64e651d9c9d5375136c9d9ecc4f4/device/bluetooth/test/fake_gatt_device_service_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad

commit d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Aug 06 10:15:45 2018

Reland "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors""

This reverts commit dfa8728a79dce84609c98f92911e862b6c7cf280.

Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by a CL this one depended on.

Original change's description:
> Revert "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors""
> 
> This reverts commit ffac89b53cf458497a4f1b8022e9aaccc22495e2.
> 
> Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 
> 
> Original change's description:
> > Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> > 
> > This reverts commit d01b7c9e8df0568084a589486949a54ca82e89f1.
> > 
> > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
> > 
> > Original change's description:
> > > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
> > > 
> > > This reverts commit f61df6f91aee2f8073ee409ab2ed624cd390931a.
> > > 
> > > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change.
> > > 
> > > Sample builds:
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235
> > > 
> > > failures:
> > > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0
> > > BluetoothTestWinrt.GetPrimaryServices/1
> > > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1
> > > BluetoothTestWinrt.GetPrimaryServicesByUUID/1
> > > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0
> > > BluetoothTestWinrt.GetGattServices_and_GetGattService/1
> > > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1
> > > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0
> > > 
> > > Original change's description:
> > > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors
> > > > 
> > > > This change implements reading and writing of Remote Gatt Descriptors
> > > > for WinRT. Furthermore, it enables corresponding tests.
> > > > 
> > > > Bug:  821766 
> > > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
> > > > Reviewed-on: https://chromium-review.googlesource.com/1156703
> > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#579838}
> > > 
> > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > > 
> > > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug:  821766 
> > > Reviewed-on: https://chromium-review.googlesource.com/1159961
> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#580062}
> > 
> > TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> > 
> > Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  821766 
> > Reviewed-on: https://chromium-review.googlesource.com/1160902
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580201}
> 
> TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I0b4eac30dd4f35b8fb275bed74d69f7b7b1b0f38
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 , 870208 
> Reviewed-on: https://chromium-review.googlesource.com/1161681
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580440}

TBR=kinuko@chromium.org,reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  821766 ,  870208 
Change-Id: Icaf844c0c0aa72ab38db3e834df3100088339f1b
Reviewed-on: https://chromium-review.googlesource.com/1163384
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580837}
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.h
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/fake_gatt_descriptor_winrt.cc
[modify] https://crrev.com/d0a3dc6f9d59b50aebb954a68e77f23d12dc1dad/device/bluetooth/test/fake_gatt_descriptor_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9

commit e0029d1291f50cbccfa89e44d53b9ee80f5e77f9
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Aug 06 14:06:08 2018

Reland "[Bluetooth][WinRT] Implement Subscribing to Notifications"

This reverts commit c62545a1caf3dc17c5045a83094a73695371da6d.

Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by a CL this one depended on.

Original change's description:
> Revert "[Bluetooth][WinRT] Implement Subscribing to Notifications"
> 
> This reverts commit 43db955e7da0a36e38823c84371ebac3b6eff326.
> 
> Reason for revert: Broka device_unittests on Win10 Tests x64 (dbg)  crbug.com/870208 
> 
> Original change's description:
> > [Bluetooth][WinRT] Implement Subscribing to Notifications
> > 
> > This change implements subscribing to Gatt Notifications for WinRT and
> > enables corresponding tests.
> > 
> > Bug:  821766 
> > Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7
> > Reviewed-on: https://chromium-review.googlesource.com/1156686
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580279}
> 
> TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
> 
> Change-Id: I8db3ae54ee129c51522a879bff6cad32431b6cb6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  821766 , 870208 
> Reviewed-on: https://chromium-review.googlesource.com/1161661
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580437}

TBR=reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  821766 ,  870208 
Change-Id: Ic15f662b5c221d675edad297224a8643d52f496a
Reviewed-on: https://chromium-review.googlesource.com/1162123
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580861}
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/BUILD.gn
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.h
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/fake_gatt_characteristic_winrt.cc
[modify] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/fake_gatt_characteristic_winrt.h
[add] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.cc
[add] https://crrev.com/e0029d1291f50cbccfa89e44d53b9ee80f5e77f9/device/bluetooth/test/fake_gatt_value_changed_event_args_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9092f83f109f6e5974be74734902646bf17c301c

commit 9092f83f109f6e5974be74734902646bf17c301c
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Tue Aug 14 07:05:11 2018

[Bluetooth][WinRT] Implement BluetoothDevice::IsPaired()

This change implements BluetoothDevice::IsPaired() by querying the
underlying device information. Furthermore, a test is added, which is
currently only enabled for Windows.

Bug:  821766 
Change-Id: Idaed73fe544f115c1a0fc2157f477b009f4c26a6
Reviewed-on: https://chromium-review.googlesource.com/1172971
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582853}
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/BUILD.gn
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/bluetooth_device_winrt.cc
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[add] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/fake_device_information_pairing_winrt.cc
[add] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/fake_device_information_pairing_winrt.h
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/fake_device_information_winrt.cc
[modify] https://crrev.com/9092f83f109f6e5974be74734902646bf17c301c/device/bluetooth/test/fake_device_information_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aa2851d30a93d334978f87ece9aeb9601393c39

commit 7aa2851d30a93d334978f87ece9aeb9601393c39
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Fri Aug 17 08:11:41 2018

[Bluetooth][WinRT] Add Skeletons required for Pairing

This change implements skeletons required for WinRT's pairing logic. No
actual functionality is added, this will be provided in a later CL.
Furthermore, it moves the TestPairingDelegate class from BlueZ's tests
into a standalone file. It also wraps the TestPairingDelegate in
bluetooth_adapter_unittest.cc in an anonymous namespace to avoid ODR
violations.

Bug:  821766 
Change-Id: If440153dff46476223a1b24dfab1a630fb2451a3
Reviewed-on: https://chromium-review.googlesource.com/1177715
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583989}
[modify] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/BUILD.gn
[modify] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[add] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/fake_device_information_custom_pairing_winrt.cc
[add] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/fake_device_information_custom_pairing_winrt.h
[modify] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/fake_device_information_pairing_winrt.cc
[modify] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/fake_device_information_pairing_winrt.h
[add] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/fake_device_pairing_requested_event_args_winrt.cc
[add] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/fake_device_pairing_requested_event_args_winrt.h
[add] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/fake_device_pairing_result_winrt.cc
[add] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/fake_device_pairing_result_winrt.h
[add] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/test_pairing_delegate.cc
[add] https://crrev.com/7aa2851d30a93d334978f87ece9aeb9601393c39/device/bluetooth/test/test_pairing_delegate.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/477fded68c2d1207b5ac2d57de7e6274ec3f3753

commit 477fded68c2d1207b5ac2d57de7e6274ec3f3753
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Sat Aug 18 00:26:08 2018

[Bluetooth] Enable BluetoothAdapterWinrt by default

This change enables BluetoothAdapterWinrt by default. In order to
continue to support chrome.bluetooth and chrome.bluetoothSockets on
Windows 10, BluetoothAdapterFactory::GetClassicAdapter() is introduced.
This method will always create a BluetoothAdapterWin on Windows, while
it is equivalent to BluetoothAdapterFactory::GetAdapter() on other
platforms.

Bug:  821766 
Change-Id: Idfe8e990987de2b72e2ecaee743ad43ee6722ceb
Reviewed-on: https://chromium-review.googlesource.com/1179824
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584258}
[modify] https://crrev.com/477fded68c2d1207b5ac2d57de7e6274ec3f3753/device/base/features.cc
[modify] https://crrev.com/477fded68c2d1207b5ac2d57de7e6274ec3f3753/device/bluetooth/bluetooth_adapter_factory.cc
[modify] https://crrev.com/477fded68c2d1207b5ac2d57de7e6274ec3f3753/device/bluetooth/bluetooth_adapter_factory.h
[modify] https://crrev.com/477fded68c2d1207b5ac2d57de7e6274ec3f3753/device/bluetooth/bluetooth_adapter_win.cc
[modify] https://crrev.com/477fded68c2d1207b5ac2d57de7e6274ec3f3753/device/bluetooth/bluetooth_adapter_win.h
[modify] https://crrev.com/477fded68c2d1207b5ac2d57de7e6274ec3f3753/extensions/browser/api/bluetooth/bluetooth_event_router.cc
[modify] https://crrev.com/477fded68c2d1207b5ac2d57de7e6274ec3f3753/extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b9a1e07950a588777fa1b30e3e6b064170e6f09

commit 8b9a1e07950a588777fa1b30e3e6b064170e6f09
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Mon Aug 20 10:01:24 2018

[Bluetooth][WinRT] Implement Pairing

This change implements pairing on WinRT and adds appropriate tests. In order
to encapsulate the implementation, a new BluetoothPairingWinrt helper class
is introduced. For now only pairing via PIN code is supported.

Bug:  821766 
Change-Id: Ic0a64b4e79dd38f9c0ac86a25c0a878f1f70192c
Reviewed-on: https://chromium-review.googlesource.com/1177741
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584391}
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/BUILD.gn
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/bluetooth_device_winrt.cc
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/bluetooth_device_winrt.h
[add] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/bluetooth_pairing_winrt.cc
[add] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/bluetooth_pairing_winrt.h
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_device_information_custom_pairing_winrt.cc
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_device_information_custom_pairing_winrt.h
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_device_information_pairing_winrt.cc
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_device_information_pairing_winrt.h
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_device_pairing_requested_event_args_winrt.cc
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_device_pairing_requested_event_args_winrt.h
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_device_pairing_result_winrt.cc
[modify] https://crrev.com/8b9a1e07950a588777fa1b30e3e6b064170e6f09/device/bluetooth/test/fake_device_pairing_result_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f397e84f7b8e52d2b21abd2d5467c91443609051

commit f397e84f7b8e52d2b21abd2d5467c91443609051
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Aug 23 17:40:17 2018

[Bluetooth][WinRT] Skeletons required for Advertisement

This change adds skeletons of classes required for implementing
publishing advertisements for WinRT. Actual functionality will be added
in a follow-up CL.

Bug:  821766 
Change-Id: Ib80e8a53810457765ed5e48550d683e1f595ded8
Reviewed-on: https://chromium-review.googlesource.com/1187144
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585536}
[modify] https://crrev.com/f397e84f7b8e52d2b21abd2d5467c91443609051/device/BUILD.gn
[add] https://crrev.com/f397e84f7b8e52d2b21abd2d5467c91443609051/device/bluetooth/test/fake_bluetooth_le_advertisement_publisher_status_changed_event_args_winrt.cc
[add] https://crrev.com/f397e84f7b8e52d2b21abd2d5467c91443609051/device/bluetooth/test/fake_bluetooth_le_advertisement_publisher_status_changed_event_args_winrt.h
[add] https://crrev.com/f397e84f7b8e52d2b21abd2d5467c91443609051/device/bluetooth/test/fake_bluetooth_le_advertisement_publisher_winrt.cc
[add] https://crrev.com/f397e84f7b8e52d2b21abd2d5467c91443609051/device/bluetooth/test/fake_bluetooth_le_advertisement_publisher_winrt.h
[modify] https://crrev.com/f397e84f7b8e52d2b21abd2d5467c91443609051/device/bluetooth/test/fake_bluetooth_le_manufacturer_data_winrt.cc
[modify] https://crrev.com/f397e84f7b8e52d2b21abd2d5467c91443609051/device/bluetooth/test/fake_bluetooth_le_manufacturer_data_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e

commit 9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Fri Aug 24 11:52:08 2018

[Bluetooth][WinRT] Fix Gatt Disconnection

This change fixes BluetoothDeviceWinrt::DiscoonectGatt. It does so by
working around a quirk in the UWP APIs, that requires dropping all
internal references to a given device. See this GitHub issue for further
discussion: https://github.com/jasongin/noble-uwp/issues/20

Bug:  821766 
Change-Id: I5bf0e4e0ce0e3b43d9cbb10e3b11e378de05e6b3
Reviewed-on: https://chromium-review.googlesource.com/1183234
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585799}
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/bluetooth_device_winrt.cc
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/bluetooth_device_winrt.h
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/test/bluetooth_test.cc
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/test/fake_bluetooth_le_device_winrt.h
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/test/fake_gatt_device_service_winrt.cc
[modify] https://crrev.com/9ab40ee7f3e6dfcdd1c0b597f8ef6a13bd42117e/device/bluetooth/test/fake_gatt_device_service_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b7fa9edfe15a60ad81a6e80d5b6c0c9e8ae5380

commit 1b7fa9edfe15a60ad81a6e80d5b6c0c9e8ae5380
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Fri Aug 24 13:34:05 2018

[webauthn] Create caBLE Win Feature Flag

This change adds a feature flag for caBLE for Windows and disables it
by default.

Bug:  821766 ,  837088 
Change-Id: I2f87be1854a3fc64d23c9a0493eaecf0ee73668b
Reviewed-on: https://chromium-review.googlesource.com/1187146
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585821}
[modify] https://crrev.com/1b7fa9edfe15a60ad81a6e80d5b6c0c9e8ae5380/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/1b7fa9edfe15a60ad81a6e80d5b6c0c9e8ae5380/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/1b7fa9edfe15a60ad81a6e80d5b6c0c9e8ae5380/content/public/common/content_features.cc
[modify] https://crrev.com/1b7fa9edfe15a60ad81a6e80d5b6c0c9e8ae5380/content/public/common/content_features.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d26e800fc08cbebe7a1342c705461a45a1ac0c79

commit d26e800fc08cbebe7a1342c705461a45a1ac0c79
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Mon Aug 27 11:56:17 2018

[Bluetooth][WinRT] Post Events to the Original TaskRunner

This CL modifies AddTypedEventHandler to post its tasks instead of
running them immediately. This guarantees that events are received on
the same thread an event handler was created on, and closer resembles
production environments in tests.

Bug:  821766 
Change-Id: I7859a2566adf304c835b5a3982725bb4069007fc
Reviewed-on: https://chromium-review.googlesource.com/1188904
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586235}
[modify] https://crrev.com/d26e800fc08cbebe7a1342c705461a45a1ac0c79/device/bluetooth/event_utils_winrt.h
[modify] https://crrev.com/d26e800fc08cbebe7a1342c705461a45a1ac0c79/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/d26e800fc08cbebe7a1342c705461a45a1ac0c79/device/bluetooth/test/fake_bluetooth_le_device_winrt.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1fc54284d4db36c1644b02a2e0f21991b55aa4a

commit c1fc54284d4db36c1644b02a2e0f21991b55aa4a
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Mon Aug 27 14:07:09 2018

[Bluetooth] Implement BluetoothAdapter::CanPower()

This change adds a CanPower() method to BluetoothAdapter. By default it
simply delegates to IsPresent(), but it is overriden for WinRT, where we
can be in a state where we were able to get accesss to the adapter, but
not the underlying radio.

Bug:  821766 
Change-Id: I46544d542b49a73f7876a10daccb6d78c492b36c
Reviewed-on: https://chromium-review.googlesource.com/1189903
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586248}
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/bluetooth_adapter.cc
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/test/fake_bluetooth_adapter_winrt.cc
[modify] https://crrev.com/c1fc54284d4db36c1644b02a2e0f21991b55aa4a/device/bluetooth/test/fake_bluetooth_adapter_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5832e632a15759efee38d34ea5182049057d0ae

commit d5832e632a15759efee38d34ea5182049057d0ae
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Tue Aug 28 16:39:50 2018

[Bluetooth][WinRT] Implement Publishing of Advertisements

This change implements publishing of advertisments on WinRT. It uses the
UWP BluetoothLEAdvertisementPublisher interface to do so, which is
wrapped in a BluetoothAdvertisementWinrt class.

Bug:  821766 
Change-Id: I894eaee7d916ca04b2a27de67cc66cf2f198164b
Reviewed-on: https://chromium-review.googlesource.com/1186732
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586740}
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/BUILD.gn
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/BUILD.gn
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/bluetooth_adapter.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/bluetooth_adapter_winrt.h
[add] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/bluetooth_advertisement_winrt.cc
[add] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/bluetooth_advertisement_winrt.h
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/bluetooth_test.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/fake_bluetooth_le_advertisement_publisher_status_changed_event_args_winrt.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/fake_bluetooth_le_advertisement_publisher_status_changed_event_args_winrt.h
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/fake_bluetooth_le_advertisement_publisher_winrt.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/fake_bluetooth_le_advertisement_publisher_winrt.h
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/fake_bluetooth_le_advertisement_winrt.cc
[modify] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/fake_bluetooth_le_advertisement_winrt.h
[add] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/test_bluetooth_advertisement_observer.cc
[add] https://crrev.com/d5832e632a15759efee38d34ea5182049057d0ae/device/bluetooth/test/test_bluetooth_advertisement_observer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/822afc4f8c4a9ce165ec8c67252bce731f45dc8d

commit 822afc4f8c4a9ce165ec8c67252bce731f45dc8d
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Wed Aug 29 09:14:09 2018

[Bluetooth][WinRT] Observe Radio Powered State

This change implements observing the radio powered state in WinRT. This
allows notifying observers about external changes.

Bug:  821766 
Change-Id: I41edfa74964341d02ab290114d3675c719cf5996
Reviewed-on: https://chromium-review.googlesource.com/1188468
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587047}
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/bluetooth_adapter.cc
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/bluetooth_adapter_android.cc
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/test/bluetooth_test_mac.mm
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/test/bluetooth_test_win.h
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/test/fake_radio_winrt.cc
[modify] https://crrev.com/822afc4f8c4a9ce165ec8c67252bce731f45dc8d/device/bluetooth/test/fake_radio_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcd90ba9d4e64dbd6d33ca2c19c77a108b74ab1a

commit bcd90ba9d4e64dbd6d33ca2c19c77a108b74ab1a
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Aug 30 12:36:29 2018

[Bluetooth][WinRT] Add FakeDeviceWatcher Skeleton

This change adds a skeleton for a fake implementation of IDeviceWatcher.
No functionality is added yet, this will be done in a follow-up CL.

Bug:  821766 
Change-Id: If51716beac17543975d42632b17c8af7f269ac5c
Reviewed-on: https://chromium-review.googlesource.com/1193890
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587531}
[modify] https://crrev.com/bcd90ba9d4e64dbd6d33ca2c19c77a108b74ab1a/device/BUILD.gn
[add] https://crrev.com/bcd90ba9d4e64dbd6d33ca2c19c77a108b74ab1a/device/bluetooth/test/fake_device_watcher_winrt.cc
[add] https://crrev.com/bcd90ba9d4e64dbd6d33ca2c19c77a108b74ab1a/device/bluetooth/test/fake_device_watcher_winrt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42dbd1c49ed10294bae6e512e05464d97b3c19b7

commit 42dbd1c49ed10294bae6e512e05464d97b3c19b7
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Aug 30 15:06:41 2018

[bluetooth] Determine if AdapterWinrt is Powered

This change implements BluetoothAdapterWinrt::IsPowered(). While the UWP
APIs to retrieve a radio from the adapter are not yet available to
Chrome, it is possible to retrieve a DeviceInformation list
corresponding to powered radios on the system. This is used in this CL
to determine whether the default adapter is powered or not.

Bug:  821766 
Change-Id: Iaff0799ced2d96bf7d4d6249f5ac7a294866d669
Reviewed-on: https://chromium-review.googlesource.com/1065824
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587579}
[modify] https://crrev.com/42dbd1c49ed10294bae6e512e05464d97b3c19b7/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/42dbd1c49ed10294bae6e512e05464d97b3c19b7/device/bluetooth/bluetooth_adapter_winrt.cc
[modify] https://crrev.com/42dbd1c49ed10294bae6e512e05464d97b3c19b7/device/bluetooth/bluetooth_adapter_winrt.h
[modify] https://crrev.com/42dbd1c49ed10294bae6e512e05464d97b3c19b7/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/42dbd1c49ed10294bae6e512e05464d97b3c19b7/device/bluetooth/test/fake_device_information_winrt.cc
[modify] https://crrev.com/42dbd1c49ed10294bae6e512e05464d97b3c19b7/device/bluetooth/test/fake_device_watcher_winrt.cc
[modify] https://crrev.com/42dbd1c49ed10294bae6e512e05464d97b3c19b7/device/bluetooth/test/fake_device_watcher_winrt.h