New issue
Advanced search Search tips

Issue 821765 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

Popup menu: Update content container view appearance

Project Member Reported by gambard@chromium.org, Mar 14 2018

Issue description

The view containing the content should have a light blur effect with background color and a dual shadow.
 
Labels: -Type-Bug Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dce2228696f4e255cf08b28a915cf1863f549b11

commit dce2228696f4e255cf08b28a915cf1863f549b11
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 23 13:56:22 2018

Adjust PopupMenu popup position

This CL changes the popup menu so it has a minimal width and a margin
between the top and bottom edges.

Bug:  821765 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3953f4db951b8dd17090caa5b3e30074b72b1682
Reviewed-on: https://chromium-review.googlesource.com/976001
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545422}
[modify] https://crrev.com/dce2228696f4e255cf08b28a915cf1863f549b11/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86496528533643230431dfb13af6ecb59ffa6c62

commit 86496528533643230431dfb13af6ecb59ffa6c62
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 27 07:31:43 2018

Add blur effect to the popup menu

This CL adds a blur effect for the popup of the popup menu.

Bug:  821765 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie562e101ef8d43f8721d92aa070260ccdb957a72
Reviewed-on: https://chromium-review.googlesource.com/980312
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546052}
[modify] https://crrev.com/86496528533643230431dfb13af6ecb59ffa6c62/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/86496528533643230431dfb13af6ecb59ffa6c62/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/86496528533643230431dfb13af6ecb59ffa6c62/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e42f108019798f7d87f99b3fbe35f14ecba1304

commit 0e42f108019798f7d87f99b3fbe35f14ecba1304
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 30 10:39:48 2018

Add shadow asset to the popup menu

This CL adds the shadow asset, replacing the CALayer shadow currently
used. It also removes the blur effect as it is not needed anymore.

Bug:  821765 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I55802e6bbebc7f2da429ad78c8834f604d956e00
Reviewed-on: https://chromium-review.googlesource.com/986432
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547138}
[modify] https://crrev.com/0e42f108019798f7d87f99b3fbe35f14ecba1304/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/0e42f108019798f7d87f99b3fbe35f14ecba1304/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm
[modify] https://crrev.com/0e42f108019798f7d87f99b3fbe35f14ecba1304/ios/chrome/browser/ui/popup_menu/resources/BUILD.gn
[add] https://crrev.com/0e42f108019798f7d87f99b3fbe35f14ecba1304/ios/chrome/browser/ui/popup_menu/resources/popup_menu_shadow.imageset/Contents.json
[add] https://crrev.com/0e42f108019798f7d87f99b3fbe35f14ecba1304/ios/chrome/browser/ui/popup_menu/resources/popup_menu_shadow.imageset/popup_menu_shadow.png
[add] https://crrev.com/0e42f108019798f7d87f99b3fbe35f14ecba1304/ios/chrome/browser/ui/popup_menu/resources/popup_menu_shadow.imageset/popup_menu_shadow@2x.png
[add] https://crrev.com/0e42f108019798f7d87f99b3fbe35f14ecba1304/ios/chrome/browser/ui/popup_menu/resources/popup_menu_shadow.imageset/popup_menu_shadow@3x.png

Labels: -Q1 Q2
Status: Fixed (was: Started)

Comment 8 by cmasso@google.com, Apr 10 2018

Labels: -Pri-3 Pri-2

Sign in to add a comment