New issue
Advanced search Search tips

Issue 821764 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Task



Sign in to add a comment

Scrub Syzygy/SyzyASAN build configuration

Project Member Reported by siggi@chromium.org, Mar 14 2018

Issue description

Now that SyzyASAN is no more, it should be possible to simplimaficate the build configs somewhat. Might as well wait until Albatross has been resurrected, though.
 

Comment 1 by siggi@chromium.org, Mar 15 2018

Cc: sebmarchand@chromium.org

Comment 2 by thakis@chromium.org, Mar 28 2018

See issue 818747 for steps for turning syzyasan back on.

Comment 3 by siggi@chromium.org, Mar 28 2018

The zap_timestamps utility is still used on 32 bit builders. As soon as we've switched over to lld, this'll be redundant and can be removed without any consequence.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69d0bcdd9729d123d9ba030d9506f763f0e2e56f

commit 69d0bcdd9729d123d9ba030d9506f763f0e2e56f
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Thu Mar 29 21:50:51 2018

Remove Syzygy/SyzyASAN build configuration and related code.

This removes the is_syzyasan build flag and related build configuration.
Everything under the SYZYASAN define is either removed, or moved under
ADDRESS_SANITIZER, as e.g. the previously SyzyASAN-only heap corruption
debug URLs.

The DCHECK debug URL is now enabled and the activity tracker grabs a
stack trace when DCHECK_IS_ON(), instead of only under SYZYASAN.

The metrics system sets the is_asan_build bit in the system profile now
under ADDRESS_SANITIZER, against the day when we ship Clang ASAN builds.

The SyzyProf profiling support is removed.

To support the upcoming official build with configurable DCHECKs, the
channel string visible in chrome://settings/help is adorned with "DCheck".

The DEPS to fetch the Syzygy binary archive is left in place, as the
zap_timestamps.exe utility is still in use. Once LLD replaces the MSVC
linker, that can be removed without penalty, at which time the DEPS will
be scrubbed.

Bug:  821764 
Change-Id: I08202da8f032f2350a589cfcda9e9b2edd147b7d
Reviewed-on: https://chromium-review.googlesource.com/980912
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546966}
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/.gitignore
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/BUILD.gn
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/DEPS
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/allocator/README.md
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/debug/activity_tracker.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/debug/asan_invalid_access.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/debug/asan_invalid_access.h
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/debug/profiler.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/debug/profiler.h
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/logging.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/process/process_util_unittest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/test/test_timeouts.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/threading/platform_thread_win.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/tools_sanity_unittest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/base/trace_event/malloc_dump_provider.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/build/config/BUILD.gn
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/build/config/allocator.gni
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/build/config/sanitizers/sanitizers.gni
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/build/config/win/BUILD.gn
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/build/win/syzygy/BUILD.gn
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/build/win/syzygy/OWNERS
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/build/win/syzygy/instrument.py
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/build/win/syzygy/reorder.py
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/build/win/syzygy/syzyasan-allocation-filter.txt
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/build/win/syzygy/syzyasan-instrumentation-filter.txt
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/build/win/syzygy/syzygy.gni
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/extensions/active_tab_apitest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/extensions/api/context_menus/context_menu_apitest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/extensions/api/cookies/cookies_apitest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/profiling_host/chrome_browser_main_extra_parts_profiling.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/profiling_host/memlog_browsertest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/browser/ui/webui/memory_internals_ui.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/child/BUILD.gn
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/chrome/child/child_profiling.cc
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/chrome/child/child_profiling.h
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/common/channel_info_win.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/common/chrome_features.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/common/chrome_features.h
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/test/base/javascript_browser_test.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/test/ppapi/ppapi_interactive_browsertest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/tools/build/win/FILES.cfg
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome/tools/build/win/create_installer_archive.py
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/chrome/tools/build/win/syzygy/BUILD.gn
[delete] https://crrev.com/297d5f530fb894970ea5a6f1d9ffc18d89e555e9/chrome/tools/build/win/syzygy/OWNERS
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/chrome_elf/elf_imports_unittest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/components/browser_watcher/stability_debugging.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/components/metrics/metrics_log.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/components/metrics/metrics_log_unittest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/browser/frame_host/debug_urls.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/browser/webrtc/webrtc_stress_pause_browsertest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/browser/webrtc/webrtc_stress_resolution_switch_browsertest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/browser/webrtc/webrtc_stress_source_switch_browsertest.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/public/common/url_constants.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/public/common/url_constants.h
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/public/common/url_utils.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/content/shell/BUILD.gn
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/services/service_manager/sandbox/win/sandbox_win.cc
[modify] https://crrev.com/69d0bcdd9729d123d9ba030d9506f763f0e2e56f/skia/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed05d62660b3fd83ed7724fbe5609b529f9e31d1

commit ed05d62660b3fd83ed7724fbe5609b529f9e31d1
Author: Wez <wez@chromium.org>
Date: Wed Apr 11 20:06:25 2018

Fix string literal in GetChannelName() for official builds.

Bug:  812058 ,  821764 ,  831697 
Change-Id: I86759e3ed14cdda2e397f67a23481dd1cf5c7844
Reviewed-on: https://chromium-review.googlesource.com/1007882
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549946}
[modify] https://crrev.com/ed05d62660b3fd83ed7724fbe5609b529f9e31d1/chrome/common/channel_info_win.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2018

Labels: merge-merged-3395
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330c3615157cd58b987a27440fd2abaa1573d3a2

commit 330c3615157cd58b987a27440fd2abaa1573d3a2
Author: Wez <wez@chromium.org>
Date: Thu Apr 12 04:58:36 2018

Fix string literal in GetChannelName() for official builds.

Bug:  812058 ,  821764 ,  831697 
Change-Id: I86759e3ed14cdda2e397f67a23481dd1cf5c7844
Reviewed-on: https://chromium-review.googlesource.com/1007882
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549946}(cherry picked from commit ed05d62660b3fd83ed7724fbe5609b529f9e31d1)
Reviewed-on: https://chromium-review.googlesource.com/1009126
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/branch-heads/3395@{#2}
Cr-Branched-From: 19ac07e50344cdf4089e5d1b696958867736fc03-refs/heads/master@{#549859}
[modify] https://crrev.com/330c3615157cd58b987a27440fd2abaa1573d3a2/chrome/common/channel_info_win.cc

Comment 7 by w...@chromium.org, Apr 12 2018

Blockedon: -812058
Fixed?
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96d692b3f755e51519b4d7c37dc0ea2491b6ac68

commit 96d692b3f755e51519b4d7c37dc0ea2491b6ac68
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu Aug 02 17:47:59 2018

Remove zap_timestamp and the Syzygy deps

This isn't needed anymore as we're now using LLD.

Bug:  804926 ,  821764 
Change-Id: I3c6e4ce0793997823b89978cf7eda5b3a26399b8
Reviewed-on: https://chromium-review.googlesource.com/1108185
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580239}
[modify] https://crrev.com/96d692b3f755e51519b4d7c37dc0ea2491b6ac68/DEPS
[delete] https://crrev.com/1fffcaa3a17ce8a428343bd633f5f9583108dc79/build/get_syzygy_binaries.py
[modify] https://crrev.com/96d692b3f755e51519b4d7c37dc0ea2491b6ac68/tools/determinism/deterministic_build_blacklist.json
[modify] https://crrev.com/96d692b3f755e51519b4d7c37dc0ea2491b6ac68/tools/determinism/remove_build_metadata.py

Status: Fixed (was: Assigned)
Assuming Seb's CL sticks, I think that's the last of'er.

Sign in to add a comment