Chrome canary update needs approval |
|||||
Issue descriptionChrome Version: 67.0.3369.0 is my current ver OS: android What steps will reproduce the problem? (1) go to play store (2) see chrome canary update (3) What is the expected result? Updates without permissions What happens instead? Needs approval - maybe new permission? Please use labels and text to provide additional information. The version on play is 67.0.3370.0 so something must have changed between 3369 and 3370. Wanted to check that this was intended as adding a new permission often has user update attrition. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 14 2018
,
Mar 14 2018
Nothing obvious in the change range: https://chromium.googlesource.com/chromium/src/+log/67.0.3369.0..67.0.3370.0?pretty=fuller&n=10000 Last internal AndroidManifest change was from Jan 25, so shouldn't be that. https://chrome-internal-review.googlesource.com/555599 A couple changes to our upstream AndroidManifest early this week: https://chromium-review.googlesource.com/959048 https://chromium-review.googlesource.com/952971 But neither of those change anything permission related.
,
Mar 14 2018
Mine did in fact update on my personal device. And found that WebView removed a couple of services: org.chromium.android_webview.services.AwVariationsConfigurationService and org.chromium.android_webview.services.AwVariationsSeedFetchService as part of https://chromium-review.googlesource.com/c/chromium/src/+/959620. But other than that, and of course the changes to versionName and versionCode, I couldn't seem to find any issue with the Monochrome manifest.
,
Mar 14 2018
wfh@, what specific permissions were requested?
,
Mar 14 2018
We have not been able to reproduce it on our end. So it does not seem to be consistent. Meanwhile I reach out the the PlayStore team to check if there is anything that has changed on their side that might trigger this. Any experiment they might be running or something similar.
,
Mar 14 2018
We tested this scenario with Auto-update /manual-update from 67.0.3369.0-> 67.0.3370.0 version and not see any permission issues
,
Mar 14 2018
I think it's doubtful but did we roll a library or add a new dependency causing us to manifest-merge in a permission? Also wfh: what device was this on?
,
Mar 14 2018
I can no longer repro this, and I never updated. It's on Android 8.1.0; Pixel XL. I never clicked the notification so did not get far enough to see permissions. Perhaps Play had an issue?
,
Mar 14 2018
Re: #8, my commit linked in #4 seems to be the only manifest change: $ diff android-B0urB0N-67.0.3369.0-arm-signed-MonochromeCanary/AndroidManifest.xml android-B0urB0N-67.0.3370.0-arm-signed-MonochromeCanary/AndroidManifest.xml 1c1 < <?xml version="1.0" encoding="utf-8" standalone="no"?><manifest xmlns:n1="http://schemas.android.com/apk/res/android" n1:versionCode="336900002" n1:versionName="67.0.3369.0" package="com.chrome.canary" platformBuildVersionCode="27" platformBuildVersionName="8.1.0"> --- > <?xml version="1.0" encoding="utf-8" standalone="no"?><manifest xmlns:n1="http://schemas.android.com/apk/res/android" n1:versionCode="337000002" n1:versionName="67.0.3370.0" package="com.chrome.canary" platformBuildVersionCode="27" platformBuildVersionName="8.1.0"> 748,749d747 < <service n1:exported="true" n1:name="org.chromium.android_webview.services.AwVariationsConfigurationService" n1:process=":webview_service"/> < <service n1:exported="false" n1:name="org.chromium.android_webview.services.AwVariationsSeedFetchService" n1:permission="android.permission.BIND_JOB_SERVICE" n1:process=":webview_service"/>
,
Mar 14 2018
Err one way to do this is to pull both builds and then do somethign like aapt dump xmltree <foo.apk> AndroidManifest.xml and compare those
,
Mar 14 2018
:S uhh, thanks Paul!
,
Mar 14 2018
(I used apktool.) Does WontFix mean we're certain this isn't due to a Chrome change? If we're sure it's a problem with Play, is there a similarly-urgent bug against them somewhere?
,
Mar 14 2018
Perhaps I misunderstood #9: is this still an issue?
,
Mar 14 2018
Well there's a bug somewhere. IMO it's probably not in Chrome. But either way we need to pursue it. I'll leave it to cmasso@ as to whether this should be re-opened.
,
Mar 15 2018
I thought this was no longer an issue because we could no longer reproduce it. Paul are you still seeing it?
,
Mar 15 2018
I haven't been able to repro.
,
Mar 15 2018
I guess we'll find out soon if it's a real issue if the beta population shrinks?
,
Mar 15 2018
I mean, canary. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by amin...@google.com
, Mar 14 2018Labels: -Pri-1 ReleaseBlock-Dev Pri-0
Owner: cma...@chromium.org
Status: Assigned (was: Untriaged)