Issue metadata
Sign in to add a comment
|
Web page reloads on closing incognito tab |
||||||||||||||||||||||
Issue descriptionApp Version: 66.0.3359.30 Beta iOS Version: 11.3 beta 5, 10.3.3 Device: iPhone, iPad Steps to reproduce: 1. Launch chrome and load any web page like ‘amazon.com’ 2. Long press on any link and open in incognito tab 3. Once the page loads in incognito, close the tab 4. Go back to tab used in step 1 Observed results: Notice that page refreshes Expected results: Page shouldn’t refresh Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: No Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M65 Bug reproducible on the current beta channel build (App Version, iOS Version): yes on M66 Type-bug-regression? Yes Link to video/image: M66 behavior: https://drive.google.com/file/d/14h6KDq9Cf6C6LAWXU_Q7v1rSRukvpz9L/view?usp=sharing M65 behavior: https://drive.google.com/file/d/1Umt0-PrDVEPkziClMsS6Y1X5jZJOEal8/view?usp=sharing
,
Mar 14 2018
Good build:66.0.3356.0 Canary Bad build: 66.0.3357.0 Canary
,
Mar 14 2018
eugenebut@ could you PTAL or triage it?
,
Mar 14 2018
Ramesh could you please include good and bad git revisions.
,
Mar 15 2018
Revision number for 66.0.3356.0 (Good version): a95cd07e7312 Revision number for 66.0.3357.0 (Bad version) : 6cab92768e15
,
Mar 15 2018
"git log a95cd07e7312..6cab92768e15 -- ios" shown quite a few changes in ios/chrome which could break this. ios/web had no changes between a95cd07e7312 and 6cab92768e15. Sergio, could you please bisect further since you working on ios/chrome rafactorings.
,
Mar 16 2018
https://chromium-review.googlesource.com/c/chromium/src/+/934501 introduced the issue. PTAL sdefresne@ I guess its being caused by activating/deactivating the main BVC.
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d6ceb1e0f8e3dd28ac71d70988a687ceadbc5e3 commit 7d6ceb1e0f8e3dd28ac71d70988a687ceadbc5e3 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Mar 20 14:39:54 2018 Stop disabling web usage if closing incognito tabs It is not necessary to disable web usage when clearing off-the-record browsing data (as the WebKit bug is not exercised in that case). Bug: 821753 Change-Id: I62b011ac182f8e8b7107109a23ac8102da44e574 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/970466 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544357} [modify] https://crrev.com/7d6ceb1e0f8e3dd28ac71d70988a687ceadbc5e3/ios/chrome/app/main_controller.mm
,
Mar 20 2018
,
Mar 20 2018
This bug requires manual review: Less than 24 days to go before AppStore submit on M66 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 21 2018
Please verify in canary
,
Mar 21 2018
Tested on in 67.0.3377.0 Canary, iPhone X iOS 11.3, iPhone 6 iOS 10.3.3 iPhone x iOS 11.3 looks good. iPhone 6 iOS 10.3.3 Web page still reloads. https://drive.google.com/file/d/1AyIUAfLKcsjylQEE4SrjxOvqqTOOOEaE/view
,
Mar 21 2018
In regards to iPhone 6, iOS 10.3.3 - I wanted to point out that the spinner in the status bar, is spinning when we reopen the tab.
,
Mar 23 2018
Comment#12,13 may not be similar to what the originally reported issue. Original reported issue is fixed and is good to merge into M66. Verified on M67.0.3379.0 canary, iOS11.3, 10.3.3
,
Mar 23 2018
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fac12c035b44e8565580437efebab46bc0ab948 commit 5fac12c035b44e8565580437efebab46bc0ab948 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Mar 23 17:05:45 2018 Stop disabling web usage if closing incognito tabs It is not necessary to disable web usage when clearing off-the-record browsing data (as the WebKit bug is not exercised in that case). Bug: 821753 Change-Id: I62b011ac182f8e8b7107109a23ac8102da44e574 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/970466 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#544357}(cherry picked from commit 7d6ceb1e0f8e3dd28ac71d70988a687ceadbc5e3) Reviewed-on: https://chromium-review.googlesource.com/978249 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#401} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/5fac12c035b44e8565580437efebab46bc0ab948/ios/chrome/app/main_controller.mm
,
Mar 28 2018
Verified on chrome beta version 66.0.3359.63 on iPad Mini with iOS 11.3 and iPhone x with iOS 11.2.6 following the steps mentioned in comment #0. Web page do not reload in normal tab on closing incognito tabs. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rakurati@chromium.org
, Mar 14 2018