New issue
Advanced search Search tips

Issue 821738 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove absolute paths from ninja files

Reported by pplucien...@opera.com, Mar 14 2018

Issue description

Some ninja rules contain absolute paths to files located inside repository.
It's caused by wrong path rebasing.
Affected files:
- build/config/mac/base_rules.gni,
- remoting/webapp/build_template.gni

 
I've added code review for it: https://chromium-review.googlesource.com/c/chromium/src/+/962282.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee12f5f86eb33e827f52f47f17374014420099a

commit dee12f5f86eb33e827f52f47f17374014420099a
Author: Pawel Pluciennik <ppluciennik@opera.com>
Date: Tue Apr 17 23:23:44 2018

Fixed problem with absolute paths in ninja files.

R=brettw@chromium.org, rsesek@chromium.org, sdefresne@chromium.org, sergeyu@chromium.org

Bug:  821738 
Change-Id: Ib1dcca4070ad7019c082653217df48adda69ab32
Reviewed-on: https://chromium-review.googlesource.com/962282
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551519}
[modify] https://crrev.com/dee12f5f86eb33e827f52f47f17374014420099a/build/config/mac/base_rules.gni
[modify] https://crrev.com/dee12f5f86eb33e827f52f47f17374014420099a/remoting/webapp/build_template.gni

Status: Fixed (was: Unconfirmed)

Sign in to add a comment