New issue
Advanced search Search tips

Issue 821736 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Checkmark doesn't appear properly after clicking on checkbox in chrome://history/

Reported by vku...@etouch.net, Mar 14 2018

Issue description

Chrome Version: 67.0.3370.0 (Official Build)Revision 540244ed4952574c2bb88ac553397e47e5f03c4e-refs/heads/master@{#542909} 32/64-bit.
OS: Windows(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.4) and Linux(14.04).

What steps will reproduce the problem?
(1)Launch chrome, navigate to chrome://flags and change 'Force UI direction' to 'Right-to-Left' and relaunch chrome.
(2)Navigate to 2-3 webpages, open chrome://history/
(3)Now click on any checkbox and observe.

Actual: Checkmark doesn't appear properly after clicking on checkbox.

Expected: Checkmark should be properly displayed after clicking on checkbox.

This is a regression issue broken in 'M67' and below is the manual bisect info
Good Build: 67.0.3368.0 (Revision:542341)
Bad Build:  67.0.3369.0 (Revision:542817)

 
Actual_history.mp4
195 KB View Download

Comment 1 by vku...@etouch.net, Mar 14 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 542361 (known good), but no later than 542362 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/feb3b5d8fc0436f4ae83736f450544142e9a21f1..b6477fef9acbe00a3e8b58b6963b518b57575ed3

Suspect: https://chromium.googlesource.com/chromium/src/+/b6477fef9acbe00a3e8b58b6963b518b57575ed3

@hcarmona: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Expected_history.mp4
101 KB View Download
Actual.png
83.6 KB View Download
Cc: hcarmona@chromium.org
 Issue 833366  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10ff5b5c9382264298a9244678c52db5f345b867

commit 10ff5b5c9382264298a9244678c52db5f345b867
Author: Hector Carmona <hcarmona@chromium.org>
Date: Tue Apr 17 20:13:59 2018

History WebUI: Fix regression that flipped checkboxes in RTL.

Bug:  821736 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I849ddd15a632309e09c8fec627832c41b0d39abb
Reviewed-on: https://chromium-review.googlesource.com/1014623
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551454}
[modify] https://crrev.com/10ff5b5c9382264298a9244678c52db5f345b867/chrome/browser/resources/md_history/history_item.html

Comment 5 by vku...@etouch.net, Apr 18 2018

Labels: TE-Verified-68.0.3399.0 TE-Verified-M68
Update:
Retested above issue in latest Canary build #68.0.3399.0 on Windows(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS and the issue is fixed. Kindly review an attached screen-cast.

Thank you!
Actual_Canary.mp4
205 KB View Download
Labels: Merge-Request-67
Fix is trivial (CSS only), requesting merge to 67 to prevent regression from hitting stable.
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 19 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gov...@chromium.org, Apr 19 2018

Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Dev/Beta release. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 19 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd813f880f3353b1ac19ff9d2e333e7c28c85491

commit dd813f880f3353b1ac19ff9d2e333e7c28c85491
Author: Hector Carmona <hcarmona@chromium.org>
Date: Thu Apr 19 19:35:08 2018

History WebUI: Fix regression that flipped checkboxes in RTL.

Bug:  821736 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I849ddd15a632309e09c8fec627832c41b0d39abb
Reviewed-on: https://chromium-review.googlesource.com/1014623
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551454}(cherry picked from commit 10ff5b5c9382264298a9244678c52db5f345b867)
Reviewed-on: https://chromium-review.googlesource.com/1019965
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#142}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/dd813f880f3353b1ac19ff9d2e333e7c28c85491/chrome/browser/resources/md_history/history_item.html

Status: Fixed (was: Started)
Merged ^_^

Comment 11 by vku...@etouch.net, Apr 24 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3396.18
Update : 
Retested above issue in latest Dev build #67.0.3396.18 on Windows(7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.13.5) & Linux(14.04 LTS) OS and the issue is fixed. Kindly review an attached screen-cast.

Thank you..!
Actual_checkbox.mp4
147 KB View Download

Sign in to add a comment