Regression:Checkmark doesn't appear properly after clicking on checkbox in chrome://history/
Reported by
vku...@etouch.net,
Mar 14 2018
|
||||||||
Issue descriptionChrome Version: 67.0.3370.0 (Official Build)Revision 540244ed4952574c2bb88ac553397e47e5f03c4e-refs/heads/master@{#542909} 32/64-bit. OS: Windows(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.4) and Linux(14.04). What steps will reproduce the problem? (1)Launch chrome, navigate to chrome://flags and change 'Force UI direction' to 'Right-to-Left' and relaunch chrome. (2)Navigate to 2-3 webpages, open chrome://history/ (3)Now click on any checkbox and observe. Actual: Checkmark doesn't appear properly after clicking on checkbox. Expected: Checkmark should be properly displayed after clicking on checkbox. This is a regression issue broken in 'M67' and below is the manual bisect info Good Build: 67.0.3368.0 (Revision:542341) Bad Build: 67.0.3369.0 (Revision:542817)
,
Apr 16 2018
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10ff5b5c9382264298a9244678c52db5f345b867 commit 10ff5b5c9382264298a9244678c52db5f345b867 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Apr 17 20:13:59 2018 History WebUI: Fix regression that flipped checkboxes in RTL. Bug: 821736 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I849ddd15a632309e09c8fec627832c41b0d39abb Reviewed-on: https://chromium-review.googlesource.com/1014623 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551454} [modify] https://crrev.com/10ff5b5c9382264298a9244678c52db5f345b867/chrome/browser/resources/md_history/history_item.html
,
Apr 18 2018
Update: Retested above issue in latest Canary build #68.0.3399.0 on Windows(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS and the issue is fixed. Kindly review an attached screen-cast. Thank you!
,
Apr 18 2018
Fix is trivial (CSS only), requesting merge to 67 to prevent regression from hitting stable.
,
Apr 19 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2018
Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Dev/Beta release. Thank you.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd813f880f3353b1ac19ff9d2e333e7c28c85491 commit dd813f880f3353b1ac19ff9d2e333e7c28c85491 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Apr 19 19:35:08 2018 History WebUI: Fix regression that flipped checkboxes in RTL. Bug: 821736 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I849ddd15a632309e09c8fec627832c41b0d39abb Reviewed-on: https://chromium-review.googlesource.com/1014623 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551454}(cherry picked from commit 10ff5b5c9382264298a9244678c52db5f345b867) Reviewed-on: https://chromium-review.googlesource.com/1019965 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#142} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/dd813f880f3353b1ac19ff9d2e333e7c28c85491/chrome/browser/resources/md_history/history_item.html
,
Apr 19 2018
Merged ^_^
,
Apr 24 2018
Update : Retested above issue in latest Dev build #67.0.3396.18 on Windows(7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.13.5) & Linux(14.04 LTS) OS and the issue is fixed. Kindly review an attached screen-cast. Thank you..! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by vku...@etouch.net
, Mar 14 2018Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
101 KB
101 KB View Download
83.6 KB
83.6 KB View Download