New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 821732 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ kehuangli@chromium.org
dgreid@chromium.org
dalecur...@chromium.org
maxmorin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

AgcAudioStream assumes that GetMaxVolume() result is constant throughout the stream lifetime.

Project Member Reported by olka@chromium.org, Mar 14 2018 
Max volume is cached only once at [1].
Is it a correct assumption that the maximum volume of the stream never changes?
Specifically, is it true on CrOS [2] (see cras_client_get_system_max_capture_gain)?

[1] https://cs.chromium.org/chromium/src/media/audio/agc_audio_stream.h?l=165
[2] https://cs.chromium.org/chromium/src/media/audio/cras/cras_input.cc?q=GetMaxVolume&sq=package:chromium&l=313&dr=CSs

Comment 1 by olka@chromium.org, Mar 14 2018

Cc: kehuangli@chromium.org dgreid@chromium.org dalecur...@chromium.org maxmorin@chromium.org

Comment 2 by olka@chromium.org, Mar 14 2018

Components: Internals>Media>Capture
Owner: dgreid@chromium.org
Status: Assigned (was: Untriaged)
dgreid@ - could you comment?

Comment 3 by dgreid@chromium.org, Mar 26 2018 

The max capture gain might change if the stream switches to a different device with a different gain range. If the stream is pinned to a particular device, then the max gain will be constant.

Comment 4 by olka@chromium.org, Jul 31

Labels: OS-Chrome
Owner: ----
Status: Available (was: Assigned)
►

Sign in to add a comment