Make error message in the toast more descriptive (should mention that only @google.com users can use Debug button) |
||||
Issue description...even though I can. Probably because I am a trooper. Need to document which group the user should be in to be able to use it. Michael, can you please post an error message that you've received here? This affected issue 819237.
,
Mar 14 2018
Thanks for explaining. I've just tried this with a @chromium.org account and got a toast "Request failed. Reason: [object Object]". Would be nice to have a more descriptive error message.
,
Mar 14 2018
-> Kevin since people may try it, not understand why it failed, just give up and move on. So we don't have (much) signal on how many tried and failed to. The error message should hint that maybe another account may have access, albeit we can't state which. :/
,
Mar 14 2018
Alternatively, can we grant the right to trigger builds to Googler @chromium.org account? We have a group for that in https://chrome-infra-auth.appspot.com/auth/groups/google/googlers@chromium.org.
,
Mar 14 2018
That's a separate task, focusing this bug on the UI.
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/9991798ce69f2f016c1ae3665fb0797d969ac9a7 commit 9991798ce69f2f016c1ae3665fb0797d969ac9a7 Author: Kevin Lubick <kjlubick@google.com> Date: Thu Mar 15 12:48:56 2018 Improve server error message passthrough For Retry/Debug button, we override the default error with a suggestion to login to a different account Bug:821728 Change-Id: I7505f991df5f3161063ffaf01f58f240a6dd4111 Reviewed-on: https://chromium-review.googlesource.com/963221 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@chromium.org> [modify] https://crrev.com/9991798ce69f2f016c1ae3665fb0797d969ac9a7/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/9991798ce69f2f016c1ae3665fb0797d969ac9a7/appengine/swarming/ui/build/js/js.js [modify] https://crrev.com/9991798ce69f2f016c1ae3665fb0797d969ac9a7/appengine/swarming/ui/res/imp/taskpage/task-page-demo.html [modify] https://crrev.com/9991798ce69f2f016c1ae3665fb0797d969ac9a7/appengine/swarming/ui/res/imp/taskpage/task-page.html [modify] https://crrev.com/9991798ce69f2f016c1ae3665fb0797d969ac9a7/appengine/swarming/ui/res/js/common.js
,
Mar 16 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/c614e81f06c0c56fc76ed338933a8d423ae7804f commit c614e81f06c0c56fc76ed338933a8d423ae7804f Author: Sergiy Byelozyorov <sergiyb@google.com> Date: Fri Mar 16 10:44:07 2018
,
Mar 16 2018
,
Mar 16 2018
The better error handling/message is now live. |
||||
►
Sign in to add a comment |
||||
Comment 1 by mar...@chromium.org
, Mar 14 2018